Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-25 Thread via GitHub
Arsnael merged PR #2005: URL: https://github.com/apache/james-project/pull/2005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-22 Thread via GitHub
chibenwa commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1960327108 Some fine tunning needed apparently... `org.apache.james.jmap.rfc8621.memory.MemoryEmailGetMethodTest.shouldSupportAttachedMessageWithComplexMultipart(GuiceJamesServer)`

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-21 Thread via GitHub
Arsnael commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1958809795 ``` 02:47:02,846 [ERROR] Failed to execute goal io.github.evis:scalafix-maven-plugin_2.13:0.1.8_0.11.0:scalafix (scala-check-style) on project

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-21 Thread via GitHub
chibenwa commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1958174538 Edit: I did find my way around? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-21 Thread via GitHub
chibenwa commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1958086051 I found the faulty input! [nested_mixed_alternative.txt](https://github.com/apache/james-project/files/14365621/nested_mixed_alternative.txt) That's a pretty big

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-20 Thread via GitHub
Arsnael commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1496824568 ## server/data/data-jmap/src/main/java/org/apache/james/jmap/mime4j/SizeUtils.java: ## @@ -0,0 +1,99 @@

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-20 Thread via GitHub
chibenwa commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1496438985 ## server/data/data-jmap/src/main/java/org/apache/james/jmap/mime4j/SizeUtils.java: ## @@ -0,0 +1,99 @@

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-20 Thread via GitHub
chibenwa commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1954985312 Email/get on these two mails: [multipart_report.txt](https://github.com/apache/james-project/files/14350673/multipart_report.txt)

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-20 Thread via GitHub
Arsnael commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1953776169 > Could we tripple check exotic multiparts? I ain't too sure about all of that honestly, but could try -- This is an automated message from the Apache Git Service. To

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-20 Thread via GitHub
Arsnael commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1495473383 ## server/data/data-jmap/src/main/java/org/apache/james/jmap/mime4j/SizeUtils.java: ## @@ -0,0 +1,99 @@

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-20 Thread via GitHub
chibenwa commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1495409984 ## server/data/data-jmap/src/main/java/org/apache/james/jmap/mime4j/SizeUtils.java: ## @@ -0,0 +1,99 @@

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-19 Thread via GitHub
Arsnael commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1495171711 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailParseMethod.scala: ## @@ -103,7 +103,7 @@ class EmailParseMethod @Inject()(val

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-19 Thread via GitHub
chibenwa commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1494380825 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailParseMethod.scala: ## @@ -103,7 +103,7 @@ class EmailParseMethod

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-19 Thread via GitHub
Arsnael commented on code in PR #2005: URL: https://github.com/apache/james-project/pull/2005#discussion_r1494310057 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/Email.scala: ## @@ -610,7 +610,7 @@ private class EmailFullViewFactory

Re: [PR] JAMES-3995 Optimize Email/get [james-project]

2024-02-19 Thread via GitHub
Arsnael commented on PR #2005: URL: https://github.com/apache/james-project/pull/2005#issuecomment-1951975815 Seems creating issues with Email/parse method as well: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2005/7/testReport/ Will check... -- This is an