Arsnael commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1977901064
Closing this (again) in favor of
https://github.com/apache/james-project/pull/2085
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Arsnael closed pull request #2049: Revert git commit id maven plugin
URL: https://github.com/apache/james-project/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Arsnael commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1977818510
Well about that... :
https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v8.0.0
Seems it's released with the fix, I will take the time to test around and
chibenwa commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1976353112
+1 to revert, keep injectAllReactorProjects and wait
https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/701 for the
version upgrade...
--
This is an automated
Arsnael commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1976270048
@jeantil would you be ok if we maybe merge this first, open a ticket in
parallel for thinking again on this, and then solve it on an other PR?
Also I did add back in this PR
Arsnael commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1968165547
Thanks @jeantil for the suggestion, I think that might do it actually and
it's rather clean. I'm in favor, thanks for making the PR too @chibenwa
Closing this as a result.
Arsnael closed pull request #2049: Revert git commit id maven plugin
URL: https://github.com/apache/james-project/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
chibenwa commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1966592116
https://github.com/apache/james-project/pull/2063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chibenwa commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1963499656
> I wasn't aware that the James project build used git submodules.
Not in james but the use linagora uses James.
TLDR: it allows repackaging james, cross repository
jeantil commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1963493574
Hi,
I'm on limited connectivity this week.
I wasn't aware that the James project build used git submodules. There are
several limitations in the plugin with regard to
chibenwa commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1963490182
https://github.com/apache/james-project/pull/2050 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chibenwa commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1963472928
To be honnest I'd be more in favour of removing that plugin from global
build and configuring it only in `server/apps` modules.
--
This is an automated message from the Apache
Arsnael commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1963452919
> Have we tried disactivating it in tmail build?
I tried but wasn't successful. You are free to give it a shot though :)
--
This is an automated message from the Apache Git
chibenwa commented on PR #2049:
URL: https://github.com/apache/james-project/pull/2049#issuecomment-1963406487
Have we tried disactivating it in tmail build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Arsnael opened a new pull request, #2049:
URL: https://github.com/apache/james-project/pull/2049
@jeantil I'm sorry to ask for this, but do you mind if we revert the upgrade
of the git-commit-id-maven-plugin for now?
It seems tocreate issues with projects using James as a submodule
15 matches
Mail list logo
