[
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-493:
---
Assignee: Jeffrey Nguyen
Extend TemplateOptions and CreateServerOptions to support fixed
Thank you very much for your review, Ignasi!
I think your comments make really sense to me and the summary is quite useful
Sorry for the missing (important!) tests but I'll add them while I address your
comments.
---
Reply to this email directly or view it on GitHub:
+ private final int statusId;
+ private final String mountType;
+ private final String mountMode;
+ private final int bootableFlag;
+ private final String device;
+ private final VirtualDiskImage virtualDiskImage;
+ private final VirtualGuest guest;
+
+
+ private final int statusId;
+ private final String mountType;
+ private final String mountMode;
+ private final int bootableFlag;
+ private final String device;
+ private final VirtualDiskImage virtualDiskImage;
+ private final VirtualGuest guest;
+
+
+ private final int statusId;
+ private final String mountType;
+ private final String mountMode;
+ private final int bootableFlag;
+ private final String device;
+ private final VirtualDiskImage virtualDiskImage;
+ private final VirtualGuest guest;
+
+
+ private final int statusId;
+ private final String mountType;
+ private final String mountMode;
+ private final int bootableFlag;
+ private final String device;
+ private final VirtualDiskImage virtualDiskImage;
+ private final VirtualGuest guest;
+
+
@Consumes(MediaType.APPLICATION_JSON)
- @Fallback(Fallbacks.NullOnNotFoundOr404.class)
- ProductPackage getProductPackage(@PathParam(id) long id);
+ @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class)
+ SetSoftwareDescription getAllObjects();
@nacx this confuses me as well: the
@Consumes(MediaType.APPLICATION_JSON)
- @Fallback(Fallbacks.NullOnNotFoundOr404.class)
- ProductPackage getProductPackage(@PathParam(id) long id);
+ @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class)
+ SetSoftwareDescription getAllObjects();
I'd rather use the
* @see
org.jclouds.googlecomputeengine.features.FirewallApi#patch(String,
org.jclouds.googlecomputeengine.options.FirewallOptions)
*/
- private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions
templateOptions, Network network,
-
ssh-agent is a more secure way of providing private ssh keys to ssh connections
since an attacker would have to have access to the memory of the client to get
access to the unencrypted key. Keys without encryption are accessible on the
disk.
You can merge this Pull Request by running:
git
[jclouds-labs-google-pull-requests
#50](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/50/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20#issuecomment-37303074
Thanks @psiniemi! This looks like great stuff. I'll give it a try in short!
BTW, do you know if this ssh-agent stuff can also be applied to the
`jclouds-sshj` driver by using the [sshj
integration](https://github.com/ymnk/jsch-agent-proxy/tree/master/jsch-agent-proxy-sshj)?
AFAIK, the sshj
+ this.networkUuid = networkUuid;
+ return this;
+ }
+
+ /**
+ * @param portUuid The port UUID for this neutron Network.
+ * @return The builder object.
+ * @see Network#getPortUuid()
+ */
+ public Builder portUuid(String portUuid)
+ protected String networkUuid;
+ protected String portUuid;
+ protected String fixedIp;
+
+ /**
+ * @param networkUuid The UUID for the nova network or neutron subnet
to be attached.
+ * @return The builder object.
+ * @see
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package
[jclouds-pull-requests
#648](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/648/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37309725
@@ -575,4 +604,14 @@ public NovaTemplateOptions configDrive(boolean
configDrive) {
this.configDrive = configDrive;
return this;
}
+
+ /**
+* @param novaNetworks The list of network declarations.
Comment on the difference between this and networks().
---
Reply to
I can probably make another pull request for the agent support for sshj. There
is at least an example of sshj using the same agent proxy.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37311936
Sure. I don't want that to block this PR, just wanted to point it out, as you
might be already familiar with the library and perhaps able to add support for
sshj faster than anyone else :)
---
Reply to this email directly or view it on GitHub:
Added the sshj bits. Works for me at least ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37317712
Awesome. Will try both today! Thanks @psiniemi!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37318216
I think I was able to add enough to explain which network properties are
neutron vs nova.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37320628
@@ -106,14 +106,13 @@ public void testCDNOperations() throws Exception {
cdnMetadata = getApi().getCDNMetadata(containerNameWithCDN);
final boolean cdnEnabled = cdnMetadata.isCDNEnabled();
final boolean logRetention = cdnMetadata.isLogRetention();
- final
Looks good.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37321406
I also added the live test. It seems to work. The instance boots... except in
an error state. Seem I have some network config issues on my devstack.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37321824
@@ -106,14 +106,13 @@ public void testCDNOperations() throws Exception {
cdnMetadata = getApi().getCDNMetadata(containerNameWithCDN);
final boolean cdnEnabled = cdnMetadata.isCDNEnabled();
final boolean logRetention = cdnMetadata.isLogRetention();
- final
[jclouds » jclouds
#899](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/899/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#649](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/649/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37324919
@@ -106,14 +106,13 @@ public void testCDNOperations() throws Exception {
cdnMetadata = getApi().getCDNMetadata(containerNameWithCDN);
final boolean cdnEnabled = cdnMetadata.isCDNEnabled();
final boolean logRetention = cdnMetadata.isLogRetention();
- final
[jclouds-pull-requests
#650](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/650/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37327628
[jclouds-java-7-pull-requests
#1120](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1120/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37328301
[
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930666#comment-13930666
]
Jeffrey Nguyen commented on JCLOUDS-493:
Thank you Zack for the reply. I wasn't
[jclouds » jclouds
#900](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/900/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Might be worth mentioning that I had no way of testing this on a windows
client. Pageant should work, but I have no way of verifying that...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37329118
As not to disrupt the legacy Cloud Files API signatures, I converted the int
back to long for the TTL. The newer implementation uses an int for the
[jclouds-pull-requests
#651](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/651/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37335611
[jclouds-java-7-pull-requests
#1121](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1121/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/309#issuecomment-37336639
/**
* @author Adrian Cole
*/
@Test(groups = unit, testName = VirtualGuestToNodeMetadataTest)
public class VirtualGuestToNodeMetadataTest {
+
+ // TODO
+ /*
I think this test doesn't make sense anymore as the VirtualGuestToNodeMetadata
is now really simpler.
---
Reply to this
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/794/
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37341757
Going to rebase/merge now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37341952
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311#issuecomment-37345909
[
https://issues.apache.org/jira/browse/JCLOUDS-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930900#comment-13930900
]
ASF subversion and git services commented on JCLOUDS-486:
-
Commit
[
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930921#comment-13930921
]
Zack Shoylev commented on JCLOUDS-493:
--
Alright, I looked into it some more. So here
[jclouds » jclouds
#902](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/902/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
...orts.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds
backport-add-nova-neutron-networks
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/313
-- Commit Summary --
* JCLOUDS-486 This will allow
Note: backporting
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313#issuecomment-37348415
[jclouds-java-7-pull-requests
#1125](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1125/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/314#issuecomment-37352662
[jclouds-pull-requests
#653](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/653/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-37352984
[jclouds-pull-requests
#654](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/654/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313#issuecomment-37352983
[jclouds-java-7-pull-requests
#1124](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1124/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313#issuecomment-37353113
See
https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-compute/2554/
See https://jclouds.ci.cloudbees.com/job/jclouds/2554/changes
[
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931039#comment-13931039
]
Zack Shoylev commented on JCLOUDS-493:
--
1. Are you ok with tracking improvements in
[jclouds-pull-requests
#655](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/655/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/314#issuecomment-37353487
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/826/
--
Started by upstream project jclouds/jclouds build number 904
Building remotely on s-64451664 in workspace
https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/ws/
[
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931091#comment-13931091
]
Jeffrey Nguyen commented on JCLOUDS-493:
Hi Zack,
Ok with both #1 #2. Please go
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds-examples compile-examples
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-examples/pull/33
-- Commit Summary --
* Compile examples with 1.7.1 and repair
@etoews @zack-shoylev the rackspace examples do not compile due to a missing
```NovaTemplateOptions.Builder.configDrive```. Can you update this example and
add the rackspace module to pom.xml?
---
Reply to this email directly or view it on GitHub:
Are you refering to https://github.com/jclouds/jclouds-examples/pull/32 ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359486
Is something broken, are you missing #32 or are you missing the revert?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359723
[
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931149#comment-13931149
]
Zack Shoylev commented on JCLOUDS-493:
--
Jeffrey:
I am not sure the Nova Network
@zack-shoylev sorry I had a stale tree; I will update the pull request.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359857
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/303#issuecomment-37375489
Closed #290.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290
Thanks a lot for the update and the PR @trainman419! I'll close this as a
duplicate and we'll move forward with #303.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-37375486
66 matches
Mail list logo
