Re: [jclouds-labs-openstack] WIP: JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

Thanks @jasdeep-hundal! Will merge the Keystone PR later today. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/82#issuecomment-37908051

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

Closed #39. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

Squashed, rebased and merged. Many thanks @demobox and @iocanel ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37909638

[jclouds-cli] Added support for the DigitalOcean provider (#17)

You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-cli do17x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-cli/pull/17 -- Commit Summary -- * Added support for the DigitalOcean provider -- File Changes --

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

[jclouds-cli-pull-requests #17](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/17/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37910144

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

The feature is not yet in the local repo. Will have to wait a bit :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37910210

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

The karaf 1.7.x build has just finished. Let's see if it can find the feature now... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37913207

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

Closed #17. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

[jclouds-cli-pull-requests #18](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/18/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37913796

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

Merged! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37913833

Re: [jclouds-labs] BlobStore API for Orion based back-ends (#45)

Any news on this PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/45#issuecomment-37945418

[jira] [Commented] (JCLOUDS-446) Script doesn't run

[ https://issues.apache.org/jira/browse/JCLOUDS-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939393#comment-13939393 ] Izek Greenfield commented on JCLOUDS-446: - Yes > Script doesn't run > -

[jira] [Created] (JCLOUDS-504) search for group name in tags

Izek Greenfield created JCLOUDS-504: --- Summary: search for group name in tags Key: JCLOUDS-504 URL: https://issues.apache.org/jira/browse/JCLOUDS-504 Project: jclouds Issue Type: Improvement

[jira] [Commented] (JCLOUDS-317) OpenStack Nova v2.0 Domain Server Status missing from OpenStack API

[ https://issues.apache.org/jira/browse/JCLOUDS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939444#comment-13939444 ] Jacob Mourelos commented on JCLOUDS-317: Looking at the [havana source code|http

Re: [jclouds-cli] Added support for the DigitalOcean provider (#17)

+1 - looks good to me. Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/17#issuecomment-37956576

Re: [jclouds-karaf] Added support for the DigitalOcean provider (#39)

Commit is [here](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=176deecd8e3f98165c41c6d72055b597ac0ed3d0) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/39#issuecomment-37957108

Re: [jclouds] JCLOUDS-492 (#318)

> The test failures was a bummer. I thought a commit to Github will only > update my fork branch and I can send it for a review. You don't have to worry about the test failures. The Jenkins builds are automatically adding your diff to a copy of the code and running tests - nothing is changed in

Re: [jclouds-labs-openstack] WIP: JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

@nacx: Thanks for doing that. Should I squash/rebase this PR for merging as well? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/82#issuecomment-37957831

Re: [jclouds] JCLOUDS-492 (#318)

> @@ -44,7 +44,12 @@ > > private int deviceIndex = 1; > > - /** > +public RegisterImageBackedByEbsOptions() { > +formParameters.put("BlockDeviceMapping.0.DeviceName", "/dev/sda1"); > +formParameters.put("RootDeviceName","/dev/sda1"); And a minor comment: missing space

Re: [jclouds] JCLOUDS-492 (#318)

> @@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions > addNewBlockDevice(String deviceName, >return this; > } > > +/** > + * > + * sets the ROOT device name to the specified name. "Sets" (capital 'S"), and please remove the blank line above. I know "adds" above

Re: [jclouds] JCLOUDS-492 (#318)

> @@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions > addNewBlockDevice(String deviceName, >return this; > } > > +/** > + * > + * sets the ROOT device name to the specified name. > + * > + * @param name > + * The device name (e.g., /dev/sdh

Re: [jclouds] JCLOUDS-492 (#318)

> @@ -130,6 +135,22 @@ public RegisterImageBackedByEbsOptions > addNewBlockDevice(String deviceName, >return this; > } > > +/** > + * > + * sets the ROOT device name to the specified name. > + * > + * @param name > + * The device name (e.g., /dev/sdh

Re: [jclouds] JCLOUDS-492 (#318)

> + * Options to specify metadata such as architecture or > secondary volumes to be > + * associated with this image. > + * @return imageId > + * > + * @see #describeImages > + * @see #deregisterImage > + * @see + * > "http://docs.amazonwe

Re: [jclouds] JCLOUDS-492 (#318)

> + > +request = (GeneratedHttpRequest) > request.getFilters().get(0).filter(request); > + > +assertRequestLineEquals(request, "POST > https://ec2.us-east-1.amazonaws.com/ HTTP/1.1"); > +assertNonPayloadHeadersEqual(request, "Host: > ec2.us-east-1.amazonaws.com\n"); > +

Re: [jclouds] JCLOUDS-492 (#318)

Thanks Andrew for the clarification. That is a relief to know that the main repo is not touched :) Rgds Jai On Tue, Mar 18, 2014 at 9:54 AM, Andrew Phillips wrote: > The test failures was a bummer. I thought a commit to Github will only > update my fork branch and I can send it for a review. >

[jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

You can merge this Pull Request by running: git pull https://github.com/kstyrc/jclouds master Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/320 -- Commit Summary -- * JCLOUDS-184: Improving AzureBlob unit tests * JCLOUDS-184: Improving

[jira] [Commented] (JCLOUDS-184) Improve AzureBlob Unit Tests

[ https://issues.apache.org/jira/browse/JCLOUDS-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939649#comment-13939649 ] Krzysztof Styrc commented on JCLOUDS-184: - https://github.com/jclouds/jclouds/pul

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

[jclouds-pull-requests #667](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/667/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/320#issuecomment-37978819

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

[jclouds-java-7-pull-requests #1137](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1137/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/320#issuecomment-37979552

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> +import com.google.common.base.Supplier; > +import com.google.common.base.Throwables; > +import com.google.common.cache.CacheBuilder; > +import com.google.common.cache.CacheLoader; > +import com.google.common.cache.LoadingCache; > + > +/** > + * > + * @author Jasdeep Hundal > + */ > +@Singleton

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + public String status; > + public String id; > + public List links; > + } > + public List versions; > + } > + > + private final Supplier>> zoneToEndpointSupplier; > + private final String apiVersion; > + private final LoadingCache endpointCache; > + > +

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + this.zoneToEndpointSupplier = checkNotNull(zoneToEndpointSupplier, > "zoneToEndpointSupplier"); > + if(!apiVersionString.startsWith("v")) > + apiVersionString = "v" + apiVersionString; > + this.apiVersion = apiVersionString; > + this.endpointCache = CacheBuilder.new

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + if(!apiVersionString.startsWith("v")) > + apiVersionString = "v" + apiVersionString; > + this.apiVersion = apiVersionString; > + this.endpointCache = CacheBuilder.newBuilder() > + .build( > +new CacheLoader() { > + public URI load(URI bas

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + .build( > +new CacheLoader() { > + public URI load(URI baseEndpointUri) { > + URI versionEndpointUri = null; > + try { > + HttpRequest negotiationRequest = HttpRequest.builder() > +.m

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + try { > + HttpRequest negotiationRequest = HttpRequest.builder() > +.method("GET").endpoint(baseEndpointUri) > +.addHeader(VERSION_NEGOTIATION_HEADER, > "true").build(); > + InputStream res

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + VersionsJsonResponse versions = > json.fromJson(Strings2.toStringAndClose(response), > VersionsJsonResponse.class); > + for( VersionsJsonResponse.Version version : > versions.versions ) { > +if(apiVersion.equals(version.id)) { >

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + break; > +} > + } > + } catch (Exception ex) { > + throw Throwables.propagate(ex); > + } > + if (versionEndpointUri == null) > + throw

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + } > + } catch (Exception ex) { > + throw Throwables.propagate(ex); > + } > + if (versionEndpointUri == null) > + throw new HttpException("Glance endpoint does not > support API versio

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> @@ -46,6 +47,11 @@ public void handleError(HttpCommand command, HttpResponse > response) { >message = message != null ? message : String.format("%s -> %s", > command.getCurrentRequest().getRequestLine(), > response.getStatusLine()); >switch (response.getStatusCod

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> +import com.google.common.base.Supplier; > +import com.google.common.base.Throwables; > +import com.google.common.cache.CacheBuilder; > +import com.google.common.cache.CacheLoader; > +import com.google.common.cache.LoadingCache; > + > +/** > + * > + * @author Jasdeep Hundal > + */ > +@Singleton

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + public String status; > + public String id; > + public List links; > + } > + public List versions; > + } > + > + private final Supplier>> zoneToEndpointSupplier; > + private final String apiVersion; > + private final LoadingCache endpointCache; > + > +

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> @@ -0,0 +1,44 @@ > +{ [minor] I think we normally use smaller indents for JSON files? I may be wrong, though. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/82/files#r10724813

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

I think we're missing some tests for this new functionality: what should happen if the API version is/is not found, validating the http -> https switch etc. I'm not sure, though, whether the explicit use of HttpClient, as opposed to adding the version negotiation call as an explicit API call els

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> +import com.google.common.base.Supplier; > +import com.google.common.base.Throwables; > +import com.google.common.cache.CacheBuilder; > +import com.google.common.cache.CacheLoader; > +import com.google.common.cache.LoadingCache; > + > +/** > + * > + * @author Jasdeep Hundal > + */ > +@Singleton

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + public String status; > + public String id; > + public List links; > + } > + public List versions; > + } > + > + private final Supplier>> zoneToEndpointSupplier; > + private final String apiVersion; > + private final LoadingCache endpointCache; > + > +

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + break; > +} > + } > + } catch (Exception ex) { > + throw Throwables.propagate(ex); > + } > + if (versionEndpointUri == null) > + throw

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

As per a previous discussion: +1 to this if the new response value `https://glance.jclouds.org:9292/` is one that could be realistically returned by an OpenStack installation. From what I recall, someone (@zack-shoylev? @everett-toews?) confirmed that that was indeed the case. --- Reply to this

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Thanks, @jasdeep-hundal! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/319#issuecomment-37987013

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + public String status; > + public String id; > + public List links; > + } > + public List versions; > + } > + > + private final Supplier>> zoneToEndpointSupplier; > + private final String apiVersion; > + private final LoadingCache endpointCache; > + > +

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + public String status; > + public String id; > + public List links; > + } > + public List versions; > + } > + > + private final Supplier>> zoneToEndpointSupplier; > + private final String apiVersion; > + private final LoadingCache endpointCache; > + > +

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> @@ -0,0 +1,44 @@ > +{ I think it was actually 4 in the keystoneAuthResponse.json, but I'm not consistent with that either here... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/82/files#r10725757

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> @@ -46,6 +47,11 @@ public void handleError(HttpCommand command, HttpResponse > response) { >message = message != null ? message : String.format("%s -> %s", > command.getCurrentRequest().getRequestLine(), > response.getStatusLine()); >switch (response.getStatusCod

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> + public String status; > + public String id; > + public List links; > + } > + public List versions; > + } > + > + private final Supplier>> zoneToEndpointSupplier; > + private final String apiVersion; > + private final LoadingCache endpointCache; > + > +

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

@demobox : Thanks for the eyes, pushed the minor fixes mentioned. Will get to the tests in a bit. On the note of an explicit use of HttpClient, I don't think the Image/GlanceApi is where this should go. Determining the right versioned endpoint is something that needs to happen before and ImageA

Jenkins build is unstable: jclouds » jclouds-labs-openstack #927

See

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

[jclouds » jclouds-labs-openstack #927](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/927/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: h

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

[jclouds-labs-openstack-pull-requests #182](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/182/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/8

Re: [jclouds-site] Modernize BlobStore examples (#59)

Pushed to master and deployed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37999805

Re: [jclouds-site] Modernize BlobStore examples (#59)

Closed #59. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/59

Re: [jclouds-site] Modernize BlobStore examples (#59)

Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/59#issuecomment-38003514

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

> Thinking about it some more, would it be possible/cleaner to use a > retryHandler instead of an > errorHandler to deal with the HttpClient behavior on HTTP responses with a > 300 status code? Well, the "cleanest" thing I can think of would be to hook in where the success/failure of the call

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

> public class AzureBlobBlockUploadStrategyTest { > > + @Test(groups = "unit", testName = "AzureBlobBlockUploadStrategyTest") Why has this moved here? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/320/files#r10731992

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

> > import java.util.List; > > -import static org.easymock.EasyMock.anyObject; > -import static org.easymock.EasyMock.createMock; > -import static org.easymock.EasyMock.eq; > -import static org.easymock.EasyMock.expect; > -import static org.easymock.EasyMock.expectLastCall; > -import static or

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

> @@ -70,5 +65,29 @@ public void testExecute() throws Exception { >replay(slicer,client); >String etag = strat.execute(container, blob); >assertEquals(etag, "Fake ETAG"); > + > + verify(slicer, client); > + } > + > + @Test(groups = "unit", expectedExceptions = > Il

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

> @@ -70,5 +65,29 @@ public void testExecute() throws Exception { >replay(slicer,client); >String etag = strat.execute(container, blob); >assertEquals(etag, "Fake ETAG"); > + > + verify(slicer, client); What is the benefit of this? Are we interested in how often exactl

Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes (#317)

> @@ -112,4 +113,21 @@ public Integer answer() throws Throwable { > > } > > + @Test > + public void test504DoesRetry() { > + AWSUtils utils = createMock(AWSUtils.class); > + HttpCommand command = createMock(HttpCommand.class); > + expect(command.getFailureCount()).andRetu

Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes (#317)

If I understand correctly, the change basically was "delegate decision to retry to parent class on 504"? If I'm getting that right, +1 - looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/317#issuecomment-38011814

Re: [jclouds] Updating the features section to match the website (#316)

> jclouds-java-7-pull-requests #1128 UNSTABLE Just for the record, that was a [spurious test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1128/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocket