Re: [jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

> } > > + // The EC2 provider already overrides the getImage method in a way that > this test makes no sense in it. "The EC2 provider already overrides the getImage method so this test is not useful for EC2" or so? --- Reply to this email directly or view it on GitHub: https://github.co

Re: [jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

> @@ -192,6 +198,7 @@ public void testParseOnDemandWithoutRegionEncodedIntoId() > { >verify(defaultOptions); >verify(optionsProvider); >verify(templateBuilderProvider); > + verify(getImageStrategy); [minor] Turn these into `verify(defaultOptions, optionsProvider, ...)

Re: [jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

> @@ -179,9 +184,10 @@ public void > testParseOnDemandWithoutRegionEncodedIntoId() { >replay(defaultOptions); >replay(optionsProvider); >replay(templateBuilderProvider); > + replay(getImageStrategy); [minor] Turn these into `replay(defaultOptions, optionsProvider, ...

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

Thanks for the update, @zack-shoylev! The PR builder reports 6 [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/279/violations/), by the way, but none seem related to this PR. --- Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> + server.shutdown(); > + } > + } > + > + public void listPagedIterableCollectionQueuesFail() throws Exception { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(new MockResponse().setBody(accessRackspace)); > + server.enqueue(new MockResponse().

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> @@ -34,10 +35,7 @@ > import java.util.UUID; > > import static > org.jclouds.openstack.marconi.v1.options.ListQueuesOptions.Builder.limit; > -import static org.testng.Assert.assertEquals; > -import static org.testng.Assert.assertFalse; > -import static org.testng.Assert.assertNotNull; > -impo

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> +import static org.jclouds.util.Throwables2.getFirstThrowableOfType; > + > +public class EmptyQueuesFallback implements Fallback { > + > + public ListenableFuture create(Throwable t) throws Exception { > + return immediateFuture(createOrPropagate(t)); > + } > + > + public Queues create

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> +import static com.google.common.base.Preconditions.checkNotNull; > +import static com.google.common.base.Throwables.propagate; > +import static com.google.common.util.concurrent.Futures.immediateFuture; > +import static org.jclouds.http.HttpUtils.contains404; > +import static org.jclouds.util.Th

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> +import org.jclouds.rest.ResourceNotFoundException; > + > +import static com.google.common.base.Preconditions.checkNotNull; > +import static com.google.common.base.Throwables.propagate; > +import static com.google.common.util.concurrent.Futures.immediateFuture; > +import static org.jclouds.http.H

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

> + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache License, Version 2.0 > + * (the "License"); you may not use this file except in compliance w

Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)

> @demobox do you want to have a look before I merge it? Minor comments only ;-) > jclouds-java-7-pull-requests #1328 SUCCESS One new [Checkstyle violation](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1328/org.apache.jclouds.provider$hpcloud-compute/violations/), too. --

Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)

> >

Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)

> @@ -80,6 +86,9 @@ protected Builder() { > id("hpcloud-compute") > .name("HP Cloud Compute Services") > .apiMetadata(new NovaApiMetadata().toBuilder() > + .identityName("${tenantName}:${accessKey}") > + .credentialName("${secret}") I

Re: [jclouds] Adds get() method to KeyPairApi (#391)

> > + public void testGetKeyPair() throws Exception { Would it make sense to interleave this test with the `createDelete` test above? So we would do create - get - delete instead? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/391/files#r134734

Re: [jclouds] Adds get() method to KeyPairApi (#391)

> jclouds-java-7-pull-requests #1332 UNSTABLE Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1332/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrT

Re: [jclouds] Adds get() method to KeyPairApi (#391)

> > + public void testGetKeyPair() throws Exception { >for (String zoneId : api.getConfiguredZones()) { > KeyPairApi keyPairApi = > api.getKeyPairExtensionForZone(zoneId).get(); > KeyPair keyPair = null; > try { > keyPair = keyPairApi.createWi

Re: [jclouds] Adds get() method to KeyPairApi (#391)

> @@ -57,15 +58,30 @@ public void testCreateAndDeleteKeyPair() throws Exception > { > } > > public void testCreateAndDeleteKeyPairWithPublicKey() throws Exception { > - final String KEYPAIR_NAME = "testkp"; > - final String PUBLIC_KEY = "ssh-rsa > B3NzaC1yc2EDAQABg

Re: [jclouds] Adds get() method to KeyPairApi (#391)

> @@ -49,6 +48,16 @@ > KeyPair create(String name); > > /** > +* Gets a specific {@link KeyPair} by name. > +* > +* @param name > +* name of the Key Pair > +* > +* @return the specified {@link KeyPair} "...or `null` if no such KeyPair exists"? And/or a

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

I may have missed something, but I can't see any obvious tests for the new logic in `HPCloudObjectStorageRestClientModule`? Add a unit test for that? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/394#issuecomment-45293686

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

> + public static class HPCloudObjectStorageEndpointModule extends > KeystoneAuthenticationModule { > + @Provides > + @Singleton > + @Storage > + protected Supplier > provideStorageUrl(RegionIdToURISupplier.Factory factory, > +

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

> @@ -69,12 +69,7 @@ protected HPCloudObjectStorageBlobStore(BlobStoreContext > context, BlobUtils blob > > @Override > public boolean createContainerInLocation(Location location, String > container, CreateContainerOptions options) { > - try { > - return createContainerInLo

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

> }, userExecutor); > - return returnVal; > + } I may be missing something here, but now, if `isPublicRead` is true, `createContainerInLocation` is never called? Is that intentional? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pul

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

> jclouds-java-7-pull-requests #1329 SUCCESS Some new [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1329/org.apache.jclouds.provider$hpcloud-objectstorage/violations/). Could you have a look at those, @ccustine? --- Reply to this email directly or vie

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

> @@ -36,9 +36,7 @@ > > 1.0 > >

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

> @@ -72,6 +76,10 @@ public boolean apply(@Nullable StorageMetadata input) { > > assert metadata.getPublicUri() != null : metadata; > > + SocketOpen socketOpen = > context.utils().injector().getInstance(SocketOpen.class); > + Predicate socketTester = retry(socketOpen,

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

[jclouds » jclouds-labs-openstack #1243](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1243/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

[jclouds-labs-openstack-pull-requests #279](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/279/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/96#issuecomment-45292211

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

Okay this is another iteration of this problem taking review concerns into account. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/96#issuecomment-45291895

Re: [jclouds-site] A script for deploying Javadoc (#106)

> I'd say we can wait until we are worried about its javadocs Certainly! Adding only the stable ones obviously makes sense ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/106#issuecomment-45282874

Re: [jclouds-site] Javadoc for 1.7.x (#107)

Just tested this link:  Works just fine! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/107#issuecomment-45282801

Build failed in Jenkins: jclouds » jclouds-karaf #1011

See -- [...truncated 506 lines...] Downloaded: https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/driver/jclouds-slf4j/1.8.0-SNAPSHOT/maven-metadata.xml (2 K

Re: [jclouds-site] Javadoc for 1.7.x (#107)

Thx @demobox Merged and deployed! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/107#issuecomment-45281181

Re: [jclouds-site] Javadoc for 1.7.x (#107)

Closed #107. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/107#event-128594553

Build failed in Jenkins: jclouds » jclouds-chef #1040

See -- [...truncated 5 lines...] Fetching upstream changes from git://github.com/jclouds/jclouds-chef.git Checking out Revision 78fd4b136d6a6bdcc13903d029a5f6121a7d6d6a (origin/master) Clea

Re: [jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

[jclouds » jclouds #1189](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1189/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/396#issuecomme

Re: [jclouds-site] A script for deploying Javadoc (#106)

Yep, if we're happy with this (I am) we can add the stable ones. I'd not add the Abiquo one yet, though. I plan (I always plan things I never do xD) to update the provider to the 3.0 version which has a more stable and complete API and hope then it will be ready to be promoted to the main repo.

Re: [jclouds-site] A script for deploying Javadoc (#106)

No labs providers or APIs for now, I notice. @nacx: a follow-up PR to add those, perhaps? Certainly abiquo and perhaps also jclouds-chef, I can imagine? ;-) +1 - looks good to me. Thanks, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-s

Re: [jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

[jclouds-java-7-pull-requests #1333](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1333/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/396#issuecomment-45278844

Re: [jclouds-site] Javadoc for 1.7.x (#107)

+1 - looks good to me. Also fine using HTTPS. Thanks, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/107#issuecomment-45278850

Re: [jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

[jclouds-pull-requests #862](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/862/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/396#issuecomment-45278668

Re: [jclouds-labs] Add vSphere support (#61)

Thank you for your detailed research on the licensing topic, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-45278589

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

[jclouds » jclouds-labs-openstack #1241](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1241/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

[jira] [Commented] (JCLOUDS-570) Cannot instantiate server using image-id on Rackspace/Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019302#comment-14019302 ] Everett Toews commented on JCLOUDS-570: --- This is/isn't a jclouds issue. With Rack

Re: [jclouds-labs-openstack] Adds paging fail tests for Queues. (#96)

[jclouds-labs-openstack-pull-requests #278](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/278/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/96

[jira] [Commented] (JCLOUDS-570) Cannot instantiate server using image-id on Rackspace/Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019285#comment-14019285 ] Ignasi Barrera commented on JCLOUDS-570: Patch here: https://github.com/jclouds/j

[jclouds] JCLOUDS-570: Fallback to the GetImageStrategy in TemplateBuilderImpl (#396)

If the TemplateBuilderImpl is given an imageId but the image can not be found in the image cache, fallback to the GetImageStrategy to perform a call to the provider to try to get it. We've seen that in some cases images are not returned in the image list but they actually exist in the provider. Th

[jira] [Commented] (JCLOUDS-581) Method calls "startNodesMatching" and "stopNodesMatching" added to BaseComputeService

[ https://issues.apache.org/jira/browse/JCLOUDS-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019205#comment-14019205 ] Christopher Dancy commented on JCLOUDS-581: --- Gotcha. It seems that if we were t

[jira] [Commented] (JCLOUDS-374) Exception while creating the server in OpenStack Nova API

[ https://issues.apache.org/jira/browse/JCLOUDS-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019187#comment-14019187 ] Everett Toews commented on JCLOUDS-374: --- I just ran into this error. The problem wa

Re: [jclouds-site] Javadoc for 1.7.x (#107)

Go to http://51940e726dbc654dac9a-f35c516239169fda9f94a4b76cb7862c.r48.cf1.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/107#issuecomment-45260749

Re: [jclouds-site] Javadoc for 1.7.x (#107)

[jclouds-site-pull-requests #336](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/336/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/107#issuecomment-45260530

[jclouds-site] Javadoc for 1.7.x (#107)

You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-site javadoc-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/107 -- Commit Summary -- * Javadoc for 1.7.x -- File Changes -- D refer

Re: [jclouds-site] A script for deploying Javadoc (#106)

Merged. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/106#issuecomment-45243207

Re: [jclouds-site] A script for deploying Javadoc (#106)

Closed #106. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/106#event-128459154

Re: [jclouds] JCLOUDS-584 - Update HP Cloud object storage provider (#394)

@shrinandj I added a comment on the actual Jira issue at https://issues.apache.org/jira/browse/JCLOUDS-584 just pointing out the major changes. Let me know if you have questions about specific parts of the code by adding line comments here in the PR and I will address them. --- Reply to this em

[jira] [Commented] (JCLOUDS-584) Update HP Cloud object storage provider

[ https://issues.apache.org/jira/browse/JCLOUDS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018906#comment-14018906 ] Chris Custine commented on JCLOUDS-584: --- The main areas affected by this change are

Re: [jclouds] Adds get() method to KeyPairApi (#391)

[jclouds-java-7-pull-requests #1332](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1332/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/391#issuecomment-45237041

Build failed in Jenkins: jclouds » jclouds-karaf #1010

See -- [...truncated 506 lines...] Downloaded: https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/driver/jclouds-slf4j/1.8.0-SNAPSHOT/maven-metadata.xml (2 K

Re: [jclouds] Adds get() method to KeyPairApi (#391)

[jclouds-pull-requests #861](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/861/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/391#issuecomment-45235781

Build failed in Jenkins: jclouds » jclouds-chef #1039

See -- [...truncated 16 lines...] log4j:WARN No appenders could be found for logger (org.apache.commons.beanutils.converters.BooleanConverter). log4j:WARN Please initialize the log4j syste

Re: [jclouds-site] A script for deploying Javadoc (#106)

Go to http://0a86fd178a5077054abf-884b3cef964e2425926241444b78551e.r98.cf1.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/106#issuecomment-45233006

[jira] [Created] (JCLOUDS-587) NPE when creating a security group in with AWS provider

Charles Paclat created JCLOUDS-587: -- Summary: NPE when creating a security group in with AWS provider Key: JCLOUDS-587 URL: https://issues.apache.org/jira/browse/JCLOUDS-587 Project: jclouds

Re: [jclouds] Adds get() method to KeyPairApi (#391)

[jclouds » jclouds #1188](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1188/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/391#issuecomme

Re: [jclouds-site] A script for deploying Javadoc (#106)

[jclouds-site-pull-requests #335](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/335/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/106#issuecomment-45232737

Re: [jclouds] Adds get() method to KeyPairApi (#391)

Changes LGTM :) Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/391#issuecomment-45230373

Re: [jclouds-labs] Add vSphere support (#61)

We've been discussing the licensing thing in the [dev mailing list](http://markmail.org/message/ljrzbz32wm7vxusn) (please, read the entire thread) to clarify how your contribution should be properly licensed. There is no need to send a CCLA, because the contribution terms are already covered in

Re: [jclouds] Adds get() method to KeyPairApi (#391)

@nacx Thanks for the review! I have addressed all of your comments in 1e18660 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/391#issuecomment-45227870

Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)

I've run the live tests for the PR and the results are great. Thanks! @demobox do you want to have a look before I merge it? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/393#issuecomment-45224884

Re: [jclouds-labs] Add vSphere support (#61)

Contributions made to the ASF must be under the terms of the [Contributor License Agreements](http://www.apache.org/licenses/#clas). That agreement implies a copyright and patent grant to the Apache Software Foundation for all software you and your employer contributes to the ASF. This means th

Re: [jclouds-labs] Add vSphere support (#61)

I am working on this code on my time at CISCO LTD. and I need to add this some where, where I can add this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-45209105

Re: [jclouds] Add vSphere support (#364)

We're already addressing both the licensing and authorship thing in the new pull request, and I'm pretty sure the contribution will properly reflect authorship and be aligned with the ASF licensing policy. Everyone is spending time on this, so let's be polite and respectful with everyone involv

Re: [jclouds] Add vSphere support (#364)

@andreaturli has provided link to original PR. He has also analysed code and it is clear you built on his earlier work so should have acknowledged this and collaborated with him. Maybe your handle should be ibrownfield :-) --- Reply to this email directly or view it on GitHub: https://github.com

Re: [jclouds-labs] Add vSphere support (#61)

Sure. This contribution you're submitting falls in the "Source File Headers for Code Developed at the ASF" category of the mentioned policy. Please, read the link in my comment. I assume you are the author of that code (regardless of if it is based on Andrea's one), so it is not a "third party

Re: [jclouds-labs] Add vSphere support (#61)

Could you explain the Licensing section? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-45203776

Re: [jclouds-labs] Add vSphere support (#61)

Thanks for the contribution @igreenfield! Before going through the code to review it, there are a couple things to consider: **Licensing** According to the [ASF Source Header and Copyright Notice Policy](http://www.apache.org/legal/src-headers.html), this contribution does not fall into the "th

Re: [jclouds] Add vSphere support (#364)

Where I can find now your old code? I need to compare it to my new code. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/364#issuecomment-45200673

Re: [jclouds] Add vSphere support (#364)

I have changed almost all your original code. I issued it in the labs. And continue work on this on the labs until it will be stable. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/364#issuecomment-45197936

Re: [jclouds] Add vSphere support (#364)

@igreenfield Thanks for resuming my old work on jclouds-vsphere (https://github.com/jclouds/legacy-jclouds/pull/910) with this refreshed PR. I'd have appreciated to be in the loop to help. Also, I think this PR should be issued against jclouds/jclouds-lab project. @nacx @demobox wdyt? --- Re

Re: [jclouds] Add vSphere support (#364)

I will fix this… and remove unused code From: Duncan Johnston-Watt [mailto:notificati...@github.com] Sent: Thursday, June 05, 2014 11:53 AM To: jclouds/jclouds Cc: Izek Greenfield (igreenfi) Subject: Re: [jclouds] Add vSphere support (#364) @igreenfield you've inc

[jira] [Updated] (JCLOUDS-570) Cannot instantiate server using image-id on Rackspace/Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-570: --- Fix Version/s: 1.7.4 1.8.0 > Cannot instantiate server using image-id on

[jira] [Commented] (JCLOUDS-570) Cannot instantiate server using image-id on Rackspace/Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018601#comment-14018601 ] Ignasi Barrera commented on JCLOUDS-570: Do we know why the image does not appear

[jira] [Assigned] (JCLOUDS-570) Cannot instantiate server using image-id on Rackspace/Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-570: -- Assignee: Ignasi Barrera > Cannot instantiate server using image-id on Rackspace/Nova

Re: [jclouds] Add vSphere support (#364)

@igreenfield you've included code originally written by @andreaturli in this PR which you've claimed is (c) Cisco Systems --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/364#issuecomment-45195751

Re: [jclouds] Fixing Jclouds-509 (#333)

I think I didn't explain properly what I wanted to say. We need the three tests I mentioned in my last comment. Regarding the `addSecurityGroups` one, there are not tests for other use cases of that method, but we need at least the ones that validate the changes in this PR. What I suggested was

Re: [jclouds] Add vSphere support (#364)

> + > +org.apache.jclouds.driver > +jclouds-sshj > +${project.version} > +test > + > + > +org.apache.jclouds.driver > +jclouds-log4j > +${project.version} > +test > + > +