Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -100,7 +100,7 @@ protected HttpResponse invoke(HttpURLConnection > connection) throws IOException, >HttpResponse.Builder builder = HttpResponse.builder(); >InputStream in = null; >try { > - in = consumeOnClose(connection.getInputStream()); > + in = conn

[jira] [Updated] (JCLOUDS-594) ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds

[ https://issues.apache.org/jira/browse/JCLOUDS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-594: Fix Version/s: 1.7.4 > ComputeService.suspendNodesMatching throwing UnsupportedOperationEx

[jira] [Updated] (JCLOUDS-594) ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds

[ https://issues.apache.org/jira/browse/JCLOUDS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-594: Attachment: JCLOUDS-594-1.7.x.patch > ComputeService.suspendNodesMatching throwing Unsuppo

Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds (#424)

> Just bumping to see if you want to merge this backport Done - merged to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=f52a264). Thanks, @ccustine! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/424#issuecomment-48426676

[jira] [Commented] (JCLOUDS-594) ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds

[ https://issues.apache.org/jira/browse/JCLOUDS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055817#comment-14055817 ] ASF subversion and git services commented on JCLOUDS-594: - Commit

Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds (#424)

> Just bumping to see if you want to merge this backport Will try to have a look a little later...thanks for the ping! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/424#issuecomment-48423481

Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds (#424)

@demobox Just bumping to see if you want to merge this backport --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/424#issuecomment-48420472

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

[jclouds » jclouds #1342](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1342/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/435#issuecomment-48418542

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

[jclouds-java-7-pull-requests #1444](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1444/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/435#issuecomment-48415896

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

[jclouds-pull-requests #973](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/973/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/435#issuecomment-48415432

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -100,7 +100,7 @@ protected HttpResponse invoke(HttpURLConnection > connection) throws IOException, >HttpResponse.Builder builder = HttpResponse.builder(); >InputStream in = null; >try { > - in = consumeOnClose(connection.getInputStream()); > + in = conn

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -100,7 +100,7 @@ protected HttpResponse invoke(HttpURLConnection > connection) throws IOException, >HttpResponse.Builder builder = HttpResponse.builder(); >InputStream in = null; >try { > - in = consumeOnClose(connection.getInputStream()); > + in = conn

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -616,6 +617,27 @@ public void testGetAndParseSax() throws Exception { >} > } > > + @Test > + public void testInterruptThrottledGet() throws Exception { > + long timeoutMillis = 10 * 1000; > + MockWebServer server = mockWebServer(new > MockResponse().setBody(XML).th

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -100,7 +100,7 @@ protected HttpResponse invoke(HttpURLConnection > connection) throws IOException, >HttpResponse.Builder builder = HttpResponse.builder(); >InputStream in = null; >try { > - in = consumeOnClose(connection.getInputStream()); > + in = conn

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -100,7 +100,7 @@ protected HttpResponse invoke(HttpURLConnection > connection) throws IOException, >HttpResponse.Builder builder = HttpResponse.builder(); >InputStream in = null; >try { > - in = consumeOnClose(connection.getInputStream()); > + in = conn

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

> @@ -616,6 +617,27 @@ public void testGetAndParseSax() throws Exception { >} > } > > + @Test > + public void testInterruptThrottledGet() throws Exception { > + long timeoutMillis = 10 * 1000; > + MockWebServer server = mockWebServer(new > MockResponse().setBody(XML).th

[jira] [Updated] (JCLOUDS-417) Payload.getInput.close reads all bytes from its InputStream

[ https://issues.apache.org/jira/browse/JCLOUDS-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-417: Description: Users do not expect this behavior when aborting getBlob operations. Further, by per

[jira] [Updated] (JCLOUDS-417) Payload.getInput.close reads all bytes from its InputStream

[ https://issues.apache.org/jira/browse/JCLOUDS-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-417: Summary: Payload.getInput.close reads all bytes from its InputStream (was: ConsumeOnCloseInputStr

[jira] [Updated] (JCLOUDS-417) Payload.getInput.close reads all bytes from its InputStream

[ https://issues.apache.org/jira/browse/JCLOUDS-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-417: Assignee: Thomas Manville > Payload.getInput.close reads all bytes from its InputStream >

Re: [jclouds] Remove ConsumeOnClose and add test (#435)

@tdmanv Please review. `git log` shows the correct attribution; unsure why GitHub shows @jenkins-maginatics. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/435#issuecomment-48410781

Re: [jclouds] Remove ConsumeOnCloseInputStream (#243)

@tdmanv Another user asked about cancellation on the jclouds user list and I revived your commit and added at test at #435. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/243#issuecomment-48410699

Re: [jclouds] Remove ConsumeOnCloseInputStream (#243)

Closed #243. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/243#event-139482818

[jclouds] Remove ConsumeOnClose and add test (#435)

You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds consume-on-close Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/435 -- Commit Summary -- * JCLOUDS-417: Remove ConsumeOnCloseInputStream * JCLOUDS

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

> + > +import com.google.common.base.Objects; > + > +/** > + * A Neutron Subnet Allocation Pool > + * > + * @see + * > href="http://docs.openstack.org/api/openstack-network/2.0/content/Subnets.html";>api > + * doc > + */ > +public class AllocationPool { > + > + protected final String

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

Thanks so much for having a look! ReturnNullOn404 - this needs to be fixed (I am pretty sure service does not return it, but still double checking some sources) @ConstructorProperties - based on previous discussions, I will add it back to domain classes. The plan is to rework those to follow the

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

I had this PR in the bottom of the TODO list, sorry for my late reply! I like the new pattern you propose. The model and the APIs look cleaner. The code look good to me, just a couple comments: * There are several POST requests that have the "ReturnNullOn404" fallback. Does the service really r

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

> + @GET > + @Path("/{id}") > + @ResponseParser(ParseRouters.class) > + @Fallback(EmptyRoutersFallback.class) > + Routers get(@PathParam("id") String id); > + > + /** > +* Create a new router > +* > +* @param router Options for creating a router > +* @return the newly cr

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

> + @SerializedName("n1kv:segment_add") > + protected final String segmentAdd; > + @SerializedName("n1kv:segment_del") > + protected final String segmentDel; > + @SerializedName("n1kv:member_segments") > + protected final String memberSegments; > + > + // multiprovidernet.py: Multipro

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

> + > +import com.google.common.base.Objects; > + > +/** > + * A Neutron Subnet Allocation Pool > + * > + * @see + * > href="http://docs.openstack.org/api/openstack-network/2.0/content/Subnets.html";>api > + * doc > + */ > +public class AllocationPool { > + > + protected final String

Re: [jclouds-labs-openstack] Neutron Refactoring (#111)

@nacx Can you give this another look? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/111#issuecomment-48395860

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> NP! I'll do later today. Thanks! ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-48367854

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

NP! I'll do later today. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-48363551

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> I'd like it in 1.7.x. @nacx I tried to apply [the patch](https://issues.apache.org/jira/secure/attachment/12654411/JCLOUDS-607.patch) but it doesn't work on master. Could you submit a PR for 1.7.x..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pul

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

> @@ -32,31 +30,30 @@ > * @see https://developers.google.com/storage/docs/cross-origin"; /> > */ > > -public final class BucketCors { > - private final Set origins; > - private final Set methods; > - private final Set responseHeaders; > +public class BucketCors { > + private final Set

Re: [jclouds] JCLOUDS-610: reboot, suspend, and resumeNodesMatching methods gain functionality similar to that of destroyNodesMatching (#419)

It does and thank you ;) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/419#issuecomment-48329444

Re: [jclouds] JCLOUDS-610: reboot, suspend, and resumeNodesMatching methods gain functionality similar to that of destroyNodesMatching (#419)

Yes it is. You'll find it if you look at the history. When you rebase to the latest master, the commit hash changes, and that's why GitHub does not detect the PR as merged. Usually we ask contributors to rebase the branch before merging, but sometimes is just more agile to rebase to the latest

Re: [jclouds] JCLOUDS-610: reboot, suspend, and resumeNodesMatching methods gain functionality similar to that of destroyNodesMatching (#419)

Did this PR get merged? I ask only because the last github message here is noting there are unmerged commits. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/419#issuecomment-48326473

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

> +bucketTemplate.add("acl", null); > + } > + // deal with DefaultObjectAccessControls > + if (!(src.getDefaultObjectAccessControls() == null) && > (src.getDefaultObjectAccessControls().isEmpty())) { > +bucketTemplate.add("defaultObjectAccessControls

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

> + BucketTemplateInternal template = new BucketTemplateInternal(src); > + JsonObject bucketTemplate = (JsonObject) > context.serialize(template, BucketTemplateInternal.class); > + > + // deal with bucketAccessControls > + if (!(src.getAcl() == null) && (src.getAcl(

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

[jclouds-labs-google-pull-requests #92](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/92/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/33#issuecomment-48292319

Re: [jclouds-labs-google] JCLOUDS-458: Addressing suggestions in PR-31 (#33)

[jclouds » jclouds-labs-google #1107](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1107/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Build failed in Jenkins: jclouds » jclouds CloudServers UK provider #2670

See -- [INFO] [INFO] --

Re: [jclouds-site] add docker guide (#110)

> + .modules(ImmutableSet. of(new > Log4JLoggingModule(), > +new > SshjSshClientModule())) > + .buildView(ComputeServiceContext.class); > +ComputeService client = context.getComputeService(); > + > +

Re: [jclouds-site] add docker guide (#110)

> +* Ensure you are using a recent JDK 6 > +* Setup your project to include `docker` > + * Get the dependency `org.jclouds.labs/docker` using jclouds > [Installation](/start/install). > +* Start coding > + > +{% highlight java %} > +// get a context with docker that offers the portable Compute

Re: [jclouds-site] add docker guide (#110)

> @@ -0,0 +1,43 @@ > +--- > +layout: page > +title: "Docker: Getting Started Guide" > +permalink: /guides/docker/ > +--- > + > +jclouds-docker is a local cloud provider modelled on > [docker](http://www.docker.io). Similar to other jclouds supported > +providers, it supports the same portable abst

Re: [jclouds-site] add docker guide (#110)

> +permalink: /guides/docker/ > +--- > + > +jclouds-docker is a local cloud provider modelled on > [docker](http://www.docker.io). Similar to other jclouds supported > +providers, it supports the same portable abstractions offered by jclouds. > + > +![jclouds docker architecture](/img/jclouds-dock

Re: [jclouds-site] add docker guide (#110)

Go to http://5350652a3b3a0f832b33-2bb942a57461dcb381b0c2aeb0a12b23.r79.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/110#issuecomment-48280414

Re: [jclouds-site] add docker guide (#110)

[jclouds-site-pull-requests #351](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/351/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/110#issuecomment-48280249

[jclouds-site] add docker guide (#110)

You can merge this Pull Request by running: git pull https://github.com/andreaturli/jclouds-site feature/docker Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/110 -- Commit Summary -- * add docker guide -- File Changes -- M _lay