Re: [jclouds] Ignore jEnv files (#495)

> it sucks to have to manually add all git-ignored files to the RAT plugin > exclusions. Feature request to the RAT team to "add all lines *in* a file to the RAT exclusion list"? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/495#issuecomment

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

> + String deviceName = null; > + > + /** > + * @param volumeId ID of the volume within the block store that you > wish to attach > + */ > + public BlockDeviceMapping volumeId(String volumeId){ > + this.volumeId = volumeId; > + return this; > + } > +

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

> @@ -155,6 +178,8 @@ protected ToStringHelper string() { > toString.add("networks", networks); >toString.add("availability_zone", availabilityZone == null ? null : > availabilityZone); >toString.add("configDrive", configDrive); > + if (!blockDeviceMapping.isEmpty())

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

> + public BlockDeviceMapping volumeId(String volumeId){ > + this.volumeId = volumeId; > + return this; > + } > + > + /** > + * @param deleteOnTermination True if this volume should be deleted > when the instance is terminated > + */ > + public Block

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + /* > + * Check request > + */ > + assertAuthentication(server); > + assertRequest(server.takeRequest(), "DELETE", > "/v2.0/floatingips/12345"); > + > + /* > + * Check response > + */ > + assertTrue(result); > + }

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + */ > + assertAuthentication(server); > + assertRequest(server.takeRequest(), "PUT", > "/v2.0/floatingips/12345", "/floatingip_update_dissociate_request.json"); > + > + /* > + * Check response > + */ > + assertNotNull(floatingIP); > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + */ > + assertNotNull(floatingIP); > + assertEquals(floatingIP.getId(), > "2f245a7b-796b-4f26-9cf9-9e82d248fda7"); > + assertEquals(floatingIP.getPortId(), > "ce705c24-c1ef-408a-bda3-7bbd946164ab"); > + assertEquals(floatingIP.getFloatingIpAddress(), "1

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + server.shutdown(); > + } > + } > + > + public void testUpdateFloatingIPDissociate() throws IOException, > InterruptedException, URISyntaxException { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(st

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + assertRequest(server.takeRequest(), "GET", "/v2.0/floatingips"); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/floatingips?marker=71c1e68c-171a-4aa2-aca5-50ea153a3718"); > + > + /* > + * Check response > + */ > + assertNotNull(floatin

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + server.shutdown(); > + } > + } > + > + public void testListPagedFloatingIP() throws IOException, > InterruptedException, URISyntaxException { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(stringFro

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + assertAuthentication(server); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/floatingips?limit=2&marker=abcdefg"); > + > + /* > + * Check response > + */ > + assertNotNull(floatingIPs); > + assertEquals(floatingIPs.size(), 2);

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + */ > + assertNotNull(floatingIP); > + assertEquals(floatingIP.getRouterId(), > "d23abc8d-2991-4a55-ba98-2aaea84cc72f"); > + assertEquals(floatingIP.getTenantId(), > "4969c491a3c74ee4af974e6d800c62de"); > + assertEquals(floatingIP.getFloatingNetworkId()

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> +assertNotNull(floatingIPGet); > +assertEquals(floatingIPGet, floatingIPList); > + } finally { try { > + assertTrue(floatingIPApi.delete(floatingIPGet.getId())); > +} finally { try { > + assertTrue(subnetApi.delete(ipv4Subnet

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + > floatingIPApi.create(FloatingIP.createOptions(network.getId()).build()); > + > + /* List and Get test */ > +Set floatingIPs = > floatingIPApi.list().concat().toSet(); > +FloatingIP floatingIPList = floatingIPs.iterator().next(); > +floa

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + > + FloatingIP floatingIPGet = null; > + String ipv4SubnetId = null; > + Network network = null; > + > + try { > +network = networkApi.create( > + > Network.createOptions("jclouds-network-test").external(true).networkType(NetworkType

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> +network = networkApi.create( > + > Network.createOptions("jclouds-network-test").external(true).networkType(NetworkType.LOCAL).build()); > +assertNotNull(network); > + > +ipv4SubnetId = > subnetApi.create(Subnet.createOptions(network.getId()

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Override > + protected Function> > markerToNextForArg0(Optional arg0) { > + String region = arg0.isPresent() ? arg0.get().toString() : null; > + final FloatingIPApi floatingIPApi = api.getFloatingIPApi(region).get(); > + return new Function>() { > + > + @SuppressWar

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Nullable > + FloatingIP get(@PathParam("id") String id); > + > + /** > +* This operation creates a floating IP. > +* > +* @param floatingIP Options for creating a floatingip > +* @return the newly created floatingip > +*/ > + @Named("floatingip:create") > + @POST

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + /** > +* This operation returns the details for a specific floating IP. > +* > +* @param id the id of the floatingIP to return > +* @return FloatingIPs collection or empty if not found > +*/ > + @Named("floatingip:get") > + @GET > + @Path("/{id}") > + @SelectJson("

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @ResponseParser(ParseFloatingIPs.class) > + @Fallback(EmptyPagedIterableOnNotFoundOr404.class) > + PagedIterable list(); > + > + /** > +* Allows configuring certain PaginationOptions. > +* @return the list of all floatingIP references configured for the > tenant. > +*/ > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + /** > +* The operation returns a list of floating IPs to which the tenant has > access. Default policy settings return only > +* those floating IPs that are owned by the tenant who submits the > request, unless the request is submitted by an > +* user with administrative rights.

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Path("/{id}") > + @SelectJson("floatingip") > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + FloatingIP get(@PathParam("id") String id); > + > + /** > +* This operation creates a floating IP. > +* > +* @param floatingIP Options for creating a floatingip > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> +/** > + * Provides access to Floating IP operations for the OpenStack Networking > (Neutron) v2 API. > + * > + * A floating IP is an IP address on an external network, which is > associated with a specific port, and optionally a > + * specific IP address, on a private OpenStack Networking net

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + public static class CreateOptions extends FloatingIP { > + /** > + * Copy constructor > + */ > + private CreateOptions(FloatingIP floatingIP) { > + super(floatingIP); > + } > + } > + public static class UpdateOptions extends FloatingIP { > + /** > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + */ > +package org.jclouds.openstack.neutron.v2.domain; > + > +import com.google.common.collect.ImmutableSet; > +import org.jclouds.openstack.v2_0.domain.Link; > +import org.jclouds.openstack.v2_0.domain.PaginatedCollection; > + > +import java.beans.ConstructorProperties; > + > +/** > + * A coll

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + } > + > + public static class UpdateBuilder extends Builder { > + /** > + * Supply required properties for updating a Builder > + */ > + private UpdateBuilder() { > + } > + > + /** > + * Provide the floating ip address for this Floating IP. > + *

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + public static CreateBuilder createOptions(String floatingNetworkId) { > + return new CreateBuilder(floatingNetworkId); > + } > + > + /** > +* @return the Builder for updating a floating IP > +*/ > + public static UpdateBuilder updateOptions() { > + return new UpdateBui

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + } > + > + private abstract static class Builder { > + protected FloatingIP floatingIP; > + > + /** > + * No-parameters constructor used when updating. > + * */ > + private Builder() { > + floatingIP = new FloatingIP(); > + } > + > + protected abs

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + > + protected abstract ParameterizedBuilderType self(); > + > + /** > + * Provide the tenantId for this Floating IP. Admin-only. > + * > + * @return the Builder. > + * @see FloatingIP#getTenantId() > + */ > + public ParameterizedBuilderType tenantId(

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> +Objects.equal(this.tenantId, that.tenantId) && > +Objects.equal(this.floatingNetworkId, that.floatingNetworkId) && > +Objects.equal(this.fixedIpAddress, that.fixedIpAddress) && > +Objects.equal(this.floatingIpAddress, that.floatingIpAddress) && > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + this.id = id; > + this.routerId = routerId; > + this.tenantId = tenantId; > + this.floatingNetworkId = floatingNetworkId; > + this.fixedIpAddress = fixedIpAddress; > + this.floatingIpAddress = floatingIpAddress; > + this.portId = portId; > + } > + > + /**

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + "floating_ip_address", "port_id"}) > + private FloatingIP(String id, String routerId, String tenantId, String > floatingNetworkId, String fixedIpAddress, > + String floatingIpAddress, String portId) { > + this.id = id; > + this.routerId = routerId; > + this.ten

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Named("tenant_id") > + private String tenantId; > + // Only mandatory attribute when creating > + @Named("floating_network_id") > + private String floatingNetworkId; > + @Named("fixed_ip_address") > + private String fixedIpAddress; > + @Named("floating_ip_address") > + privat

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds » jclouds #1563](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1563/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53668729

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

[jclouds-labs-openstack-pull-requests #391](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/391/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/135#issuecomment-53668646

Jenkins build is back to normal : jclouds » jclouds-labs-openstack #1637

See

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

[jclouds » jclouds-labs-openstack #1637](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1637/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

Hmm lost a commit in here somewhere --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/135#issuecomment-53667378

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

[jclouds-labs-openstack-pull-requests #390](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/390/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/13

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1636

See -- GitHub pull request #135 to jclouds/jclouds-labs-openstack Building remotely on s-5937e7c9 in workspace

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

[jclouds » jclouds-labs-openstack #1636](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1636/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests #1123](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1123/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53665626

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

> @@ -150,7 +154,53 @@ public boolean apply(VolumeAttachmentApi > volumeAttachmentApi) { > if (server_id != null) > api.getServerApiForZone(zone).delete(server_id); > } > + } > + } > + > + @Test(dependsOnMethods = "testCreateVolume") > + public voi

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -149,7 +149,8 @@ protected String createOrImportKeyPair(String region, > String group, TemplateOpti >RegionAndName regionAndGroup = new RegionAndName(region, group); >KeyPair keyPair; >// make sure that we don't request multiple keys simultaneously > - synchronize

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -149,7 +149,8 @@ protected String createOrImportKeyPair(String region, > String group, TemplateOpti >RegionAndName regionAndGroup = new RegionAndName(region, group); >KeyPair keyPair; >// make sure that we don't request multiple keys simultaneously > - synchronize

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -149,7 +149,8 @@ protected String createOrImportKeyPair(String region, > String group, TemplateOpti >RegionAndName regionAndGroup = new RegionAndName(region, group); >KeyPair keyPair; >// make sure that we don't request multiple keys simultaneously > - synchronize

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @SuppressWarnings("unused") > GoGridTemplateOptions eTo = GoGridTemplateOptions.class.cast(to); > + */ If the previous code already does nothing, I would simply be tempted to update this PR to simply remove https://github.com/andrewgaul/jclouds/blob/findbugs/provide

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

This pull request has two commented out sections that I do not know how to address and appreciate suggestions. If we cannot find a solution I will remove the changes and disable those detectors as well. In terms of `parseInt` vs. `valueOf`, there former is always at least as efficient when the

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @SuppressWarnings("unused") > GoGridTemplateOptions eTo = GoGridTemplateOptions.class.cast(to); > + */ Any suggestions on how to address this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498/files#r16815707

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -74,7 +74,7 @@ public D getRData() { > public boolean equals(Object obj) { >if (this == obj) > return true; > - if (obj == null || !obj.getClass().equals(CreateRecord.class)) > + if (obj == null || !(obj instanceof CreateRecord)) It's not the same, but I believ

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -149,7 +149,8 @@ protected String createOrImportKeyPair(String region, > String group, TemplateOpti >RegionAndName regionAndGroup = new RegionAndName(region, group); >KeyPair keyPair; >// make sure that we don't request multiple keys simultaneously > - synchronize

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> return false; > - return Objects.equal(this.toString(), that.toString()); > + if (!(obj instanceof Node)) { > + return false; > + } > + Node that = (Node) obj; > + return Objects.equal(this.id, that.id) Correct. Note that some tests actually fail when

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests-java-6 #34](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/34/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53661934

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Named("tenant_id") > + private String tenantId; > + // Only mandatory attribute when creating > + @Named("floating_network_id") > + private String floatingNetworkId; > + @Named("fixed_ip_address") > + private String fixedIpAddress; > + @Named("floating_ip_address") > + privat

Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

[jclouds » jclouds-labs-openstack #1635](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1635/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> @@ -85,4 +85,14 @@ > @Delegate > Optional getRouterExtensionApi(@EndpointParam(parser > = RegionToEndpoint.class) String region); Also considering this is beta, I will remove getRouterExtension completely without deprecating first. --- Reply to this email directly or view it on GitHub

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> @@ -85,4 +85,14 @@ > @Delegate > Optional getRouterExtensionApi(@EndpointParam(parser > = RegionToEndpoint.class) String region); I noticed that. I was thinking a separate PR but I could add it here. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests #1117](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1117/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53658433

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(stringFromResource("/access.json"; > + server.enqueue(addCommonHeaders( > +new MockResponse().setResponseCode(404))); > + > + try { > + Neu

Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

[jclouds-labs-openstack-pull-requests #389](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/389/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/137#issuecomment-53658250

Re: [jclouds-labs-openstack] Ignore jEnv files (#136)

+1, looks good to me too. Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/136#issuecomment-53658181

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

Thanks, @andrewgaul! One thing I noticed was that there are a couple of cases (I commented on two but didn't check further) where we are replacing `X.valueOf` with `X.parseX` even though the required value is actually the wrapper object (as returned by `valueOf`), not the primitive as returned b

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @SuppressWarnings("unused") > GoGridTemplateOptions eTo = GoGridTemplateOptions.class.cast(to); > + */ Rather than commenting out, remove from the PR or discuss and remove the code to? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -74,7 +74,7 @@ public D getRData() { > public boolean equals(Object obj) { >if (this == obj) > return true; > - if (obj == null || !obj.getClass().equals(CreateRecord.class)) > + if (obj == null || !(obj instanceof CreateRecord)) This is not quite the same, tho

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -64,7 +64,7 @@ public BaseVirtualSystemHandler(Provider > builderProvider, OperatingSystemSect > @Inject(optional = true) > protected void setExtensionHandlers( > @Named("VirtualSystem") Map SectionHandler>> extensionHandlers) { > - extensionHandlers = ImmutableMap.

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -121,7 +121,7 @@ public String toString() { > try { >return > Optional.fromNullable(client.getBucketLocation(bucket)); > } catch (ContainerNotFoundException e) { > - return null; > + return Optional.absent()

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -149,7 +149,8 @@ protected String createOrImportKeyPair(String region, > String group, TemplateOpti >RegionAndName regionAndGroup = new RegionAndName(region, group); >KeyPair keyPair; >// make sure that we don't request multiple keys simultaneously > - synchronize

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -62,12 +62,12 @@ public ServerInfo apply(Map from) { >if (from.containsKey("status")) > builder.status(ServerStatus.fromValue(from.get("status"))); >if (from.containsKey("smp") && !"auto".equals(from.get("smp"))) > - builder.smp(Integer.valueOf(from.get("smp")

Jenkins build became unstable: jclouds » jclouds-labs-google #1296

See

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> @@ -72,7 +72,7 @@ public DriveInfo apply(Map from) { >if (from.containsKey("use")) > builder.use(Splitter.on(' ').split(from.get("use"))); >if (from.containsKey("bits")) > - builder.bits(Integer.valueOf(from.get("bits"))); > + builder.bits(Integer.parseIn

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

> return false; > - return Objects.equal(this.toString(), that.toString()); > + if (!(obj instanceof Node)) { > + return false; > + } > + Node that = (Node) obj; > + return Objects.equal(this.id, that.id) I'm guessing the elements listed are also those in

[jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

The work necessary to fix [`PaginationOptions`](https://issues.apache.org/jira/browse/JCLOUDS-686) in the main jclouds repo requires this downstream change to happen *prior* so the build doesn't break. :+1: You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jc

[jira] [Commented] (JCLOUDS-686) Remove OpenStack PaginationOptions.changesSince()

[ https://issues.apache.org/jira/browse/JCLOUDS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113083#comment-14113083 ] Jeremy Daggett commented on JCLOUDS-686: The Glance API should support the change

Re: [jclouds] jclouds Development Tools (#459)

@everett-toews Are we waiting for anything specifically here..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/459#issuecomment-53655963

Re: [jclouds] Move jclouds-chef to the main jclouds repo (#458)

@nacx Do you want to reopen this one now..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/458#issuecomment-53656004

Re: [jclouds] jclouds Development Tools (#459)

[jclouds-pull-requests #1122](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1122/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/459#issuecomment-53652443

Re: [jclouds] jclouds Development Tools (#459)

[jclouds » jclouds #1561](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1561/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/459#issuecomme

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> +import com.google.common.base.Optional; > +import org.jclouds.collect.IterableWithMarker; > +import org.jclouds.collect.internal.Arg0ToPagedIterable; > +import org.jclouds.openstack.neutron.v2.NeutronApi; > +import org.jclouds.openstack.neutron.v2.domain.FloatingIP; > +import org.jclouds.opensta

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds-labs-openstack-pull-requests #388](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/388/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53648145

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds » jclouds-labs-openstack #1632](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1632/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

I hopefully didn't miss any fixes. Seems ready to rebase and merge though, unless there are more comments? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53647166

Re: [jclouds] jclouds Development Tools (#459)

[jclouds-pull-requests-java-6 #33](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/33/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/459#issuecomment-53646051

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds » jclouds #1560](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1560/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomme

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds-pull-requests #1121](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1121/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomment-53643686

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds-pull-requests #1120](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1120/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomment-53639194

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds » jclouds #1559](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1559/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomme

Jenkins build is back to stable : jclouds » jclouds #1559

See

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds-labs-openstack-pull-requests #387](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/387/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53635931

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds » jclouds-labs-openstack #1629](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1629/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds-pull-requests-java-6 #32](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/32/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomment-53635096

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds-pull-requests-java-6 #31](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/31/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomment-53630881

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds-pull-requests #1119](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1119/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/498#issuecomment-53617948

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Jenkins build became unstable: jclouds » jclouds #1558

See

Re: [jclouds] Address FindBugs issues and disable some detectors (#498)

[jclouds » jclouds #1558](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1558/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

Re: [jclouds-labs-openstack] JCLOUDS-568 Allow updating content-type in metadata (#130)

@jdaggett are we good to close this yet? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/130#issuecomment-53614447

  1   2   >