Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2014-09-05 Thread BuildHive
[jclouds » jclouds #1605](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1605/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/511#issuecomment-54703854

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2014-09-05 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124333#comment-14124333 ] Andrew Gaul commented on JCLOUDS-651: - Initial patch out for review: https://github.

[jira] [Assigned] (JCLOUDS-651) server-side copy in portable abstraction

2014-09-05 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul reassigned JCLOUDS-651: --- Assignee: Andrew Gaul > server-side copy in portable abstraction > -

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

2014-09-05 Thread Andrew Gaul
> +import org.jclouds.googlecloudstorage.options.ListObjectOptions; > +import org.jclouds.http.HttpResponseException; > +import org.jclouds.http.internal.PayloadEnclosingImpl; > + > +import com.google.common.base.Charsets; > +import com.google.common.base.Function; > +import com.google.common.base.

Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1152](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1152/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/511#issuecomment-54702667

Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #63](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/63/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/511#issuecomment-54701370

Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2014-09-05 Thread Andrew Gaul
@jdaggett @shrinandj @hsbhathiya @rcoedo I appreciate feedback on what other providers can support, especially for `CopyOptions`. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/511#issuecomment-54701352

[jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2014-09-05 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds copy-blob Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/511 -- Commit Summary -- * JCLOUDS-651: Add copyBlob to portable abstraction * JCLOUDS-65

Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

2014-09-05 Thread Andrew Phillips
Just a minor naming comment. +1, looks good to me too. Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/137#issuecomment-54701094

Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

2014-09-05 Thread Andrew Phillips
> @@ -54,6 +54,25 @@ > /** > * Return only those images having a matching name attribute > */ > + public ListImageOptions changesSince(Date ifModifiedSince) { See related comment on the other PR...a variable named `ifModifiedSince` sounds more like a boolean to me? The value he so

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

2014-09-05 Thread Andrew Phillips
> + > + /* > + * Check request > + */ > + assertEquals(server.getRequestCount(), 3); > + assertAuthentication(server); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules"); > + assertRequest(server.takeRequest(), "

Jenkins build is back to stable : jclouds » jclouds #1602

2014-09-05 Thread BuildHive
See

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Gaul
Closed #510. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#event-162043804

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Gaul
Pushed to master as e1a5c521c58a611272a18e488e870215469d82a6 and 1.8.x as 5330699fe771deccaa115975e52e1795d1a32d0d. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509#issuecomment-54698575

Jenkins build became unstable: jclouds » jclouds #1601

2014-09-05 Thread BuildHive
See

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1151](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1151/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509#issuecomment-54697874

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1150](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1150/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#issuecomment-54697763

Jenkins build is back to normal : jclouds » jclouds-labs #1488

2014-09-05 Thread BuildHive
See

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Phillips
> jclouds-pull-requests #1148 UNSTABLE Checkstyle barf, but that's related to Nova, not this PR. +1, looks good to me. Thanks, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509#issuecomment-54697279

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Phillips
> jclouds » jclouds #1600 SUCCESS Bingo! Thanks, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#issuecomment-54697245

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Phillips
> @@ -531,8 +533,8 @@ public void testInvalidContainerName() { > } > > public void testOverwriteBlobMetadata() throws Exception { > - if (isMacOSX()) { > - throw new SkipException("blob metadata not supported on Mac OS X"); > + if > (!getFileStore(Paths.get(TestUtils.TA

Re: [jclouds-labs] Address FindBugs warnings (#71)

2014-09-05 Thread Andrew Phillips
> public static String dateFormat(Date date) { > - return date != null ? DATE_FORMAT.format(date) : ""; > + return date != null ? new SimpleDateFormat("dd/MM/ HH:mm:ss > zzz").format(date) : ""; Fine to leave as-is - was just a curiosity question. We're not mutating it, but it

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1148](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1148/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509#issuecomment-54696746

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread BuildHive
[jclouds » jclouds #1600](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1600/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#issuecomme

Jenkins build is back to stable : jclouds » jclouds #1600

2014-09-05 Thread BuildHive
See

Re: [jclouds-labs] Address FindBugs warnings (#71)

2014-09-05 Thread Andrew Gaul
I believe the string-based equals was just a shortcut. Not a terrible one, although less efficient than the traditional approach. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/71#issuecomment-54695541

Re: [jclouds-labs] Address FindBugs warnings (#71)

2014-09-05 Thread Andrew Gaul
> public static String dateFormat(Date date) { > - return date != null ? DATE_FORMAT.format(date) : ""; > + return date != null ? new SimpleDateFormat("dd/MM/ HH:mm:ss > zzz").format(date) : ""; `DateFormat` is a mutable class. Unsure whether reducing this to private access wo

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #62](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/62/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509#issuecomment-54695429

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #61](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/61/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#issuecomment-54695203

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Gaul
> validateXml(from); > - return doParse(new InputSource(new StringReader(from))); > + return doParse(new InputSource(new ByteArrayInputStream(array))); Done. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509/files#r1720430

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Gaul
> @@ -91,9 +92,10 @@ public T apply(HttpResponse from) { > private T convertStreamToStringAndParse(HttpResponse response) { >String from = null; >try { > - from = new String(closeClientButKeepContentStream(response)); > + byte[] array = closeClientButKeepContentS

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Phillips
> @@ -545,7 +541,9 @@ public void testOverwriteBlobMetadata() throws Exception { >storageStrategy.putBlob(CONTAINER_NAME, blob); > >blob = storageStrategy.getBlob(CONTAINER_NAME, blobKey); > - assertEquals(blob.getMetadata().getUserMetadata().get("key1"), > "value1"); > +

Re: [jclouds-labs] Address FindBugs warnings (#71)

2014-09-05 Thread Andrew Phillips
+1 - thanks for that, @andrewgaul! Curious about all those string-based equals implementations we had...was that just a shortcut, or were they intentional in some way? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/71#issuecomment-54694987

Re: [jclouds-labs] Address FindBugs warnings (#71)

2014-09-05 Thread Andrew Phillips
> public static String dateFormat(Date date) { > - return date != null ? DATE_FORMAT.format(date) : ""; > + return date != null ? new SimpleDateFormat("dd/MM/ HH:mm:ss > zzz").format(date) : ""; Curious about this one? I guess it's the lack of synchronization we're fixing here.

Re: [jclouds] JCLOUDS-706: Upgrade Azure API to 2012-02-12 (#508)

2014-09-05 Thread Andrew Gaul
Pushed to master as 975c1325bcf980ef4da1de00d1d5843a1d788399. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/508#issuecomment-54694817

Re: [jclouds] JCLOUDS-706: Upgrade Azure API to 2012-02-12 (#508)

2014-09-05 Thread Andrew Gaul
Closed #508. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/508#event-162027454

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-05 Thread Andrew Phillips
@adriancole Ping? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-54694735

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Gaul
> @@ -545,7 +541,9 @@ public void testOverwriteBlobMetadata() throws Exception { >storageStrategy.putBlob(CONTAINER_NAME, blob); > >blob = storageStrategy.getBlob(CONTAINER_NAME, blobKey); > - assertEquals(blob.getMetadata().getUserMetadata().get("key1"), > "value1"); > +

[jira] [Resolved] (JCLOUDS-706) Upgrade Azure API version to 2012-02-12

2014-09-05 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul resolved JCLOUDS-706. - Resolution: Fixed Fix Version/s: 2.0.0 > Upgrade Azure API version to 2012-02-12 > ---

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Phillips
> @@ -545,7 +541,9 @@ public void testOverwriteBlobMetadata() throws Exception { >storageStrategy.putBlob(CONTAINER_NAME, blob); > >blob = storageStrategy.getBlob(CONTAINER_NAME, blobKey); > - assertEquals(blob.getMetadata().getUserMetadata().get("key1"), > "value1"); > +

[jira] [Commented] (JCLOUDS-706) Upgrade Azure API version to 2012-02-12

2014-09-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123823#comment-14123823 ] ASF subversion and git services commented on JCLOUDS-706: - Commit

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Phillips
> seen on CloudBees. Specifically, BuildHive. DEV@cloud looks fine. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#issuecomment-54694170

Re: [jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #60](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/60/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/510#issuecomment-54694077

[jclouds] Skip test when filesystem does not have xattr (#510)

2014-09-05 Thread Andrew Gaul
Addresses regression from a104944 seen on CloudBees. You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds filesystem-xattr-test Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/510 -- Commit Summary -- *

Re: [jclouds] JCLOUDS-706: Upgrade Azure API to 2012-02-12 (#508)

2014-09-05 Thread Andrew Gaul
Addressing filesystem test failure in #510. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/508#issuecomment-54694011

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Phillips
> validateXml(from); > - return doParse(new InputSource(new StringReader(from))); > + return doParse(new InputSource(new ByteArrayInputStream(array))); Add a comment to the code to explain why we're not using `from` here...roughly the same comment as in the PR descriptio

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Phillips
> @@ -91,9 +92,10 @@ public T apply(HttpResponse from) { > private T convertStreamToStringAndParse(HttpResponse response) { >String from = null; >try { > - from = new String(closeClientButKeepContentStream(response)); > + byte[] array = closeClientButKeepContentS

Re: [jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #59](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/59/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/509#issuecomment-54693448

[jclouds] Improve XML compatibility with trace-level logging (#509)

2014-09-05 Thread Andrew Gaul
Some providers, notably Azure, include a byte-order mark in their XML responses. ParseSax.apply buffers these responses in a String when users enable trace-level logging to include the response in any thrown exceptions. InputSource(InputStream) skips these byte-order marks while InputSource(Reade

Re: [jclouds] JCLOUDS-686: Remove changesSince() query from base PaginationOptions (#499)

2014-09-05 Thread Andrew Phillips
> ListOptions options = new ListOptions(); > - return options.limit(maxKeys); > + return options.limit(limit); > + } > + > + /** > + * > + * @see PaginationOptions#limit(int) > + * @deprecated Please use {@link #limit(int)} as this builder metho

Re: [jclouds] JCLOUDS-686: Remove changesSince() query from base PaginationOptions (#499)

2014-09-05 Thread Andrew Phillips
> */ > - @Override > - public ListOptions marker(String marker) { > - super.marker(marker); > + public ListOptions changesSince(Date ifModifiedSince) { Just curious how to interpret a **date** parameter called "ifModifiedSince"? Is this the _start_ date for the search condition, o

Re: [jclouds] JCLOUDS-686: Remove changesSince() query from base PaginationOptions (#499)

2014-09-05 Thread Andrew Phillips
> */ >public static PaginationOptions limit(int limit) { > PaginationOptions options = new PaginationOptions(); > return options.limit(limit); >} > - > - /** > - * @see PaginationOptions#changesSince(Date) > - */ > - public static Pa

Re: [jclouds] JCLOUDS-706: Upgrade Azure API to 2012-02-12 (#508)

2014-09-05 Thread Andrew Phillips
> I will improve the SkipException condition to address this. Thanks! Sorry, blanked for a second there that integration tests _are_ run against the actual target, indeed ;-) +1, looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/50

Re: [jclouds] JCLOUDS-706: Upgrade Azure API to 2012-02-12 (#508)

2014-09-05 Thread Andrew Gaul
As stated above, integration tests successfully passed. As for the failure, Cloudbees does not seem to run on a filesystem with xattr support. I will improve the `SkipException` condition to address this. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/

Re: [jclouds] JCLOUDS-686: Remove changesSince() query from base PaginationOptions (#499)

2014-09-05 Thread Andrew Phillips
> @@ -44,7 +42,12 @@ public PaginationOptions queryParameters(Multimap String> queryParams) { > > /** > * Only return objects changed since this time. > +* > +* @deprecated The {@code changes-since} query does not apply to all > OpenStack APIs. Please refer to the OpenStack > +

Re: [jclouds] JCLOUDS-706: Upgrade Azure API to 2012-02-12 (#508)

2014-09-05 Thread Andrew Phillips
> jclouds » jclouds #1596 UNSTABLE This looks like a [real failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds.api$filesystem/1596/testReport/org.jclouds.filesystem.strategy.internal/FilesystemStorageStrategyImplTest/testOverwriteBlobMetadata/), but unrelated to t

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-09-05 Thread Andrew Phillips
> What are you thinking here? Sorry, I wasn't very clear. Right now the code says: ``` .identityName("${tenantName}:${userName} or ${userName}, if your keystone supports a default tenant") .credentialName("${password}") ``` If I understand this PR correctly, we now have one more option f

Re: [jclouds-examples] The start of examples for OpenStack (#62)

2014-09-05 Thread Andrew Phillips
Just minor comments. +1, looks good to me, too. Thanks, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/62#issuecomment-54691656

Re: [jclouds-examples] The start of examples for OpenStack (#62)

2014-09-05 Thread Andrew Phillips
> + if (tenantAdminApiExtension.isPresent()) { > + System.out.format("TenantAdminApi is present%n"); > + > + TenantAdminApi tenantAdminApi = tenantAdminApiExtension.get(); > + CreateTenantOptions tenantOptions = CreateTenantOptions.Builder > + .descrip

Re: [jclouds-examples] The start of examples for OpenStack (#62)

2014-09-05 Thread Andrew Phillips
> +* The fourth argument (args[3]) must be your password > +* > +* For this example your endpoint must be the *admin endpoint* of your > Identity service > +* (e.g. "http://111.222.333.444:35357/v2.0/";) > +*/ > + public static void main(String[] args) throws IOException { >

Re: [jclouds-examples] The start of examples for OpenStack (#62)

2014-09-05 Thread Andrew Phillips
> @@ -0,0 +1,64 @@ > +# OpenStack Examples > +Example code that uses jclouds to perform common tasks on an OpenStack > Cloud. The class names are self explanatory and the code is well commented > for you to follow along. [minor] "[self-explanatory](http://www.merriam-webster.com/dictionary/self

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Andrew Phillips
Thanks for the whitespace cleanup, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54691302

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Andrew Phillips
> @@ -24,7 +24,7 @@ > > import org.jclouds.Fallbacks.EmptyFluentIterableOnNotFoundOr404; > import org.jclouds.openstack.keystone.v2_0.filters.AuthenticateRequest; > -import org.jclouds.openstack.nova.v2_0.domain.regionscoped.AvailabilityZone; > +import org.jclouds.openstack.nova.v2_0.domain.zon

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Andrew Phillips
> @@ -23,7 +23,7 @@ > import org.jclouds.http.HttpRequest; > import org.jclouds.http.HttpResponse; > import org.jclouds.openstack.nova.v2_0.NovaApi; > -import org.jclouds.openstack.nova.v2_0.domain.regionscoped.AvailabilityZone; > +import org.jclouds.openstack.nova.v2_0.domain.zonescoped.Availab

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Andrew Phillips
> > -import org.jclouds.openstack.nova.v2_0.domain.regionscoped.AvailabilityZone; > +import org.jclouds.openstack.nova.v2_0.domain.zonescoped.AvailabilityZone; See comment above --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503/files#r17202631

Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)

2014-09-05 Thread Andrew Phillips
PS: I've also configured the Violations settings for the PR builder to use the new Zero Tolerance policy ;-) Was: ![image](https://cloud.githubusercontent.com/assets/223702/4172740/e9d5132e-354d-11e4-87e3-2e115ca66dfd.png) Now: ![image](https://cloud.githubusercontent.com/assets/223702/4172781

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Andrew Phillips
New [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1147/org.apache.jclouds.api$openstack-nova/violations/) here. Just out of curiosity: did you manage to have a look at the cause of the PR builder failure, @jdaggett? --- Reply to this email directly or view i

Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)

2014-09-05 Thread Andrew Phillips
I'm OK with this, too. It gives us a little less leeway when using DEV@cloud, but if we want to be more lenient there we can always create a profile that does _not_ fail on violations and use that for our CI builds. --- Reply to this email directly or view it on GitHub: https://github.com/jcloud

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-05 Thread Andrew Phillips
> This still needs *Options naming changes, if any. Would you rather wait for that discussion, or commit this and then make any *Options changes (which will affect not only Neutron, I think?) in a separate PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

2014-09-05 Thread Andrew Phillips
> +import org.jclouds.googlecloudstorage.options.ListObjectOptions; > +import org.jclouds.http.HttpResponseException; > +import org.jclouds.http.internal.PayloadEnclosingImpl; > + > +import com.google.common.base.Charsets; > +import com.google.common.base.Function; > +import com.google.common.base.

[jira] [Created] (JCLOUDS-711) Improve 409 Exception handling in SwiftErrorHandler

2014-09-05 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-711: -- Summary: Improve 409 Exception handling in SwiftErrorHandler Key: JCLOUDS-711 URL: https://issues.apache.org/jira/browse/JCLOUDS-711 Project: jclouds Iss

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

2014-09-05 Thread Andrew Gaul
> + blob.getMetadata().setLastModified(gcsObject.getUpdated()); > + blob.getMetadata().setETag(gcsObject.getEtag()); > + blob.getMetadata().setPublicUri(gcsObject.getMediaLink()); > + blob.getMetadata().setUserMetadata(gcsObject.getAllMetadata()); > + blob.getMetadata().set

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

2014-09-05 Thread Andrew Gaul
> + } > + > + @Override > + public BlobMetadata blobMetadata(String container, String name) { > + return > objectToBlobMetadata.apply(api.getObjectApi().getObject(container, name)); > + } > + > + @Override > + public Blob getBlob(String container, String name, > org.jclouds.blobs

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-05 Thread Zack Shoylev
Checkstyle violations seem to have been fixed. This still needs *Options naming changes, if any. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54661390

Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)

2014-09-05 Thread Andrew Gaul
Sorry, rebasing this addresses my issue. I had a newer Checkstyle configuration but an older tree. I understand what this commit does now; `mvn compile` runs checkstyle and fails on violation. This seems like an improvement. :+1+. --- Reply to this email directly or view it on GitHub: https

Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)

2014-09-05 Thread Andrew Gaul
@jdaggett I still do not understand this commit. When I run `mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain` I see many violations which did not exist previously. This commit appears to regress on our local Checkstyle configuration. --- Reply

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #409](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/409/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54655650

[jira] [Created] (JCLOUDS-710) OpenStack Keystone should use Guava MediaType

2014-09-05 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-710: -- Summary: OpenStack Keystone should use Guava MediaType Key: JCLOUDS-710 URL: https://issues.apache.org/jira/browse/JCLOUDS-710 Project: jclouds Issue Typ

[jira] [Commented] (JCLOUDS-709) openstack-neutron Checkstyle violations

2014-09-05 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123170#comment-14123170 ] Zack Shoylev commented on JCLOUDS-709: -- https://github.com/jclouds/jclouds-labs-open

Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)

2014-09-05 Thread Jeremy Daggett
The submission of [JIRA-709](https://issues.apache.org/jira/browse/JCLOUDS-709) provides the necessary motivation to merge this PR today. If I don't hear anything by 2pm today, its going into the build. :+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclou

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #408](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/408/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54650942

Jenkins build is still unstable: jclouds » jclouds #1598

2014-09-05 Thread BuildHive
See

[jira] [Created] (JCLOUDS-709) openstack-neutron Checkstyle violations

2014-09-05 Thread Andrew Gaul (JIRA)
Andrew Gaul created JCLOUDS-709: --- Summary: openstack-neutron Checkstyle violations Key: JCLOUDS-709 URL: https://issues.apache.org/jira/browse/JCLOUDS-709 Project: jclouds Issue Type: Bug

[jira] [Updated] (JCLOUDS-708) GCS does not renew its authorization token periodically

2014-09-05 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-708: Summary: GCS does not renew its authorization token periodically (was: GCS does not renew authoriz

[jira] [Updated] (JCLOUDS-708) GCS does not renew authorization token after an interval

2014-09-05 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-708: Description: While testing the latest GCS pull request[1] I found that starting my application the

[jira] [Created] (JCLOUDS-708) GCS does not renew authorization token after an interval

2014-09-05 Thread Andrew Gaul (JIRA)
Andrew Gaul created JCLOUDS-708: --- Summary: GCS does not renew authorization token after an interval Key: JCLOUDS-708 URL: https://issues.apache.org/jira/browse/JCLOUDS-708 Project: jclouds Issu

Jenkins build is still unstable: jclouds » jclouds #1597

2014-09-05 Thread BuildHive
See

[jira] [Resolved] (JCLOUDS-341) testPublicAccess fails against openstack-swift

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-341. Resolution: Not a Problem Fix Version/s: 1.8.1 > testPublicAccess fails against open

[jira] [Commented] (JCLOUDS-341) testPublicAccess fails against openstack-swift

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123081#comment-14123081 ] Jeremy Daggett commented on JCLOUDS-341: This specific test will not work against

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1147](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1147/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54644733

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread BuildHive
[jclouds » jclouds #1597](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1597/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

[jira] [Updated] (JCLOUDS-669) jclouds-cli support for openstack-swift

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-669: --- Summary: jclouds-cli support for openstack-swift (was: openstack-swift is not supported) >

[jira] [Resolved] (JCLOUDS-699) Properly deprecate zonescoped domain objects

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-699. Resolution: Fixed Fix Version/s: 1.8.1 > Properly deprecate zonescoped domain object

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Pushed to master 15d8166 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54638739

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Closed #503. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#event-161799439

[jira] [Commented] (JCLOUDS-699) Properly deprecate zonescoped domain objects

2014-09-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123024#comment-14123024 ] ASF subversion and git services commented on JCLOUDS-699: - Commit

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #58](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/58/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54635332

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Reopened #503. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#event-161785249

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Closed #503. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#event-161785237

[jira] [Updated] (JCLOUDS-683) Promote oauth API

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-683: --- Assignee: Chris Custine (was: Jeremy Daggett) > Promote oauth API > - > >

  1   2   >