Jenkins build is still unstable: jclouds » jclouds-labs #1528

See

Re: [jclouds-labs] JCloud ProfitBricks provider implementation (#72)

[jclouds » jclouds-labs #1528](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1528/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

I'll test this later this week. FTR, it is very easy to test. In [this comment](https://github.com/jclouds/jclouds/pull/312#issuecomment-38077166) I put some example steps. Basically what needs to be done is: 1. Create a new SSH key in your machine, protected with a password. We protect the pr

Re: [jclouds-labs] Add vSphere support (#61)

Thank you. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-56000547

Re: [jclouds-labs] JCloud ProfitBricks provider implementation (#72)

[jclouds-labs-pull-requests #252](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/252/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/72#issuecomment-56000553

Re: [jclouds-labs-google] Initial commit to add l7 loadbalancing features and tests (#38)

> @@ -78,6 +93,20 @@ protected void configure() { >.put(FirewallOptions.class, new FirewallOptionsTypeAdapter()) >.put(RouteOptions.class, new RouteOptionsTypeAdapter()) >.put(Rule.class, new RuleTypeAdapter()) > + .put(BackendServiceOpti

Re: [jclouds-labs] JCloud ProfitBricks provider implementation (#72)

[jclouds-labs-pull-requests #251](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/251/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/72#issuecomment-56000124

Re: [jclouds-labs] JCloud ProfitBricks provider implementation (#72)

[jclouds » jclouds-labs #1527](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1527/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/

Jenkins build became unstable: jclouds » jclouds-labs #1527

See

Re: [jclouds-labs] Add vSphere support (#61)

>@nacx @aledsage Can we progress with the merge? By the end of this week / early next one I'll review again the PR so we can move forward. Apologies for the delay @igreenfield, I've been on vacation and I haven't had much review time. --- Reply to this email directly or view it on GitHub: https

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

[jclouds » jclouds #1646](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1646/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomme

Jenkins build is back to normal : jclouds » jclouds #1645

See

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

[jclouds » jclouds #1644](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1644/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55982426

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

[jclouds-pull-requests #1181](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1181/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55981190

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

[jclouds-pull-requests-java-6 #92](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/92/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55978992

Re: [jclouds-karaf] Upgrade to Gson 2.3 (#54)

+1 - looks good to me. Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/54#issuecomment-55978555

Re: [jclouds-karaf] Upgrade to Gson 2.3 (#54)

Pushed to master 8515635 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/54#issuecomment-55977087

Re: [jclouds-karaf] Upgrade to Gson 2.3 (#54)

Closed #54. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/54#event-166936741

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

@demobox @nacx @zack-shoylev It would be great to get some documentation on the wiki describing how to test this functionality! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55977065

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

@demobox Yes, I got ahead of myself and committed it before the builder ran again. I commented above: Pushed to master 01dcca1 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#issuecomment-55976995

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

> fixed all of the Checkstyle warnings and I don't see any violations on master Thanks for verifying! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#issuecomment-55976820

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

> jdaggett closed this 2 hours ago Is this committed? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#issuecomment-55976749

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

> Is there a test case I could run? I hope @nacx can help...he's the "guru" here, I think ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-5597

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

I might be able to test it with pageant later this week. Is there a test case I could run? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55975665

[jira] [Commented] (JCLOUDS-719) Upgrade to Gson 2.3

[ https://issues.apache.org/jira/browse/JCLOUDS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138186#comment-14138186 ] ASF subversion and git services commented on JCLOUDS-719: - Commit

Re: [jclouds] Add assertj-core and assertj-guava dependencies to project pom (#522)

Closed #522. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/522#event-166930245

Re: [jclouds] Add assertj-core and assertj-guava dependencies to project pom (#522)

Pushed to master 0ac7dfd and 1.8.x 593fbac --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/522#issuecomment-55975487

Re: [jclouds-karaf] Upgrade to Gson 2.3 (#54)

[jclouds-karaf-pull-requests #87](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/87/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/54#issuecomment-55975431

Jenkins build is back to stable : jclouds » jclouds-karaf #1251

See

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

@nacx Is there any chance you can verify whether the agentproxy actually still works with this change? Do you know anyone who could test pageant? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55973850

Re: [jclouds-karaf] Upgrade to Gson 2.3 (#54)

[jclouds » jclouds-karaf #1251](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/1251/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

[jclouds-pull-requests #1180](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1180/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55973129

[jclouds-karaf] Upgrade to Gson 2.3 (#54)

This PR updates Gson to version 2.3 as per https://issues.apache.org/jira/browse/JCLOUDS-719 You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-karaf update/gson-2.3 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jcl

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

Closed #20. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#event-166900557

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

[jclouds-cli-pull-requests #27](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/27/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#issuecomment-55965489

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

@demobox Thanks for updating! +1 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55964809

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

[jclouds-pull-requests-java-6 #91](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/91/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-55964560

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

Reopened #20. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#event-166891246

Re: [jclouds-cli] JCLOUDS-720: Renames jclouds-cli artifact IDs (#20)

@demobox #19 fixed all of the Checkstyle warnings and I don't see any violations on master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/20#issuecomment-55964480

[jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

The default version 3.4.0 is only LGPL-licensed. You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds use-jna-40 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/525 -- Commit Summary -- * Using net.java.dev

[jira] [Assigned] (JCLOUDS-281) Missing Nova creating compute instance with Bootable Volume

[ https://issues.apache.org/jira/browse/JCLOUDS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-281: -- Assignee: Jeremy Daggett > Missing Nova creating compute instance with Bootable Volume

[jira] [Commented] (JCLOUDS-172) "Graduate" GCE to core

[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137901#comment-14137901 ] Everett Toews commented on JCLOUDS-172: --- Hi Alex, GCE seems like a stable and popu

Jenkins build became unstable: jclouds » jclouds-karaf #1250

See

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

Apologies if most of my comments have already been addressed. Two recurring ones: * expect tests vs. MWS tests * please remove external URLs Thanks, @hsbhathiya and @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/36#issueco

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + * limitations under the License. > + */ > +package org.jclouds.googlecloudstorage.parse; > + > +import java.net.URI; > + > +import javax.ws.rs.Consumes; > +import javax.ws.rs.core.MediaType; > + > +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.ObjectRole; > +import o

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + assertEquals(response.getEntity(), "allUsers"); > + assertEquals(response.getRole(), ObjectRole.READER); > + } > + > + @Test(groups = "live", dependsOnMethods = "testPatchDefaultObjectacl") > + public void testDeleteBucketacl() { > + api().deleteDefaultObjectAccessControls(

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + assertNotNull(response); > + assertEquals(response.getEntity(), "allUsers"); > + assertEquals(response.getRole(), ObjectRole.OWNER); > + } > + > + @Test(groups = "live", dependsOnMethods = "testUpdateDefaultObjectacl") > + public void testListDefaultObjectacl() { > + L

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + > + protected static final String BUCKET_NAME = "jcloudtestbucketdefaultoacl" > + UUID.randomUUID(); > + > + private DefaultObjectAccessControlsApi api() { > + return api.getDefaultObjectAccessControlsApi(); > + } > + > + private void createBucket(String BucketName) { > + Buc

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +public class BucketAccessControlsApiLiveTest extends > BaseGoogleCloudStorageApiLiveTest { > + > + protected static final String BUCKET_NAME = "jcloudstestbucketacl" + > UUID.randomUUID(); > + > + private BucketAccessControlsApi api() { > + return api.getBucketAccessControlsApi(); > +

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> @@ -41,6 +41,10 @@ public void handleError(HttpCommand command, HttpResponse > response) { >: new HttpResponseException(command, response); >message = message != null ? message : String.format("%s -> %s", > command.getCurrentRequest().getRequestLine(), >r

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> @@ -30,8 +30,8 @@ > private BindToJsonPayload jsonBinder; > > @Override > - public R bindToRequest(R request, Map Object> postParams) { > - BucketAccessControls postBucket = (BucketAccessControls) > postParams.get("BACLInsert"); > + public R bindToRequest(R request, Map Obje

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* > +* @param bucketName > +* Name of the bucket of which contains the object > +* @param objectName > +* Name of the object which acl is related > +* @param template > +* Supply an {@link ObjectAccessControlsTemplate} > +

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* group-emailAddress, allUsers, or allAuthenticatedUsers > +* @param template > +* Supply an {@link ObjectAccessControlsTemplate} > +* @param generation > +* If present, selects a specific revision of this object > +* > +* @return {@link

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* @param template > +* Supply an {@link ObjectAccessControlsTemplate} > +* @param generation > +* If present, selects a specific revision of this object > +* > +* @return {@link ObjectAccessControls } > +*/ > + > + @Named("ObjectAccessControls:up

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* Returns the acl entry for the specified entity on the specified object. > +* > +* @param bucketName > +* Name of the bucket which contains the object > +* @param objectName > +* Name of the bucket of that acl is related > +* @param entity > +

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* @param generation > +* If present, selects a specific revision of this object > +* > +* @return a {@link ListObjectAccessControls } > +* > +*/ > + > + @Named("ObjectAccessControls:list") > + @GET > + @Consumes(MediaType.APPLICATION_JSON) > + @Produces

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* Name of the bucket which contains the object > +* @param objectName > +* Name of the bucket of that acl is related > +* @param generation > +* If present, selects a specific revision of this object > +* @param entity > +* The

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* @param objectName > +* Name of the bucket of that acl is related > +* @param generation > +* If present, selects a specific revision of this object > +* > +* @return an {@link ObjectAccessControls } > +*/ > + > + @Named("ObjectAccessControls:in

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +* The entity holding the permission. Can be user-userId, > user-emailAddress, group-groupId, > +* group-emailAddress, allUsers, or allAuthenticatedUsers > +* @param generation > +* If present, selects a specific revision of this object > +* > +

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> @@ -112,9 +111,7 @@ BucketAccessControls > createBucketAccessControls(@PathParam("bucket") String buck > @Consumes(MediaType.APPLICATION_JSON) > @Path("/b/{bucket}/acl/{entity}") > @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > - @Fallback(NullOnNotFoundOr404.class) > - @Nullable > -

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + * Represents a Object Access Control Resource. > + * > + * @see "https://developers.google.com/storage/docs/json_api/v1/objectAccessControls"/> > + */ > +public class ObjectAccessControlsTemplate { > + > + protected String entity; > + protected ObjectRole role; > + > + public ObjectAcces

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> +package org.jclouds.googlecloudstorage.domain; > + > +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.ObjectRole; > + > +/** > + * Represents a Object Access Control Resource. > + * > + * @see "https://developers.google.com/storage/docs/json_api/v1/objectAccessControls

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + if (obj == null || getClass() != obj.getClass()) > + return false; > + ObjectAccessControls that = ObjectAccessControls.class.cast(obj); > + return equal(this.kind, that.kind) && equal(this.bucket, that.bucket) > && equal(this.object, that.object) > + && eq

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + public Builder toBuilder() { > + return new Builder().fromListObjectAccessControls(this); > + } > + > + public static final class Builder { > + > + private Kind kind; > + private ImmutableSet.Builder items = > ImmutableSet.builder(); > + > + public Builder kind(Kind k

Re: [jclouds-labs-google] JCLOUDS-458:Added ObjectAccessControls with expect tests (#36)

> + > +import static com.google.common.base.Objects.equal; > +import static com.google.common.base.Preconditions.checkNotNull; > + > +import java.net.URI; > + > +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.ObjectRole; > +import org.jclouds.googlecloudstorage.domain.int

Re: [jclouds-labs-google] Initial commit to add l7 loadbalancing features and tests (#38)

> + if (resourceViewOptions.getName() != null) { > +resourceView.addProperty("name", resourceViewOptions.getName()); > + } > + if (resourceViewOptions.getDescription() != null) { > +resourceView.addProperty("description", > resourceViewOptions.getDes

Re: [jclouds-labs-google] Initial commit to add l7 loadbalancing features and tests (#38)

> +.kind(Kind.RESOURCE_VIEW_LIST); > + if (listPageObject.has("nextPageToken")) { > + > builder.nextPageToken(listPageObject.get("nextPageToken").getAsString()); > + } > + if (listPageObject.has("resourceViews")) { > +for (JsonElement

Re: [jclouds-labs-google] Initial commit to add l7 loadbalancing features and tests (#38)

> @@ -78,6 +93,20 @@ protected void configure() { >.put(FirewallOptions.class, new FirewallOptionsTypeAdapter()) >.put(RouteOptions.class, new RouteOptionsTypeAdapter()) >.put(Rule.class, new RuleTypeAdapter()) > + .put(BackendServiceOpti

Re: [jclouds-labs-google] Initial commit to add l7 loadbalancing features and tests (#38)

> @@ -42,6 +42,10 @@ > public static final String STORAGE_READONLY_SCOPE = > "https://www.googleapis.com/auth/devstorage.read_only";; > > public static final String STORAGE_WRITEONLY_SCOPE = > "https://www.googleapis.com/auth/devstorage.write_only";; > + > + public static final Str

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> Subsequent pull requests superseded this one. I noticed that, sorry (just reviewed one of them, in fact). Some of the comments have indeed already been addressed. Thanks explaining, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-goo

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> + } > + > + @Test(groups = "live", dependsOnMethods = "testPatchDefaultObjectAcl") > + public void testDeleteBucketAcl() { > + api().deleteDefaultObjectAccessControls(BUCKET_NAME, "allUsers"); > + deleteBucket(BUCKET_NAME); > + } > + > + @Test(groups = "live", dependsOnMethods

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> + @Test(groups = "live", dependsOnMethods = "testUpdateDefaultObjectAcl") > + public void testPatchDefaultObjectAcl() { > + DefaultObjectAccessControls defaultObjectAcl = > DefaultObjectAccessControls.builder().bucket(BUCKET_NAME) > + .entity("allUsers").role(ObjectRole.RE

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> + > + assertNotNull(response); > + assertEquals(response.getEntity(), "allUsers"); > + assertEquals(response.getRole(), ObjectRole.OWNER); > + } > + > + @Test(groups = "live", dependsOnMethods = "testUpdateDefaultObjectAcl") > + public void testListDefaultObjectAcl() { > +

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.ObjectRole; > +import org.jclouds.googlecloudstorage.domain.ListDefaultObjectAccessControls; > +import org.jclouds.googlecloudstorage.domain.Resource.Kind; > +import > org.jclouds.googlecloudstorage.internal.BaseGoogleClo

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> + > + assertNotNull(response); > + assertEquals(response.getId(), BUCKET_NAME + "/allUsers"); > + assertEquals(response.getRole(), Role.READER); > + } > + > + @Test(groups = "live", dependsOnMethods = "testPatchBucketacl") > + public void testDeleteBucketacl() { > + api(

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> + > + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl") > + public void testPatchBucketacl() { > + BucketAccessControls bucketacl = > BucketAccessControls.builder().bucket(BUCKET_NAME).entity("allUsers") > + .role(Role.READER).build(); > + BucketAccessC

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> + > + assertNotNull(response); > + assertEquals(response.getId(), BUCKET_NAME + "/allUsers"); > + assertEquals(response.getRole(), Role.WRITER); > + } > + > + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl") > + public void testListBucketacl() { > + ListB

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + */ > +package org.jclouds.googlecloudstorage.parse; > + > +import java.net.URI; > + > +import javax.ws.rs.Consumes; > +import javax.ws.rs.core.MediaType; > + > +import org.jclouds.googlecloudstorage.domain.BucketAccessControls; > +import org.jclouds.googlecloudstorage.domain.BucketAccessControl

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> @@ -112,9 +111,7 @@ BucketAccessControls > createBucketAccessControls(@PathParam("bucket") String buck > @Consumes(MediaType.APPLICATION_JSON) > @Path("/b/{bucket}/acl/{entity}") > @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > - @Fallback(NullOnNotFoundOr404.class) > - @Nullable > -

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> @@ -96,15 +95,15 @@ BucketAccessControls > getBucketAccessControls(@PathParam("bucket") String bucketN > @Path("/b/{bucket}/acl") > @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > @MapBinder(BucketAccessControlsBinder.class) > + @Nullable Curious...when does this return `null`? --- Rep

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

@demobox Subsequent pull requests superseded this one. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/27#issuecomment-55936993

Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)

> @@ -46,7 +46,7 @@ > private BucketAccessControls(@Nullable String id, @Nullable URI selfLink, > @Nullable String etag, String bucket, > String entity, @Nullable String entityId, Role role, @Nullable > String email, @Nullable String domain, > @Nullable ProjectTeam p

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + .role(Role.READER).build(); > + BucketAccessControls response = > api().patchBucketAccessControls(BUCKET_NAME, "allUsers", bucketacl); > + > + assertNotNull(response); > + assertEquals(response.getId(), BUCKET_NAME + "/allUsers"); > + assertEquals(response.get

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl") > + public void testGetBucketacl() { > + BucketAccessControls response = > api().getBucketAccessControls(BUCKET_NAME, "allUsers"); > + > + assertNotNull(response); > + assertEquals(response.getId(), BUCKET_NAME

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

General comments that came up a few times: * please remove the `@author` tag * it would be great if we could replace the expect tests with MockWebServer tests --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/27#issuecomment-55935921

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> +import com.google.inject.Injector; > + > +import com.google.inject.Module; > + > +/** > + * @TODO BUCKET_NAME should be replaced by the name of the bucket created in > "Bucket insert" operation when it is implemented > + * @author Bhathiya Supun > + */ > +public class BaseGoogleCloudStorageApiL

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + > + assertNotNull(response); > + assertEquals(response.getId(), BUCKET_NAME + "/allUsers"); > + assertEquals(response.getRole(), Role.WRITER); > + } > + > + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl") > + public void testListBucketacl() { > + ListB

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + * @author Bhathiya Supun > + */ > +public class BucketAccessControlsApiLiveTest extends > BaseGoogleCloudStorageApiLiveTest { > + > + private BucketAccessControlsApi api() { > + return api.getBucketAccessControlsApi(); > + } > + > + @Test(groups = "live") > + public void testCreat

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> +import static org.testng.Assert.assertNotNull; > +import org.jclouds.googlecloudstorage.domain.BucketAccessControls; > +import org.jclouds.googlecloudstorage.domain.BucketAccessControls.Role; > +import org.jclouds.googlecloudstorage.domain.ListBucketAccessControls; > +import org.jclouds.googlecl

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> +import org.jclouds.googlecloudstorage.parse.BucketaclGetTest; > +import org.jclouds.googlecloudstorage.parse.BucketaclInsertTest; > +import org.jclouds.googlecloudstorage.parse.BucketaclListTest; > +import org.jclouds.googlecloudstorage.parse.BucketaclUpdateTest; > +import org.jclouds.http.HttpR

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + > .payload(payloadFromResourceWithContentType("/bucketacl_update_response.json", > +MediaType.APPLICATION_JSON)).build(); > + > + HttpResponse patchResponse = HttpResponse.builder().statusCode(200) > + > .payload(staticPayloadFromResour

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds » jclouds #1642](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1642/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomme

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + > + public static final HttpResponse GET_BUCKETACL_RESPONSE = > HttpResponse.builder().statusCode(200) > + > .payload(staticPayloadFromResource("/bucketacl_get.json")).build(); > + > + public static final HttpResponse CREATE_BUCKETACL_RESPONSE = > HttpResponse.builder().status

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.googlec

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.googlecloudstorage.handlers; > + > +import java.util.Map; > + > +import javax.i

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + BucketAccessControls updateBucketAccessControls(@PathParam("bucket") > String bucketName, > +@PathParam("entity") String entity, > +@BinderParam(BindToJsonPayload.class) BucketA

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> +* @return If successful, this method returns a BucketAccessControls > resource in the response body > +*/ > + > + @Named("BucketAccessControls:update") > + @PUT > + @Consumes(MediaType.APPLICATION_JSON) > + @Produces(MediaType.APPLICATION_JSON) > + @Path("/b/{bucket}/acl/{enti

Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)

> + @Named("BucketAccessControls:delete") > + @DELETE > + @Consumes(MediaType.APPLICATION_JSON) > + @Path("/b/{bucket}/acl/{entity}") > + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + HttpResponse deleteBucketAccessControls(@PathP

Re: [jclouds] Add assertj-core and assertj-guava dependencies to project pom (#522)

> @@ -310,6 +322,16 @@ >core.incubator >true > > + > + org.assertj > + assertj-core > + test > + > + > + org.assertj > + assertj-guava > + test > + > Does that make sense? Yes, thanks. --- Reply to this email directly or view it

  1   2   >