[jira] [Commented] (JCLOUDS-721) Remove dependency on jna 3.4.0

[ https://issues.apache.org/jira/browse/JCLOUDS-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141722#comment-14141722 ] Andrew Phillips commented on JCLOUDS-721: - PR to fix the underlying issue: * htt

Re: [jclouds] Using net.java.dev.jna:jna 4.0.0 for jsch.agentproxy (#525)

See https://issues.apache.org/jira/browse/JCLOUDS-721 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/525#issuecomment-56255969

Re: [jclouds] Removing jsch.agentproxy deps that pull in net.java.dev.jna:jna (#526)

See https://issues.apache.org/jira/browse/JCLOUDS-721 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/526#issuecomment-56255968

[jira] [Created] (JCLOUDS-721) Remove dependency on jna 3.4.0

Andrew Phillips created JCLOUDS-721: --- Summary: Remove dependency on jna 3.4.0 Key: JCLOUDS-721 URL: https://issues.apache.org/jira/browse/JCLOUDS-721 Project: jclouds Issue Type: Task

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

> so Modernizer should be able to do the same thing. Ah, thanks for explaining. If you think this might be tricky, commit with Modernizer disabled in the downstream labs for now? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/529#issuecomment-56255

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

> Its already fixed and will be in the new PR. ;) Nice...thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/527#issuecomment-56255875

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + PageSet container = > view.getBlobStore().list(containerName, > + maxResults(1).withDetails()); > + > + BlobMetadata metadata = BlobMetadata.class.cast(get(container, 0)); > + > + assert > metadata.getContentMetadata().getContentType().startsWith("text

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + } > + > + private void addContentMetadata(PayloadBlobBuilder blobBuilder) { > + blobBuilder.contentType("text/csv"); > + blobBuilder.contentDisposition("attachment; filename=photo.jpg"); > + blobBuilder.contentLanguage("en"); > + } > + > + protected void checkContentMetad

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + } finally { > + returnContainer(containerName); > + } > + } > + > + protected void addMultipartBlobToContainer(String containerName, String > key) throws IOException { > + ByteSource sourceToUpload = TestUtils.randomByteSource().slice(0, > (long) (PART_SIZE * 1.1));

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + returnContainer(containerName); > + } > + } > + > + protected void addMultipartBlobToContainer(String containerName, String > key) throws IOException { > + ByteSource sourceToUpload = TestUtils.randomByteSource().slice(0, > (long) (PART_SIZE * 1.1)); > + > + BlobSto

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + private long PART_SIZE = MultipartUpload.MIN_PART_SIZE; > + > + @Override > + protected Properties setupProperties() { > + Properties properties = super.setupProperties(); > + properties.put("jclouds.mpu.parts.size", 2 * 1024 * 1024); > + return properties; > + } > + > +

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import org.testng.SkipException; > +import org.testng.annotations.DataProvider; > +import org.testng.annotations.Test; > + > +import com.google.common.base.Charsets; > +import com.google.common.collect.ImmutableMap; > +import com.google.common.hash.HashCode; > +import com.google.common.hash.Hash

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import com.google.common.collect.ImmutableMap; > +import com.google.common.hash.HashCode; > +import com.google.common.hash.HashFunction; > +import com.google.common.hash.Hashing; > +import com.google.common.io.ByteSource; > +import com.google.common.io.Files; > + > +@Test(groups = { "live", "blo

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > - @Nullable > - void deleteBucket(@PathParam("bucket") String bucketName); > + boolean deleteBucket(@PathParam("bucket") String bucketName); > > /** > * Permanently deletes an empty Bucket.If bucket is not empty 409 error > to indica

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -138,6 +159,7 @@ > @Path("/b") > @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > @MapBinder(BucketBinder.class) > + @Fallback(NullOnKeyAlreadyExists.class) We're being pretty lenient in failing quite "silently" here and above...is that intentional? --- Reply to this email directly o

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -64,6 +68,22 @@ > public interface BucketApi { > > /** > +* Check the existence of a bucket [minor] "Checks" --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17817663

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + > +import static com.google.common.base.Preconditions.checkNotNull; > +import static com.google.common.base.Throwables.propagate; > +import static com.google.common.util.concurrent.Futures.immediateFuture; > +import org.jclouds.Fallback; > +import com.google.common.util.concurrent.ListenableFut

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> } > > public HashCode getMd5HashCode() { > - HashCode hc = > HashCode.fromBytes(BaseEncoding.base64().decode(md5Hash)); > - return hc; > + if (md5Hash != null) { > + HashCode hc = > HashCode.fromBytes(BaseEncoding.base64().decode(md5Hash)); > + return hc

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -134,13 +134,19 @@ public String getContentType() { > } > > public HashCode getCrc32cHashcode() { > - HashCode hc = > HashCode.fromBytes(DomainUtils.reverse(BaseEncoding.base64().decode(crc32c))); > - return hc; > + if (crc32c != null) { > + HashCode hc = > H

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -173,8 +176,12 @@ private String getCrc32c() { > } > > public HashCode getCrc32cHashcode() { [minor] "HashCode" in alignment with the others? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17817640

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -134,13 +134,19 @@ public String getContentType() { > } > > public HashCode getCrc32cHashcode() { See above comment --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17817646

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -173,8 +176,12 @@ private String getCrc32c() { > } > > public HashCode getCrc32cHashcode() { > - HashCode hc = > HashCode.fromBytes(DomainUtils.reverse(BaseEncoding.base64().decode(crc32c))); > - return hc; > + if (crc32c != null) { > + HashCode hc = > HashCo

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> @@ -132,8 +132,11 @@ private String getMd5Hash() { > } > > public HashCode getMd5HashCode() { > - HashCode hc = > HashCode.fromBytes(BaseEncoding.base64().decode(md5Hash)); > - return hc; > + if (md5Hash != null) { > + HashCode hc = > HashCode.fromBytes(BaseEnco

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Override > + public String execute(String container, Blob blob) { > + > + ObjectTemplate destination = > blob2ObjectTemplate.apply(blob.getMetadata()); > + ComposeObjectTemplate template = new > ComposeObjectTemplate().destination(destination); > + > + Set sourceList = Set

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + private Logger logger = Logger.NULL; > + > + private final GoogleCloudStorageApi api; > + private final Provider blobBuilders; > + private final BlobMetadataToObjectTemplate blob2ObjectTemplate; > + private final MultipartUploadSlicingAlgorithm algorithm; > + private final PayloadSl

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + parts = (int) (length / unitPartSize); > + } > + if (parts > MultipartUpload.MAX_NUMBER_OF_PARTS) { // if still splits > in too many parts > + parts = MultipartUpload.MAX_NUMBER_OF_PARTS - 1; // limit them. do > not care about not > + // covering > + } >

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + long defaultPartSize = DEFAULT_PART_SIZE; > + > + @Inject(optional = true) > + @Named("jclouds.mpu.parts.magnitude") > + @VisibleForTesting > + int magnitudeBase = DEFAULT_MAGNITUDE_BASE; > + > + // calculated only once, but not from the constructor > + private volatile int parts;

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Named(BlobStoreConstants.BLOBSTORE_LOGGER) > + protected Logger logger = Logger.NULL; > + > + @VisibleForTesting > +static final long DEFAULT_PART_SIZE = 32 * 1024 * 1024; > + > + @VisibleForTesting > + static final int DEFAULT_MAGNITUDE_BASE = 100; > + > + @Inject(optional =

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import javax.inject.Named; > + > +public class MultipartUploadSlicingAlgorithm { > + > + @Resource > + @Named(BlobStoreConstants.BLOBSTORE_LOGGER) > + protected Logger logger = Logger.NULL; > + > + @VisibleForTesting > +static final long DEFAULT_PART_SIZE = 32 * 1024 * 1024; > + > +

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import org.jclouds.logging.Logger; > + > +import javax.annotation.Resource; > +import javax.inject.Named; > + > +public class MultipartUploadSlicingAlgorithm { > + > + @Resource > + @Named(BlobStoreConstants.BLOBSTORE_LOGGER) > + protected Logger logger = Logger.NULL; > + > + @VisibleFor

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache License, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + *

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import com.google.common.annotations.VisibleForTesting; > +import com.google.inject.Inject; > +import org.jclouds.blobstore.reference.BlobStoreConstants; > +import org.jclouds.logging.Logger; > + > +import javax.annotation.Resource; > +import javax.inject.Named; > + > +public class MultipartUplo

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

@demobox I am in the process of rewriting most of this to support Nova Boot from Volume. I noticed that `deviceName` was being returned here as well! Whoopsie. Its already fixed and will be in the new PR. ;) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import org.jclouds.blobstore.strategy.IfDirectoryReturnNameStrategy; > +import org.jclouds.googlecloudstorage.domain.GCSObject; > +import com.google.common.base.Function; > +import com.google.common.collect.ImmutableMap; > + > +@Singleton > +public class ObjectToBlobMetadata implements Function

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Inject > + public ObjectListToStorageMetadata(ObjectToBlobMetadata object2blobMd) { > + this.object2blobMd = object2blobMd; > + } > + > + public PageSet apply(ListPage from) > { > + if (from == null) { > + from = ListPage. builder().kind(Kind.OBJECTS).build(); > +

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +@Singleton > +public class ObjectListToStorageMetadata implements > Function, PageSet> { > + private final ObjectToBlobMetadata object2blobMd; > + > + @Inject > + public ObjectListToStorageMetadata(ObjectToBlobMetadata object2blobMd) { > + this.object2blobMd = object2blobMd; > + }

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + > +import com.google.common.base.Function; > +import com.google.common.base.Supplier; > +import com.google.inject.Inject; > +import com.google.inject.Singleton; > + > +@Singleton > +public class BucketToStorageMetadata implements Function StorageMetadata> { > + private Supplier defaultLocatio

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

> + * A representation of a block device that should be attached to the Nova > instance to be launched > + * > + */ > +public class BlockDeviceMapping { > + > + @Named("delete_on_termination") > + String deleteOnTermination = "0"; > + @Named("device_name") > + String deviceName

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import com.google.inject.Singleton; > +import static com.google.common.base.Preconditions.checkNotNull; > + > +@Singleton > +public class BlobStoreListContainerOptionsToListObjectOptions implements > + Function { > + public ListObjectOptions apply(ListContainerOptions from) { > +

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import java.util.Map; > + > +import javax.inject.Singleton; > + > +import org.jclouds.blobstore.domain.BlobMetadata; > +import org.jclouds.googlecloudstorage.domain.templates.ObjectTemplate; > +import org.jclouds.io.ContentMetadata; > + > +import com.google.common.base.Function; > +import com.go

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + .userMetadata(gcsObject.getAllMetadata()).build(); > + blob.getMetadata().setContainer(container); > + blob.getMetadata().setLastModified(gcsObject.getUpdated()); > + blob.getMetadata().setETag(gcsObject.getEtag()); > + blob.getMetadata().setPublicUri(gcsObject

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + try { > + urlName = name.contains("/") ? URLEncoder.encode(name, > Charsets.UTF_8.toString()) : name; > + } catch (UnsupportedEncodingException uee) { > + throw Throwables.propagate(uee); > + } > + api.getObjectApi().deleteObject(container, urlName); > + }

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + GCSObject gcsObject = api.getObjectApi().getObject(container, name); > + if (gcsObject == null) { > + return null; > + } > + Blob blob = new > BlobBuilderImpl().payload(impl.getPayload()).payload(impl.getPayload()) > + > .contentType(gcsObject.getCont

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + public String putBlob(String container, Blob blob, PutOptions options) { > + if (options.multipart().isMultipart()) { > + return multipartUploadStrategy.execute(container, blob); > + } else { > + return putBlob(container, blob); > + } > + } > + > + @Override

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Override > + public String putBlob(String container, Blob blob, PutOptions options) { > + if (options.multipart().isMultipart()) { > + return multipartUploadStrategy.execute(container, blob); > + } else { > + return putBlob(container, blob); > + } > + } > +

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +*/ > + @Override > + public String putBlob(String container, Blob blob) { > + > checkNotNull(blob.getPayload().getContentMetadata().getContentLength()); > + HashCode md5 = > blob.getMetadata().getContentMetadata().getContentMD5AsHashCode(); > + > + ObjectTemplate templat

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Override > + public boolean blobExists(String container, String name) { > + try { > + String urlName = name.contains("/") ? URLEncoder.encode(name, > Charsets.UTF_8.toString()) : name; > + return api.getObjectApi().objectExist(container, urlName); > + } catch (Un

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + ListPage gcsList = > api.getObjectApi().listObjects(container, listOptions); > + PageSet list = > objectListToStorageMetadata.apply(gcsList); > + return options.isDetailed() ? > fetchBlobMetadataProvider.get().setContainerName(container).apply(list) : > list; > +

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + > + @Override > + public PageSet list(String container, > ListContainerOptions options) { > + > + if (options != null && options != ListContainerOptions.NONE) { > + ListObjectOptions listOptions = > listContainerOptionsToListObjectOptions.apply(options); > + ListPage

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + } catch (HttpResponseException e) { > +// If DefaultObjectAccessControls operation fail, Reverse create > operation the operation. > +api.getBucketApi().deleteBucket(container); > +return false; > + } > + } > + > + return bucket !=

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + > + return bucket != null; > + } > + > + /** Returns list of of all the objects */ > + @Override > + public PageSet list(String container) { > + ListPage gcsList = > api.getObjectApi().listObjects(container); > + PageSet list = > objectListToStorageMetadata.apply(gcsLis

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + if (options.isPublicRead()) { > + try { > +DefaultObjectAccessControlsTemplate doAclTemplate = new > DefaultObjectAccessControlsTemplate().entity( > + "allUsers").role(ObjectRole.READER); > + > api.getDefaultObjectAccessControlsApi().cre

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Override > + public boolean createContainerInLocation(Location location, String > container, CreateContainerOptions options) { > + BucketTemplate template = new BucketTemplate().name(container); > + if (location != null) { > + > org.jclouds.googlecloudstorage.domain.Dom

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + @Override > + public boolean createContainerInLocation(Location location, String > container) { > + BucketTemplate template = new BucketTemplate().name(container); > + if (location != null) { > + > org.jclouds.googlecloudstorage.domain.DomainResourceReferences.Location

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + public org.jclouds.blobstore.domain.PageSet StorageMetadata> apply(ListPage from) { > +return new > PageSetImpl(Iterables.transform(from, > bucketToStorageMetadata), null); > + } > + }.apply(api.getBucketApi().listBucket(projectId.get())); > + } > + > + @O

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> + > + @Inject > + protected GCSBlobStore(BlobStoreContext context, BlobUtils blobUtils, > Supplier defaultLocation, > +@Memoized Supplier> locations, > GoogleCloudStorageApi api, > +BucketToStorageMetadata bucketToStorageMetadata, > ObjectToBlobMetadata objectToBlob

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import org.jclouds.blobstore.domain.BlobMetadata; > +import org.jclouds.blobstore.domain.PageSet; > +import org.jclouds.blobstore.domain.StorageMetadata; > +import org.jclouds.blobstore.options.CreateContainerOptions; > +import org.jclouds.blobstore.options.GetOptions; > +import org.jclouds.blob

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

> +import org.jclouds.blobstore.domain.BlobMetadata; > +import org.jclouds.blobstore.domain.PageSet; > +import org.jclouds.blobstore.domain.StorageMetadata; > +import org.jclouds.blobstore.options.CreateContainerOptions; > +import org.jclouds.blobstore.options.GetOptions; > +import org.jclouds.blob

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

`JavaUrlHttpCommandExecutorService` just calls the long version to satisfy the analyzer. Modernizer passes against the core repository since I already committed the relevant fixes and included an exclusion file for other issues. However, with the non-core repositories, e.g., jclouds-labs, Mod

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

Only just started, but some general comments/questions to check: * should domain objects have `private` or `protected` constructors and fields? I think the PR includes a mix of both * stupid question: do we need `@Named` even if the field name matches the value of the annotation? * should we hav

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

> +*/ > + public static class CreateBuilder extends Builder { > + /** > + * Supply required properties for creating a HealthMonitor's > CreateBuilder. > + * > + * @param type the probe type. > + * @param delay the delay. > + * @param timeout the timeout. >

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

> +*/ > + public static CreateBuilder createBuilder(ProbeType type, Integer delay, > Integer timeout, Integer maxRetries) { > + return new CreateBuilder(type, delay, timeout, maxRetries); > + } > + > + /** > +* @return the Builder for updating a HealthMonitor. > +*/ > + pu

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

> +package org.jclouds.openstack.neutron.v2.domain.lbaas.v1; > + > +import java.beans.ConstructorProperties; > + > +import javax.inject.Named; > + > +import org.jclouds.javax.annotation.Nullable; > + > +import com.google.common.base.MoreObjects; > +import com.google.common.base.Objects; > +import c

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

> + private Integer timeout; > + @Named("max_retries") > + private Integer maxRetries; > + // Optional attributes that can be updated > + @Named("http_method") > + private HttpMethod httpMethod; > + @Named("url_path") > + private String urlPath; > + @Named("expected_codes") > +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

> @@ -103,4 +104,14 @@ > */ > @Delegate > Optional getSecurityGroupApi(@EndpointParam(parser = > RegionToEndpoint.class) String region); > + > + /** > +* Provides access to LBaaS version 1 features. > +* > +* NOTE > +* This API is an extension that may or may not be

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

The `JavaUrlHttpCommandExecutorService.java` fix looks worth committing anyway...or is it part of this PR unintentionally. What is the current problem with this PR? And, out of curiosity, what is the result of running this against jclouds? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

@najtmar Thanks for the updates! `File.separator` sounds like a good idea... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/63#issuecomment-56254657

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

>String instanceName = args[2]; >String zone = args[3]; > - String googleUserName = args[4]; > - String sshPrivateKey = Files.toString(new File(args[5]), > Charset.defaultCharset()); > + String userName = System.getProperty("user.name"); > + String sshPrivateKey

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

> + * A representation of a block device that should be attached to the Nova > instance to be launched > + * > + */ > +public class BlockDeviceMapping { > + > + @Named("delete_on_termination") > + String deleteOnTermination = "0"; > + @Named("device_name") > + String deviceName

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

> + return volumeSize; > + } > + > + /** > +* @return the device name to which the volume is attached > +*/ > + @Nullable > + public String getDeviceName() { > + return deviceName; > + } > + > + /** > +* @return whether the volume should be deleted on terminating t

Re: [jclouds] Updates to Nova Volume/VolumeAttachment Extension APIs (#448)

+1 - looks good to me too. Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/448#issuecomment-56254198

Re: [jclouds] Backport PR 527 to 1.8.x (#528)

@jdaggett Looks like a copy-paste bug here..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/528#issuecomment-56253718

Re: [jclouds] Backport PR 527 to 1.8.x (#528)

> + return volumeSize; > + } > + > + /** > +* @return the device name to which the volume is attached > +*/ > + @Nullable > + public String getDeviceName() { > + return deviceName; > + } > + > + /** > +* @return whether the volume should be deleted on terminating t

Re: [jclouds] Backport PR 522 to 1.8.x (#523)

+1 - looks good to me. Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/523#issuecomment-56253558

Re: [jclouds] Removing jsch.agentproxy deps that pull in net.java.dev.jna:jna (#526)

> causes NoClassDefFoundError for him Thanks for the heads-up, @ahgittin! I can imagine this would be problematic since Windows probably uses pageant...or is this blowing up even if a user doesn't attempt to use this feature? Question is whether we are even planning to support pageant, or only

Re: [jclouds] Backport PR 522 to 1.8.x (#523)

[jclouds » jclouds #1657](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1657/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/523#issuecomme

Re: [jclouds] Backport PR 522 to 1.8.x (#523)

Pushed to 1.8.x 593fbac --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/523#issuecomment-56252737

Re: [jclouds] Backport PR 522 to 1.8.x (#523)

[jclouds-pull-requests #1189](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1189/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/523#issuecomment-56252319

Re: [jclouds] Backport PR 522 to 1.8.x (#523)

[jclouds-pull-requests-java-6 #100](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/100/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/523#issuecomment-56251864

Re: [jclouds] Backport PR 527 to 1.8.x (#528)

[jclouds-pull-requests #1184](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1184/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/528#issuecomment-56250878

Re: [jclouds] Updates to Nova Volume/VolumeAttachment Extension APIs (#448)

Pushed to master 2db654f This will _not_ be backported to `1.8.x` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/448#issuecomment-56249650

[jira] [Commented] (JCLOUDS-172) "Graduate" GCE to core

[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141571#comment-14141571 ] Alexander Gaysinsky commented on JCLOUDS-172: - Hi Everett, We actually contr

[jira] [Comment Edited] (JCLOUDS-172) "Graduate" GCE to core

[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141571#comment-14141571 ] Alexander Gaysinsky edited comment on JCLOUDS-172 at 9/19/14 11:48 PM:

Re: [jclouds] JCLOUDS-514: Support attaching volumes at boot in Nova (#527)

[jclouds-pull-requests #1183](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1183/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/527#issuecomment-56247877

Re: [jclouds] Removing jsch.agentproxy deps that pull in net.java.dev.jna:jna (#526)

according to @neykov this is problematic on windows. our attempt doing this in brooklyn - https://github.com/ahgittin/incubator-brooklyn/commit/72e955c4196a4368437dc7bb7dc9d1133affbf50 - causes `NoClassDefFoundError` for him. any other reports of this? @neykov i'm curious whether it works any

[jira] [Updated] (JCLOUDS-611) Neutron LBaaS extension request

[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-611: Priority: Major (was: Trivial) > Neutron LBaaS extension request > ---

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

[jclouds-labs-openstack-pull-requests #431](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/431/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-56204707

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

[jclouds » jclouds-labs-openstack #1737](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1737/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

@fbrouille Thank you so much for this contribution! I can start reviewing this PR this weekend. :+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-56204409

[jira] [Reopened] (JCLOUDS-611) Neutron LBaaS extension request

[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reopened JCLOUDS-611: > Neutron LBaaS extension request > --- > > Key: JC

[jira] [Commented] (JCLOUDS-611) Neutron LBaaS extension request

[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140866#comment-14140866 ] Jeremy Daggett commented on JCLOUDS-611: This issue can't be resolved until the P

[jira] [Resolved] (JCLOUDS-611) Neutron LBaaS extension request

[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frédéric Brouillé resolved JCLOUDS-611. --- Resolution: Fixed Fix Version/s: 2.0.0 The following PR is to support LBaaS v1

[jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

https://issues.apache.org/jira/browse/JCLOUDS-611 main: - Added getLBaaSv1Api in NeutronApi interface - Added LBaaS v1 alias in NeutronHttpApiModule class - Added LBaaS v1 extension in ExtensionNamespaces class - Added domain/lbaas/v1 package - Added extensions/lbaas/v1 package - Added fallbacks/l

[jira] [Updated] (JCLOUDS-611) Neutron LBaaS extension request

[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Everett Toews updated JCLOUDS-611: -- Assignee: Frédéric Brouillé > Neutron LBaaS extension request > ---

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

> Just a thought: what about preferring the diamond operator instead of the > newArrayList and similar constructs in Java 7? We have a strong dependency on > Guava, but what are your thoughts about using the language idioms when > available? Modernizer suggests the diamond operator instead of `

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

> @@ -26,7 +26,7 @@ >google-examples > > > -1.7.2 > +1.8.0 @najtmar If you have run the examples successfully against `1.8.0`, then I would argue that this change is preferred over `1.7.2`. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Jenkins build is back to normal : jclouds » jclouds-chef #1372

See

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

[jclouds » jclouds #1654](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1654/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/529#issuecomment-56154289

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

> @@ -26,7 +26,7 @@ >google-examples > > > -1.7.2 > +1.8.0 What do you think about this change? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/63/files#r17773096

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

[jclouds » jclouds #1653](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1653/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/529#issuecomment-56143746

  1   2   >