Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

2014-09-20 Thread Bhathiya
@demobox Thanks for reviewing. I would address the suggestions (with some other issues I found) as soon as I find some time. Bit busy with uni exams these days. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-56260373

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-20 Thread fbrouille
Thanks for your review @demobox, - should domain objects have private or protected constructors and fields? I wrote the domain objects in order to be coherent with the rest of the code. Others domain objects were written in the same way: e.g. Pool has private fileds and constructors as Subnet

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-20 Thread Andrew Phillips
es, LBaaS v1 association method takes a health_monitor as parameter (even if only the id must be specified) OK, then the AssociateBuilder is consistent with the pattern. As regards the naming of the API and how to represent the version, I'll defer to @jdaggett @zack-shoylev @everett-toews

Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)

2014-09-20 Thread Andrew Phillips
Bit busy with uni exams these days. Good luck!! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-56268962

Re: [jclouds] Enforce that all interfaces are types via Checkstyle (#512)

2014-09-20 Thread Jeremy Daggett
+1 Please refer to the example in Effective Java 2nd Ed. **Item 4:** _Enforce noninstantiability with a private constructor_ It explains the rationale behind throwing this error. --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Convert fake interfaces to utility classes (#140)

2014-09-20 Thread Andrew Gaul
Motivated by automating code reviews. Pushed to master as 50218e6a0199fdbb483471869fc046ded8b82d11. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/140#issuecomment-56285969

Build failed in Jenkins: jclouds » jclouds shared Maven resources #2762

2014-09-20 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-resources/2762/ -- [INFO] [INFO]

Build failed in Jenkins: jclouds #2762

2014-09-20 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/2762/changes Changes: [Andrew Gaul] Prefer Charsets.UTF_8 over string literal -- [...truncated 544 lines...] [INFO] jclouds CloudFiles US provider SKIPPED [INFO] jclouds CloudFiles UK

Build failed in Jenkins: jclouds » jclouds shared Maven resources #2763

2014-09-20 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-resources/2763/ -- [INFO] [INFO]

Build failed in Jenkins: jclouds #2763

2014-09-20 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/2763/changes Changes: [Andrew Gaul] Convert fake interfaces to utility classes [Andrew Gaul] Enforce that interfaces are types via Checkstyle -- [...truncated 475 lines...] [INFO] jclouds CloudFiles US

Re: [jclouds] Enforce that all interfaces are types via Checkstyle (#512)

2014-09-20 Thread Andrew Gaul
Pushed to master as 200481300d369de9f076d8c30c8ad7ad26f514d0 and b9f54a3301a5a482c6660d4a7c4cf54b4d87a11c. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/512#issuecomment-56286317

Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)

2014-09-20 Thread Ilya Kulakov
@nacx Issue with `testAddIpPermission` should be addressed now. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/70#issuecomment-56286616

Build failed in Jenkins: jclouds » jclouds-labs #1536

2014-09-20 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1536/changes Changes: [kulakov.ilya] CloudSigma2 ComputeService and SecurityGroupExtension -- [...truncated 1720 lines...] Test suite progress: tests succeeded: 11, failed: 0, skipped: 0.

Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)

2014-09-20 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #254](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/254/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/70#issuecomment-56286770