Jenkins build is back to stable : jclouds » jclouds #1665

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1665/changes

Re: [jclouds] Removing jsch.agentproxy deps that pull in net.java.dev.jna:jna (#526)

2014-09-23 Thread Andrew Phillips
Closed #526. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/526#event-168854609

Re: [jclouds] Removing jsch.agentproxy deps that pull in net.java.dev.jna:jna (#526)

2014-09-23 Thread Andrew Phillips
Based on the comments over at #525 and @neykov's tests, closing this one. Many thanks, @neykov! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/526#issuecomment-56481637

[jira] [Created] (JCLOUDS-727) openstack-swift provider's BlobRequestSigner.signPutBlob does not set payload and content lenght

2014-09-23 Thread Shri Javadekar (JIRA)
Shri Javadekar created JCLOUDS-727: -- Summary: openstack-swift provider's BlobRequestSigner.signPutBlob does not set payload and content lenght Key: JCLOUDS-727 URL:

Re: [jclouds] Support availability zone OpenStack parameter when launch nodes. (#519)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #106](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/106/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/519#issuecomment-56486636

Re: [jclouds] Support availability zone OpenStack parameter when launch nodes. (#519)

2014-09-23 Thread Tarasenko Evgeny
@jdaggett I've done rebase/squash. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/519#issuecomment-56486684

Re: [jclouds] Support availability zone OpenStack parameter when launch nodes. (#519)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1195](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1195/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/519#issuecomment-56489421

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ @Path(/vips) + @SelectJson(vip) + VIP createVIP(@WrapWith(vip) VIP.CreateVIP vip); + + /** +* Update a VIP. +* +* @param id the id of the VIP to update. +* @param vip the VIP's attributes to update. +* @return a reference of the updated VIP. +*/ +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ @Path(/health_monitors/{id}) + @Fallback(FalseOnNotFoundOr404.class) + boolean deleteHealthMonitor(@PathParam(id) String id); + + /** +* Associate a HealthMonitor to a Pool. +* +* @param poolId the id of the Pool to associate. +* @param healthMonitor the

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ public String getName() { + return name; + } + + /** +* @return the description of the Pool. +*/ + @Nullable + public String getDescription() { + return description; + } + + /** +* @return the subnet id for this Pool. +*/ + public String

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+public class Pool { + + // Load balancing methods that must be supported by all providers. + // Not an enum type because any provider may support additional balancing methods. + public static String ROUND_ROBIN = ROUND_ROBIN; + public static String LEAST_CONNECTIONS =

Re: [jclouds-labs] Add vSphere support (#61)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs #1546](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1546/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs #1547](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1547/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #257](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/257/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/73#issuecomment-56519460

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #432](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/432/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs-openstack #1747](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1747/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on

Jenkins build became unstable: jclouds » jclouds-labs-openstack #1747

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1747/changes

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+package org.jclouds.openstack.neutron.v2.domain.lbaas.v1; + +import java.beans.ConstructorProperties; + +import javax.inject.Named; + +import org.jclouds.javax.annotation.Nullable; + +import com.google.common.base.MoreObjects; +import com.google.common.base.Objects; +import

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #433](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/433/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ @Named(address) + private String address; + @Named(protocol_port) + private Integer protocolPort; + // Mandatory attributes that can be updated + @Named(pool_id) + private String poolId; + // Optional attributes that can be updated + @Named(weight) + private Integer

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+*/ + public static Builder builder() { + return new Builder(); + } + + /** +* Gets a Builder configured as this object. +*/ + public Builder toBuilder() { + return new Builder().fromHealthMonitorStatus(this); + } + + /** +* Builder. +*/ +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ private Integer timeout; + @Named(max_retries) + private Integer maxRetries; + // Optional attributes that can be updated + @Named(http_method) + private HttpMethod httpMethod; + @Named(url_path) + private String urlPath; + @Named(expected_codes) + private String

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+*/ + public static class CreateBuilder extends BuilderCreateBuilder { + /** + * Supply required properties for creating a HealthMonitor's CreateBuilder. + * + * @param type the probe type. + * @param delay the delay. + * @param timeout the

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs-openstack #1748](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1748/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+/** + * Enumerates supported SessionPersistence types. + */ +public enum SessionPersistenceType { + /** +* All connections that originate from the same source IP address are handled by the same member of the pool. +*/ + SOURCE_IP, + /** +* The load balancing function

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+*/ + public static Builder builder() { + return new Builder(); + } + + /** +* Gets a Builder configured as this object. +*/ + public Builder toBuilder() { + return new Builder().fromPoolStatus(this); + } + + /** +* Builder. +*/ + public

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread fbrouille
+ + /* +* Methods to get the builder follow. +*/ + + /** +* @return the Builder for SessionPersistence. +*/ + public static Builder builder() { + return new Builder(); + } + + /** +* Gets a Builder configured as this object. +*/ + public

Jenkins build is back to stable : jclouds » jclouds-labs-openstack #1748

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1748/changes

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
@@ -103,4 +104,14 @@ */ @Delegate OptionalSecurityGroupApi getSecurityGroupApi(@EndpointParam(parser = RegionToEndpoint.class) String region); + + /** +* Provides access to LBaaS version 1 features. +* +* h3NOTE/h3 +* This API is an extension that may or

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
@@ -67,6 +67,8 @@ protected void configure() { URI.create(http://docs.openstack.org/ext/neutron/router/api/v1.0;)) .put(URI.create(ExtensionNamespaces.SECURITY_GROUPS), URI.create(http://docs.openstack.org/ext/securitygroups/api/v2.0;)) +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+ return expectedCodes; + } + + /** +* @return the pools for this HealthMonitor. +*/ + @Nullable + public ImmutableListPoolStatus getPools() { + return pools; + } + + /** +* @return the administrative state for this HealthMonitor. +*/ +

[jira] [Commented] (JCLOUDS-172) Graduate GCE to core

2014-09-23 Thread Chris Custine (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144940#comment-14144940 ] Chris Custine commented on JCLOUDS-172: --- This is going to take a few days to get

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
@@ -16,3 +16,4 @@ TAGS .metadata/ atlassian-ide-plugin.xml .DS_Store +.java-version Just curious...where is this from? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/73/files#r17919209

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
@@ -88,6 +90,7 @@ protected void configure() { install(new LocationsFromComputeServiceAdapterModuleDroplet, Size, Image, Region() { }); + bind(CreateNodesInGroupThenAddToSet.class).to(CreateKeyPairsBeforeCreatingNodes.class); Perhaps rename to

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
@@ -98,6 +112,7 @@ public int hashCode() { int result = super.hashCode(); result = prime * result + (backupsEnabled == null ? 0 : backupsEnabled.hashCode()); result = prime * result + (privateNetworking == null ? 0 : privateNetworking.hashCode()); + result =

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ + @Inject + protected CreateKeyPairsBeforeCreatingNodes( + CreateNodeWithGroupEncodedIntoName addNodeWithGroupStrategy, + ListNodesStrategy listNodesStrategy, + GroupNamingConvention.Factory namingConvention, + @Named(Constants.PROPERTY_USER_THREADS)

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ + // If no key has been configured and the auto-create option is set, then generate a key pair + if (options.getSshKeyIds().isEmpty() options.getShouldAutoCreateKeyPair() + Strings.isNullOrEmpty(options.getPublicKey())) { +

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ // access the node + if (options.getRunScript() != null) { + checkArgument(!Strings.isNullOrEmpty(options.getLoginPrivateKey()), + no private key configured for: %s; please use options.overrideLoginPrivateKey(rsa_private_text), group); + } + +

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ no private key configured for: %s; please use options.overrideLoginPrivateKey(rsa_private_text), group); + } + + // If there is a key configured, then make sure there is a key pair for it + if (!Strings.isNullOrEmpty(options.getPublicKey())) { +

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ +/** + * Predicate to compare SSH keys by fingerprint. + */ +public class SameFingerprint implements PredicateSshKey { + + public final String fingerprint; + + public SameFingerprint(PublicKey key) { + this.fingerprint = computeFingerprint(checkNotNull(key, key cannot be

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
Do we need an expect or live test for the key generation logic? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/73#issuecomment-56549087

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
@@ -0,0 +1,13 @@ +{ +vip: { +name: new-name, +description: new description, +pool_id: 61b1f87a-7a21-4ad3-9dda-7f81d249944f, +session_persistence: { +cookie_name: MyNewAppCookie, +type: APP_COOKIE +}, +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+admin_state_up: false, +subnet_id: 8032909d-47a1-4715-90af-5153ffe39861, +tenant_id: 83657cfcdfe44cd5920adaf26c48ceea, +connection_limit: 50, +pool_id: 61b1f87a-7a21-4ad3-9dda-7f81d249944f, +session_persistence: { +cookie_name:

Re: [jclouds-labs-google] JCLOUDS-678: Do not silently return null in write operations if a 404 is returned (#40)

2014-09-23 Thread Andrew Phillips
@hsbhathiya @ccustine Is there a chance either of you could help out with this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/40#issuecomment-56553489

Re: [jclouds] Add modernizer-maven-plugin to build (#529)

2014-09-23 Thread Andrew Phillips
@@ -714,6 +715,23 @@ violationSeveritywarning/violationSeverity /configuration /plugin + plugin +groupIdorg.gaul/groupId +artifactIdmodernizer-maven-plugin/artifactId +version1.1.0/version +executions + execution +

Re: [jclouds] Update the GUEST_MASK so that the global identifier is retrieved for private images. (#530)

2014-09-23 Thread Andrew Phillips
jclouds-pull-requests #1193 UNSTABLE Some [real test failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds.provider$softlayer/1193/testReport/) here. Could you have a look at those, @jaiganeshm? Thanks for submitting this! PS: Is there a related JIRA

Re: [jclouds] Update the GUEST_MASK so that the global identifier is retrieved for private images. (#530)

2014-09-23 Thread jaiganeshm
Closed #530. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/530#event-169141678

Re: [jclouds] Update the GUEST_MASK so that the global identifier is retrieved for private images. (#530)

2014-09-23 Thread jaiganeshm
Fixing test failures. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/530#issuecomment-56554645

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
@@ -33,6 +33,7 @@ private SetInteger sshKeyIds = ImmutableSet.of(); private Boolean privateNetworking; private Boolean backupsEnabled; + private boolean shouldAutoCreateKeyPair = true; Just `autocreateKeyPair` or so? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ public Map?, ListenableFutureVoid execute(String group, int count, Template template, + SetNodeMetadata goodNodes, MapNodeMetadata, Exception badNodes, + MultimapNodeMetadata, CustomizationResponse customizationResponses) { + + DigitalOceanTemplateOptions options

Re: [jclouds] Update the GUEST_MASK so that the global identifier is retrieved for private images. (#530)

2014-09-23 Thread Andrew Phillips
closed this 9 minutes ago No need to close this...you should simply be able to add a commit with the test fixes, that will update the PR automatically. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/530#issuecomment-56556009

Re: [jclouds] Update the GUEST_MASK so that the global identifier is retrieved for private images. (#530)

2014-09-23 Thread jaiganeshm
Oh ok. Didn't know that.. I am trying to figure out how the junits work. I can see the http request being made, but cannot get the response.. Are these real http calls to SL or is there a mock server responding ? --- Reply to this email directly or view it on GitHub:

[jira] [Updated] (JCLOUDS-727) openstack-swift provider's BlobRequestSigner.signPutBlob does not set payload and content length

2014-09-23 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-727: Labels: swift (was: ) openstack-swift provider's BlobRequestSigner.signPutBlob does not set

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+ * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the

Build failed in Jenkins: jclouds » jclouds shared Maven resources #2767

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-resources/2767/ -- [INFO] [INFO]

Build failed in Jenkins: jclouds #2767

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/2767/changes Changes: [Andrew Gaul] Revert Unhook modernizer from verify phase -- [...truncated 547 lines...] [INFO] jclouds CloudFiles US provider SKIPPED [INFO] jclouds CloudFiles UK

Build failed in Jenkins: jclouds » jclouds shared Maven resources #2768

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-resources/2768/ -- [INFO] [INFO]

Build failed in Jenkins: jclouds #2768

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/2768/ -- [...truncated 547 lines...] [INFO] jclouds CloudFiles US provider SKIPPED [INFO] jclouds CloudFiles UK provider SKIPPED [INFO] jclouds Rackspace Next

[jira] [Commented] (JCLOUDS-172) Graduate GCE to core

2014-09-23 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145231#comment-14145231 ] Andrew Gaul commented on JCLOUDS-172: - [~ccustine] Sorry I do not understand your

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+package org.jclouds.openstack.neutron.v2.domain.lbaas.v1; + +import java.beans.ConstructorProperties; + +import javax.inject.Named; + +import org.jclouds.javax.annotation.Nullable; + +import com.google.common.base.MoreObjects; +import com.google.common.base.Objects; +import

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+ /** + * Provides the administrative state for this HealthMonitor's Builder. + * + * @return the Builder. + * @see HealthMonitor#getAdminStateUp() + */ + public ParameterizedBuilderType adminStateUp(Boolean adminStateUp) { +

Build failed in Jenkins: jclouds » jclouds-labs-google #1375

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1375/ -- [...truncated 10 lines...] Downloaded artifact

Build failed in Jenkins: jclouds #2769

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/2769/ -- [...truncated 2773 lines...] [INFO] jclouds CloudFiles US provider SKIPPED [INFO] jclouds CloudFiles UK provider SKIPPED [INFO] jclouds Rackspace Next

Build failed in Jenkins: jclouds » jclouds shared Maven resources #2769

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-resources/2769/ -- [INFO] [INFO]

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1749

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1749/ -- [...truncated 223 lines...] Test suite progress: tests succeeded: 25, failed: 0, skipped: 0. Starting test

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-23 Thread Chris Custine
I spoke to @andreaturli today and he is hoping to work on finalizing this next week so that we can merge this and #38 before graduating to jclouds/jclouds. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/22#issuecomment-56577803

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Ignasi Barrera
+ @Path(/vips) + @SelectJson(vip) + VIP createVIP(@WrapWith(vip) VIP.CreateVIP vip); + + /** +* Update a VIP. +* +* @param id the id of the VIP to update. +* @param vip the VIP's attributes to update. +* @return a reference of the updated VIP. +*/ +

[jira] [Commented] (JCLOUDS-172) Graduate GCE to core

2014-09-23 Thread Chris Custine (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145316#comment-14145316 ] Chris Custine commented on JCLOUDS-172: --- [~gaul]: I had thought that 1.8.1 was the

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
@@ -16,3 +16,4 @@ TAGS .metadata/ atlassian-ide-plugin.xml .DS_Store +.java-version The PR contains 2 commits: one with the SSH changes and one that adds the jEnv config. The jEnv config was already merged in the main repo and the openstack one, and I included it in this PR just for

[jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
APIs that return `boolean` or `Boolean` should use the standard JavaBeans naming conventions. @zack-shoylev On the deprecations, should we state that it will be removed in 1.8.2, or 2.0? I just put the 2.1 in there as a placeholder until I got your feedback. WDYT? You can merge this Pull

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1750

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1750/changes Changes: [jeremy.daggett] Correct boolean API signatures to use isXXX(), rather than getXXX() -- [...truncated 235 lines...] [pool-8-thread-1] Test

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs-openstack #1750](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1750/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #434](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/434/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
@@ -16,3 +16,4 @@ TAGS .metadata/ atlassian-ide-plugin.xml .DS_Store +.java-version one that adds the jEnv config. Ah, this is for jEnv...thanks for explaining! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/73/files#r17935073

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
Reopened #147. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/147#event-169248179

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
Closed #147. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/147#event-169248149

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
+ + @Inject + protected CreateKeyPairsBeforeCreatingNodes( + CreateNodeWithGroupEncodedIntoName addNodeWithGroupStrategy, + ListNodesStrategy listNodesStrategy, + GroupNamingConvention.Factory namingConvention, + @Named(Constants.PROPERTY_USER_THREADS)

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
@@ -98,6 +112,7 @@ public int hashCode() { int result = super.hashCode(); result = prime * result + (backupsEnabled == null ? 0 : backupsEnabled.hashCode()); result = prime * result + (privateNetworking == null ? 0 : privateNetworking.hashCode()); + result =

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1751

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1751/changes Changes: [Jeremy Daggett] Correct boolean API signatures to use isXXX(), rather than getXXX() -- [...truncated 224 lines...] Test suite progress: tests succeeded:

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #435](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/435/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
+ + // If no key has been configured and the auto-create option is set, then generate a key pair + if (options.getSshKeyIds().isEmpty() options.getShouldAutoCreateKeyPair() + Strings.isNullOrEmpty(options.getPublicKey())) { +

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs-openstack #1751](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1751/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Update the GUEST_MASK so that the global identifier is retrieved for private images. (#530)

2014-09-23 Thread Andrew Phillips
I can see the http request being made, but cannot get the response We use MockWebServer for newer tests, but these older tests are using an internal mock. The expected request/response pairs are set up in the [`requestsSendResponse`

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
+ // access the node + if (options.getRunScript() != null) { + checkArgument(!Strings.isNullOrEmpty(options.getLoginPrivateKey()), + no private key configured for: %s; please use options.overrideLoginPrivateKey(rsa_private_text), group); + } + +

Re: [jclouds] Support availability zone OpenStack parameter when launch nodes. (#519)

2014-09-23 Thread Andrew Phillips
Perhaps I'm missing something...where is this new setting actually _used_? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/519#issuecomment-56583306

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Andrew Phillips
Closing until build issues in jclouds/jclouds are sorted out. Would be worth pinging @adriancole on this...I'm not sure whether some of the jclouds reflection may expect `getX` as a pattern? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Andrew Phillips
+ + // If no key has been configured and the auto-create option is set, then generate a key pair + if (options.getSshKeyIds().isEmpty() options.getShouldAutoCreateKeyPair() + Strings.isNullOrEmpty(options.getPublicKey())) { +

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
+ no private key configured for: %s; please use options.overrideLoginPrivateKey(rsa_private_text), group); + } + + // If there is a key configured, then make sure there is a key pair for it + if (!Strings.isNullOrEmpty(options.getPublicKey())) { +

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
Do we need an expect or live test for the key generation logic? The key pair api already has expect and live tests, and the key generation is already verified by the generic ComputeService live tests: if the run script feature works, it means that the key pairs are generated, also the key is

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-23 Thread Andrew Phillips
I spoke to @andreaturli today and he is hoping to work on finalizing this next week Thanks, @ccustine and @andreaturli! Looks like this needs a rebase first of all ;-) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
@demobox I'm confused by your comment. These are just domain accessors that have been renamed. ?? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/147#issuecomment-56587740

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
+ + // If no key has been configured and the auto-create option is set, then generate a key pair + if (options.getSshKeyIds().isEmpty() options.getShouldAutoCreateKeyPair() + Strings.isNullOrEmpty(options.getPublicKey())) { +

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread Ignasi Barrera
@demobox Addressed your comments and improved the cleanup strategy. Now I'm registering a callback to delete the key pairs once all nodes have been created. Code is a bit cleaner, as the custom Template object to carry the auto-generated key pair ids is no longer needed. --- Reply to this

Jenkins build is back to normal : jclouds » jclouds-labs-google #1376

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1376/

Jenkins build is back to normal : jclouds » jclouds-labs-openstack #1752

2014-09-23 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1752/

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread BuildHive
[jclouds » jclouds-labs #1549](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1549/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-707: Improve SSH key pair creation in DigitalOcean (#73)

2014-09-23 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #258](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/258/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/73#issuecomment-56595354

[jira] [Created] (JCLOUDS-728) Support nested API @Delegate annotations

2014-09-23 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-728: -- Summary: Support nested API @Delegate annotations Key: JCLOUDS-728 URL: https://issues.apache.org/jira/browse/JCLOUDS-728 Project: jclouds Issue Type:

Jenkins build is back to normal : jclouds » jclouds ultradns-ws provider #2770

2014-09-23 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds.provider$ultradns-ws/2770/

  1   2   >