[jira] [Commented] (JCLOUDS-736) snapshot repo mildly screwed

2014-09-30 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154460#comment-14154460 ] Ignasi Barrera commented on JCLOUDS-736: More context on the tricky checkstyle co

[jira] [Commented] (JCLOUDS-692) Remove the CloudSigma v1 provider

2014-09-30 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154436#comment-14154436 ] Ignasi Barrera commented on JCLOUDS-692: Sure, but take into account that v2 is a

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Andrew Phillips
> @@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) > { > // HttpUrlConnection strips Content-Length: 0 without > setDoOutput(true) > String method = connection.getRequestMethod(); > if ("POST".equals(method) || "PUT".equals(method)) { > -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Adrian Cole
another way out is to change S3ClientMockTest to use okhttp's http driver. I would highly doubt that fails. Anyway this might be simple enough to reproduce, as MWS has a similar test already. https://github.com/square/okhttp/blob/master/mockwebserver/src/test/java/com/squareup/okhttp/mockwebse

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Adrian Cole
> @@ -280,7 +280,6 @@ protected void writeNothing(HttpURLConnection connection) > { > // HttpUrlConnection strips Content-Length: 0 without > setDoOutput(true) > String method = connection.getRequestMethod(); > if ("POST".equals(method) || "PUT".equals(method)) { > -

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Adrian Cole
I don't think it is a good idea to revert the fixedlengthstreaming mode. I can see how I could have left a comment more descriptive than urlconnection will screw up if we don't do this, but if need be I can dig more into what the original issue with this was. best I can recall, it was a jdk 6 vs

[jira] [Commented] (JCLOUDS-692) Remove the CloudSigma v1 provider

2014-09-30 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154387#comment-14154387 ] Andrew Phillips commented on JCLOUDS-692: - I guess http://jclouds.apache.org/guid

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> */ > +@Headers(keys = "x-ms-version", values = "2012-03-01") > probably, but more helpful pulling 2014-something into a constant :P *grin*. Well, one step (year?) at a time... ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76/files#r18

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread Andrew Phillips
I'm guessing http://jclouds.apache.org/guides/cloudsigma/ will need a corresponding cleanup..? /cc @nacx --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57421326

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
@demobox yeah I will knock on the things you mentioned later, especially putting docs where they should (or delete them), visibility sweep, re-org methods that are probably in the wrong apis or are a train-wreck of string params, etc. too --- Reply to this email directly or view it on GitHub: h

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread Andrew Phillips
> there's a note in the jira. Oops...lazy me. Sorry. +1 - looks good to me. Thanks for the cleanup! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57421224

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> > - private List elements = Lists.newArrayList(); > - protected StringBuilder currentText = new StringBuilder(); > - private Deployment.Builder builder = Deployment.builder(); > + @Override > + public Deployment getResult() { > + try { > + return builder.build(); >

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> + this.osType = osType; > + return this; > + } > + > + public Builder endpoint(InputEndpoint endpoint) { > + endpoints.add(endpoint); > + return this; > + } > + > + public DeploymentParams build() { > + return new DeploymentParams(name,

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> */ > +@Headers(keys = "x-ms-version", values = "2012-03-01") probably, but more helpful pulling 2014-something into a constant :P --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76/files#r18262072

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> I don't want to polish too much on the internals there until revisiting docs > and seeing how things match > up. Sure, makes sense. I just wanted to flag it up as I went by. Thanks for getting this started! Glad to see so much dead code disappearing... --- Reply to this email directly or vie

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> + this.roleName = roleName; > + return this; > + } > + > + public Deployment build() { > + return new Deployment(deploymentName, deploymentSlot, > deploymentStatus, deploymentLabel, deploymentURL, > + roleName, instanceName, instanceStatus, instanc

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> > - private List elements = Lists.newArrayList(); > - protected StringBuilder currentText = new StringBuilder(); > - private Deployment.Builder builder = Deployment.builder(); > + @Override > + public Deployment getResult() { > + try { > + return builder.build(); >

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> @@ -47,9 +45,9 @@ public void test() { > > } > > - protected final DateService dateService = new > SimpleDateFormatDateService(); > + private static final DateService dateService = new > SimpleDateFormatDateService(); Just to verify...`SimpleDateFormatDateService` is indeed thread-

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> /** > * @see http://msdn.microsoft.com/en-us/library/jj157176"; >api > */ > public class DiskHandler extends > ParseSax.HandlerForGeneratedRequestWithResult { > > - protected final AttachmentHandler attachmentHandler; > + private final AttachmentHandler attachmentHan

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> @Override > - public Set getResult() { > + public List getResult() { We've always been wrong using Set for things like this. there was an old convo with tim p about this. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76/files#r18261

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
@demobox so to help save you time, before this PR, we couldn't build azure-management at all. I'm not happy with the api organization, but certainly won't address that here either. this is just to weed out the better stuff from the horrible stuff. For example, I'm not even sure we want a HostedS

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> @Override > - public Set getResult() { > + public List getResult() { Change here and similarly below caused by changes to the API? Or was the domain model simply wrong? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76/files#r1826194

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> /** > * @see http://msdn.microsoft.com/en-us/library/jj157176"; >api > */ > public class DiskHandler extends > ParseSax.HandlerForGeneratedRequestWithResult { > > - protected final AttachmentHandler attachmentHandler; > + private final AttachmentHandler attachmentHan

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> > - private List elements = Lists.newArrayList(); > - protected StringBuilder currentText = new StringBuilder(); > - private Deployment.Builder builder = Deployment.builder(); > + @Override > + public Deployment getResult() { > + try { > + return builder.build(); >

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
@demobox so just to set expectations, I'm not going to fix all problems in azure in this pr. There are still quite many left.. equals/hashcode screwups, wrong names in javadac, or bad javadoc, visibility etc. This PR is just to get the project into a state where I can look at the code. For examp

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread BuildHive
[jclouds » jclouds-labs #1570](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1570/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pul

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> */ > - String startRole(String serviceName, String deploymentName, String > roleName); > - > + @Named("StartRole") > + @POST > + > @Path("/services/hostedservices/{serviceName}/deployments/{deploymentName}/roleInstances/{roleName}/Operations") The usual common prefix comment ---

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> */ > - String createDeployment(String serviceName, DeploymentParams > deploymentParams); > + @Named("CreateVirtualMachineDeployment") > + @POST > + @Path("/services/hostedservices/{serviceName}/deployments") > + @Produces(MediaType.APPLICATION_XML) > + @ResponseParser(ParseReque

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> */ > - @Named("DeleteOsImage") > + @Named("DeleteImage") > @DELETE > @Path("/services/images/{imageName}") Same "common prefix?" question as above. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76/files#r18261801

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> * @param serviceName > * the unique DNS Prefix value in the Windows Azure Management > Portal > * @param deploymentName > * the unique DNS Prefix value in the Windows Azure Management > Portal > */ > - Deployment getDeployment(String serviceName, S

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> +* virtual machine to fail to start. Contact support for additional > +* assistance. > +* > +* For web and worker roles this field returns an error code that can be > provided to Windows Azure support to assist > +* in resolution of errors. Typically this field will be empty.

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> public interface DiskApi { > > /** > * The List Disks operation retrieves a list of the disks in your image > repository. > */ > - Set list(); > + @Named("ListDisks") > + @GET > + @Path("/services/disks") Can this be moved to the interface level as a common prefix? ---

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> */ > +@Headers(keys = "x-ms-version", values = "2012-03-01") Worth pulling "2012-03-01" out into a constant? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76/files#r18261767

[jira] [Commented] (JCLOUDS-664) Azure compute support

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154372#comment-14154372 ] Adrian Cole commented on JCLOUDS-664: - cleanup phase 1 https://github.com/jclouds/jcl

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread Adrian Cole
@demobox there's a note in the jira. basically these are network unreachable and the replacement is in labs. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57420050

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
>jclouds components to access an implementation of Azure > Management >bundle > > > - > FIXME_subscription-id > + > FIXME_subscription-id > this corresponds to a provider property that starts with jclouds. I saw the `SUBSCRIPTION_ID` constant later. Thanks for explaining!

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> import com.google.common.base.CaseFormat; > > +import static com.google.common.base.Preconditions.checkNotNull; > + > public enum DeploymentStatus { > RUNNING, SUSPENDED, RUNNING_TRANSITIONING, SUSPENDED_TRANSITIONING, > STARTING, SUSPENDING, DEPLOYING, DELETING; [minor] Does this nee

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> + this.roleName = roleName; > + return this; > + } > + > + public Deployment build() { > + return new Deployment(deploymentName, deploymentSlot, > deploymentStatus, deploymentLabel, deploymentURL, > + roleName, instanceName, instanceStatus, instanc

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> + this.roleName = roleName; > + return this; > + } > + > + public Deployment build() { > + return new Deployment(deploymentName, deploymentSlot, > deploymentStatus, deploymentLabel, deploymentURL, > + roleName, instanceName, instanceStatus, instanc

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> + // TODO Since the roleName should be unique, is it a good idea to > copy it ? > + return > this.name(in.getName()).sourceImageName(in.getSourceImageName()).username(in.getUsername()) > + .password(in.getPassword()).size(in.getSize()); > + } > + } > + > +

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> + this.osType = osType; > + return this; > + } > + > + public Builder endpoint(InputEndpoint endpoint) { > + endpoints.add(endpoint); > + return this; > + } > + > + public DeploymentParams build() { > + return new DeploymentParams(name,

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
> - > - } > - > - @Override > - public Iterable listNodes() { > - // TODO Auto-generated method stub > - return null; > - } > - > +public class AzureManagementComputeServiceAdapter > + implements ComputeServiceAdapter { > + > + @Override > + public

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread BuildHive
[jclouds » jclouds-labs #1569](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1569/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pul

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
>jclouds components to access an implementation of Azure > Management >bundle > > > - > FIXME_subscription-id > + > FIXME_subscription-id this corresponds to a provider property that starts with jclouds. --- Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> +* virtual machine to fail to start. Contact support for additional > +* assistance. > +* > +* For web and worker roles this field returns an error code that can be > provided to Windows Azure support to assist > +* in resolution of errors. Typically this field will be empty.

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> + this.roleName = roleName; > + return this; > + } > + > + public Deployment build() { > + return new Deployment(deploymentName, deploymentSlot, > deploymentStatus, deploymentLabel, deploymentURL, > + roleName, instanceName, instanceStatus, instanc

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #270](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/270/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57419708

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
>* @see href="http://msdn.microsoft.com/en-us/library/ee460786";>docs >*/ > - public static final String SUBSCRIPTION_ID = > "jclouds.azure.management.subscription-id"; > + public static final String SUBSCRIPTION_ID = > "jclouds.azure-management.subscription-id"; Ah, I s

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> - > - } > - > - @Override > - public Iterable listNodes() { > - // TODO Auto-generated method stub > - return null; > - } > - > +public class AzureManagementComputeServiceAdapter > + implements ComputeServiceAdapter { > + > + @Override > + public

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
> + > + inputEndpoints.up(); > + configBuilder.e("SubnetNames").up() > +.up(); > + > + builder.up() //ConfigurationSets > +.e("DataVirtualHardDisks").up() > +.e("OSVirtualHardDisk") > +.e("HostCaching").t("ReadWrite").up() > +

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread Yaron Rosenbaum
> + > + org.apache.jclouds > + jclouds-all > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-log4j > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-sshj > + 1.8.0 > + > +* Note - make sure that the dependency is 'JAR' Makes sense :) (Y) On

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Andrew Phillips
>jclouds components to access an implementation of Azure > Management >bundle > > > - > FIXME_subscription-id > + > FIXME_subscription-id [minor] Just ``? Or is there some good reason to have the "jclouds" in there? --- Reply to this email directly or view it on GitHub: ht

Re: [jclouds] Work around mockwebserver hangs in S3 tests (#502)

2014-09-30 Thread Andrew Phillips
@adriancole Seeing as you seem to be online...ping? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/502#issuecomment-57419450

Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #269](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/269/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57419384

[jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)

2014-09-30 Thread Adrian Cole
This cleans up the azure management api so that we can start working on it again. This doesn't mean cleanups are done. this is just the first stab. It does the following. * removes async stuff * move off deprecated core code (ex RestApiModule) * fixes random annotation problems * fix a to

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-30 Thread Andrew Phillips
> Here is a somewhat different suggestion: keep v1 directory structures as they > are right now. When v2 > comes around, implement it without using lbaas.v2 in package and class names. > Then deprecate v1. Makes sense to me. Assuming we don't expect a `v3` to come along, that is ;-) --- Reply

Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)

2014-09-30 Thread Andrew Phillips
> +import org.jclouds.scriptbuilder.domain.StatementList; > +import org.jclouds.scriptbuilder.statements.ssh.InstallRSAPrivateKey; > +import org.jclouds.ssh.SshKeys; > +import org.testng.annotations.Test; > + > +import java.util.Map; > + > +import static org.testng.Assert.assertEquals; > +import st

Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)

2014-09-30 Thread Andrew Phillips
> @@ -50,12 +54,10 @@ protected CloudSigma2ApiMetadata(Builder builder) { > > public static Properties defaultProperties() { >Properties properties = BaseHttpApiMetadata.defaultProperties(); > - properties.setProperty(CloudSigma2Properties.PROPERTY_VNC_PASSWORD, > "IL9vs34d"); >

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread BuildHive
[jclouds » jclouds #1676](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1676/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomme

Re: [jclouds] JCLOUDS-735 Remove ninefold providers. (#534)

2014-09-30 Thread BuildHive
[jclouds » jclouds #1675](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1675/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/534#issuecomment-57404658

Re: [jclouds] JCLOUDS-735 Remove ninefold providers. (#534)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1199](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1199/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/534#issuecomment-57400979

Re: [jclouds] Refactor ssh properties (#532)

2014-09-30 Thread Andrew Phillips
> @Resource > - @Named("jclouds.ssh") > + @Named(SSH_LOGGER_NAME) Lazy question: do we use constants for loggers anywhere else? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/532/files#r18254563

Re: [jclouds-labs-google] JCLOUDS-678: Do not silently return null in write operations if a 404 is returned (#40)

2014-09-30 Thread Andrew Phillips
> When I get a chance, I'll cherry pick the commits from #49 into a branch and > retest this PR. Thanks, @aledsage! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/40#issuecomment-57399752

Re: [jclouds] JCLOUDS-735 Remove ninefold providers. (#534)

2014-09-30 Thread Andrew Phillips
> Service suggests it was ended in August Link for that (just out of curiosity)? There still appears to be [some kind of compute service](https://ninefold.com/virtual-servers/) there..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/534#issuecommen

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread Andrew Phillips
@adriancole Fine with the code change itself. Remove because broken, or decommissioned, or..? Do we need to make any corresponding changes to the site? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57399343

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1200](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1200/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57398950

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #111](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/111/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57397070

[jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-09-30 Thread Adrian Cole
https://issues.apache.org/jira/browse/JCLOUDS-692 You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds adrian.no-cloudsigma1 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/535 -- Commit Summary -- * JCL

[jira] [Commented] (JCLOUDS-692) Remove the CloudSigma v1 provider

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153971#comment-14153971 ] Adrian Cole commented on JCLOUDS-692: - https://github.com/jclouds/jclouds/pull/535 >

[jira] [Commented] (JCLOUDS-692) Remove the CloudSigma v1 provider

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153948#comment-14153948 ] Adrian Cole commented on JCLOUDS-692: - these endpoints are not even network reachable

[jira] [Assigned] (JCLOUDS-692) Remove the CloudSigma v1 provider

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole reassigned JCLOUDS-692: --- Assignee: Adrian Cole (was: Ignasi Barrera) > Remove the CloudSigma v1 provider > -

[jira] [Commented] (JCLOUDS-172) "Graduate" GCE to core

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153934#comment-14153934 ] Adrian Cole commented on JCLOUDS-172: - Drive-by commentary. I don't think we make as

Re: [jclouds] JCLOUDS-735 Remove ninefold providers. (#534)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-pull-requests-java-6 #110](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/110/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/534#issuecomment-57394916

[jclouds] JCLOUDS-735 Remove ninefold providers. (#534)

2014-09-30 Thread Adrian Cole
https://issues.apache.org/jira/browse/JCLOUDS-735 Service suggests it was ended in August You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds adrian.no-ninefold Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/p

[jira] [Commented] (JCLOUDS-735) Remove ninefold providers

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153919#comment-14153919 ] Adrian Cole commented on JCLOUDS-735: - https://github.com/jclouds/jclouds/pull/534 >

[jira] [Assigned] (JCLOUDS-736) snapshot repo mildly screwed

2014-09-30 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul reassigned JCLOUDS-736: --- Assignee: Andrew Gaul I likely caused this with a bad modernizer goal. I believe I disabled

[jira] [Created] (JCLOUDS-736) snapshot repo mildly screwed

2014-09-30 Thread Adrian Cole (JIRA)
Adrian Cole created JCLOUDS-736: --- Summary: snapshot repo mildly screwed Key: JCLOUDS-736 URL: https://issues.apache.org/jira/browse/JCLOUDS-736 Project: jclouds Issue Type: Task Rep

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread Andrew Phillips
> + > + org.apache.jclouds > + jclouds-all > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-log4j > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-sshj > + 1.8.0 > + > +* Note - make sure that the dependency is 'JAR' > All in all, this proc

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread Yaron Rosenbaum
> + > + org.apache.jclouds > + jclouds-all > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-log4j > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-sshj > + 1.8.0 > + > +* Note - make sure that the dependency is 'JAR' Hi guys. I agree that

[jira] [Assigned] (JCLOUDS-716) Remove Rackspace First-Gen Cloud Servers

2014-09-30 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-716: -- Assignee: Jeremy Daggett > Remove Rackspace First-Gen Cloud Servers >

[jira] [Commented] (JCLOUDS-735) Remove ninefold providers

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153418#comment-14153418 ] Adrian Cole commented on JCLOUDS-735: - ps this is per https://ninefold.com/nf1/ The

[jira] [Created] (JCLOUDS-735) Remove ninefold providers

2014-09-30 Thread Adrian Cole (JIRA)
Adrian Cole created JCLOUDS-735: --- Summary: Remove ninefold providers Key: JCLOUDS-735 URL: https://issues.apache.org/jira/browse/JCLOUDS-735 Project: jclouds Issue Type: Bug Component

[jira] [Assigned] (JCLOUDS-664) Azure compute support

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole reassigned JCLOUDS-664: --- Assignee: Adrian Cole (was: Andrew Bayer) > Azure compute support > - >

[jira] [Commented] (JCLOUDS-49) Remove async interface from core openstack apis/providers, rename *Client to *Api

2014-09-30 Thread Adrian Cole (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153355#comment-14153355 ] Adrian Cole commented on JCLOUDS-49: Looks like the following are left: Following leg

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-30 Thread Andrew Phillips
> + @Transform(ParseTargetPools.ToPagedIterable.class) > + @Fallback(EmptyPagedIterableOnNotFoundOr404.class) > + PagedIterable listInRegion(@PathParam("region") String > region); > + > + @Named("TargetPools:list") > + @GET > + @Consumes(MediaType.APPLICATION_JSON) > + @Path("/region

Re: [jclouds-site] Update compute.md (#128)

2014-09-30 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-site.git;a=commit;h=25718f67231092465b2d02660285bc6fbd73126c). It'll be published as part of the next site update. Thanks, @Brainmote! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread Andrew Phillips
In general, I'm not against these kind of changes, but I think we should also aim to keep our user guides somewhat consistent. These additions don't appear in any of the recently-added guides, such as Abiquo or Docker. So I think we need a slightly broader discussion here. @nacx @zack-shoylev @

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread Andrew Phillips
> +Required Maven dependencies: > + > + org.apache.jclouds > + jclouds-all > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-log4j > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-sshj > + 1.8.0 > + This is one possible dependency set, but w

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread Andrew Phillips
> + > + org.apache.jclouds > + jclouds-all > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-log4j > + 1.8.0 > + > + > + org.apache.jclouds.driver > + jclouds-sshj > + 1.8.0 > + > +* Note - make sure that the dependency is 'JAR' This is "Maven basics"

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread CloudBees pull request builder plugin
[jclouds-site-pull-requests #401](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/401/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/129#issuecomment-57318352

[jclouds-site] Update aws.md (#129)

2014-09-30 Thread Yaron Rosenbaum
Update to 1.8 Added explicitly required maven dependencies (it's a nightmare for a new user to figure this on his own) Added explicitly correct imports (some are very confusing) Need to do the same for S3. You can merge this Pull Request by running: git pull https://github.com/yaronr/jclouds-s

Re: [jclouds-site] Update aws.md (#129)

2014-09-30 Thread jclouds-commentator
Go to http://63bb69f6cc0a03e49d54-3220a47abbaf45d59f45d9ec34db9a2d.r13.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/129#issuecomment-57318756

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-30 Thread Andrea Turli
> + > + /** > +* Creates a ForwardingRule resource in the specified project and region > using the data included in the request. > +* > +* @param forwardingRuleName the name of the forwarding rule. > +* @param targetSelfLink the URL of the target resource to receive the > matche

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-30 Thread Andrew Phillips
> + > + /** > +* Creates a ForwardingRule resource in the specified project and region > using the data included in the request. > +* > +* @param forwardingRuleName the name of the forwarding rule. > +* @param targetSelfLink the URL of the target resource to receive the > matche

Re: [jclouds-site] Removing no-longer-that-new quicknews item (#127)

2014-09-30 Thread Andrew Phillips
> SVN commit to publish the site needed? Yes...haven't got round to that yet. If you have a moment, that would be great! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/127#issuecomment-57314179

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-30 Thread Andrea Turli
> + > +import javax.ws.rs.core.MediaType; > + > +import java.net.URI; > + > +import static > org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.COMPUTE_READONLY_SCOPE; > +import static > org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.COMPUTE_SCOPE; > +import static org.tes

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-30 Thread Andrea Turli
> + @Transform(ParseTargetPools.ToPagedIterable.class) > + @Fallback(EmptyPagedIterableOnNotFoundOr404.class) > + PagedIterable listInRegion(@PathParam("region") String > region); > + > + @Named("TargetPools:list") > + @GET > + @Consumes(MediaType.APPLICATION_JSON) > + @Path("/region

Re: [jclouds-site] Removing no-longer-that-new quicknews item (#127)

2014-09-30 Thread Ignasi Barrera
SVN commit to publish the site needed? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/127#issuecomment-57309917

Re: [jclouds-labs-google] initial commit to support GCE LB (#22)

2014-09-30 Thread Andrea Turli
> + > + /** > +* Creates a ForwardingRule resource in the specified project and region > using the data included in the request. > +* > +* @param forwardingRuleName the name of the forwarding rule. > +* @param targetSelfLink the URL of the target resource to receive the > matche

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

2014-09-30 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=b183a18747d7bce8f51bc05fc70acfa2cb5edfcd). Thanks, @najtmar! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/63#issuecomment-57308421

  1   2   >