Re: [jclouds] Allow abstract value types to be constructed from json using static factory methods. (#586)

[jclouds » jclouds #1857](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1857/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Build failed in Jenkins: jclouds » jclouds #1857

See Changes: [Adrian Cole] JCLOUDS-750 Allow abstract value types to be constructed from json using static factory methods. -- [...truncated 3732 lines...] [INFO] jclouds compute core

Re: [jclouds] Allow abstract value types to be constructed from json using static factory methods. (#586)

[jclouds-pull-requests #1342](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1342/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/586#issuecomment-60507982

Re: [jclouds] Allow abstract value types to be constructed from json using static factory methods. (#586)

[jclouds-pull-requests-java-6 #253](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/253/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/586#issuecomment-60507947

Re: [jclouds] Allow abstract value types to be constructed from json using static factory methods. (#586)

cc @jdaggett @andreaturli --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/586#issuecomment-60507916

Re: [jclouds] Allow abstract value types to be constructed from json using static factory methods. (#586)

> @@ -71,23 +72,6 @@ > } > > /** > -* returns an {@link Invokable} object that reflects a constructor > present in the {@link TypeToken} type. unused, so traded this code out so that I could put a little more in. --- Reply to this email directly or view it on GitHub: https://github

[jclouds] Allow abstract value types to be constructed from json using static factory methods. (#586)

This will permit the following to work: ```java abstract class Resource { abstract String id(); abstract String type(); @Inject static Resource create(@Named("id") String id, @Named("type") type) { return new AutoValue_Resource(id, type); } } ``` Note that if we like, we could make

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184417#comment-14184417 ] Adrian Cole commented on JCLOUDS-750: - ok this should get us most of the way towards

Re: [jclouds-site] Initial strawman for the 1.8.1 release notes (#138)

Go to http://a078da31cc53787ae9c9-84efa30bcec2ace12d6bd3dec65f9975.r5.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/138#issuecomment-60505594

Re: [jclouds-site] Initial strawman for the 1.8.1 release notes (#138)

[jclouds-site-pull-requests #431](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/431/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/138#issuecomment-60505574

[jira] [Comment Edited] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184327#comment-14184327 ] Adrian Cole edited comment on JCLOUDS-750 at 10/26/14 2:35 AM:

[jira] [Comment Edited] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184327#comment-14184327 ] Adrian Cole edited comment on JCLOUDS-750 at 10/26/14 2:35 AM:

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

ok. ready to review. I'm done fiddling :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60504404

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

[jclouds » jclouds-labs-google #1555](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1555/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

[jclouds-labs-google-pull-requests #186](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/186/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60504304

Re: [jclouds-site] Initial strawman for the 1.8.1 release notes (#138)

Go to http://adda73bfd30802a06c77-7ab43419ec96fec9828dcbacd72d1deb.r35.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/138#issuecomment-60503961

Re: [jclouds-site] Initial strawman for the 1.8.1 release notes (#138)

[jclouds-site-pull-requests #430](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/430/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/138#issuecomment-60503925

Jenkins build is still unstable: jclouds » jclouds-karaf #1393

See

Re: [jclouds-karaf] Revert guava 18 (#57)

[jclouds » jclouds-karaf #1393](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/1393/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.co

Re: [jclouds-karaf] Revert guava 18 (#57)

[jclouds-karaf-pull-requests #95](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/95/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/57#issuecomment-60502445

[jira] [Commented] (JCLOUDS-664) Azure compute support

[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184333#comment-14184333 ] Adrian Cole commented on JCLOUDS-664: - [~abayer] uhh.. so I got distracted. over to y

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

[jclouds » jclouds-labs-google #1554](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1554/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Jenkins build is back to normal : jclouds » jclouds-labs-google #1554

See

Re: [jclouds-labs] Use google auto to save the day (#100)

also, since auto generates subtypes, any gson type adapters will need to be converted to type adapter factories. Ex. via subclassing this https://github.com/jclouds/jclouds-labs-google/pull/67/files#diff-18 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

[jclouds-labs-google-pull-requests #185](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/185/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60502122

[jclouds-karaf] Revert guava 18 (#57)

Missed these earlier You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-karaf adrian.rollback-guava-18 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/57 -- Commit Summary -- * Revert "JCLOUDS-65

[jira] [Comment Edited] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184327#comment-14184327 ] Adrian Cole edited comment on JCLOUDS-750 at 10/25/14 11:58 PM: ---

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184327#comment-14184327 ] Adrian Cole commented on JCLOUDS-750: - Also, if you need custom type adapters, they w

Re: [jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

ps auth is unnecessarily complex code. will fix that up after. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60500804

Re: [jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

oops.. working on this --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60500798

Re: [jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

[jclouds » jclouds-labs-google #1553](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1553/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https:

Build failed in Jenkins: jclouds » jclouds-labs-google #1553

See Changes: [Adrian Cole] JCLOUDS-750 At the cost of one trivial type adapter, remove lots of junk with google auto. -- [...truncated 312 lines...] Caused by: java.lang.R

Re: [jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

[jclouds-labs-google-pull-requests #184](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/184/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecom

Build failed in Jenkins: jclouds » jclouds-labs-google #1552

See Changes: [Adrian Cole] At the cost of one trivial type adapter, remove lots of junk with google auto. -- [...truncated 329 lines...] Caused by: java.lang.RuntimeExcept

Re: [jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

[jclouds » jclouds-labs-google #1552](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1552/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https:

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184303#comment-14184303 ] Adrian Cole commented on JCLOUDS-750: - First json impl. Note that I did have to creat

Re: [jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

[jclouds-labs-google-pull-requests #183](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/183/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/67#issuecom

[jclouds-labs-google] At the cost of one trivial type adapter, remove lots of junk with google auto (#67)

Traded 500 lines of junk for <100 line TokenAdapter. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-google adrian.decruft-oauth-with-auto Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pu

Re: [jclouds-labs] Use google auto to save the day (#100)

Ah. so it actually only propagates the method annotations. This works for jackson, but not gson, as gson @SerializedName is on fields. Now remember that if your api is consistent, all you need to do is configure the global gson to use snake case. that avoids this issue completely. ex. gsonBuilder

Jenkins build is back to normal : jclouds-labs-openstack » jclouds openstack-neutron api #518

See

Jenkins build is back to normal : jclouds-labs-openstack #518

See

Re: [jclouds-labs-openstack] Removed use of diamond operator in tests. (#165)

cherry-picked into master --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/165#issuecomment-60497822

Re: [jclouds-labs-openstack] Removed use of diamond operator in tests. (#165)

[jclouds » jclouds-labs-openstack #1906](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1906/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Jenkins build is back to normal : jclouds » jclouds-labs-openstack #1906

See

Re: [jclouds-labs-openstack] Removed use of diamond operator in tests. (#165)

[jclouds-labs-openstack-pull-requests #468](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/468/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/165#issuecomment-60497178

Jenkins build is still unstable: jclouds » jclouds-karaf #1392

See

[jclouds-labs-openstack] Removed use of diamond operator in tests. (#165)

This was the only impact of moving java language level back to 6. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-openstack adrian.fix-no-diamond Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-op

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1905

See -- [...truncated 453 lines...] [INFO] Exclude: **/src/test/resources/**/*.xml [INFO] Exclude: **/services/*LoggingModule [INFO] Exclude: **/services/*ApiMetadata [INFO] Exclu

Re: [jclouds-labs] Use google auto to save the day (#100)

irc, latest rc of auto propagates annotations like SerializedName. Give it a shot! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/100#issuecomment-60494982

Re: [jclouds-labs] Use google auto to save the day (#100)

@adriancole Have you figured out a way to map snakeycase fields like `availability_zone` to `availabilityZone`?? That is what I was stuck on in my prototyping with AutoValue. If there is a solution for this mapping, I would really like to know! --- Reply to this email directly or view it on Git

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1904

See -- [...truncated 452 lines...] [INFO] Exclude: **/src/test/resources/**/*.xml [INFO] Exclude: **/services/*LoggingModule [INFO] Exclude: **/services/*ApiMetadata [INFO] Exclu

Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)

[jclouds » jclouds #1855](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1855/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/585#issuecomme

Re: [jclouds-labs] Use google auto to save the day (#100)

picked into 1.8.x and master --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/100#issuecomment-60492858

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184209#comment-14184209 ] ASF subversion and git services commented on JCLOUDS-750: - Commit

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184210#comment-14184210 ] ASF subversion and git services commented on JCLOUDS-750: - Commit

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184206#comment-14184206 ] ASF subversion and git services commented on JCLOUDS-750: - Commit

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184207#comment-14184207 ] ASF subversion and git services commented on JCLOUDS-750: - Commit

Re: [jclouds-labs-google] Remove redundant binder implementations in GCE. (#65)

picked into master --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/65#issuecomment-60492718

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

picked into master --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60492756

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Closed #66. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/66#event-183676537

Re: [jclouds-labs-google] Remove redundant binder implementations in GCE. (#65)

Closed #65. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/65#event-183676387

Jenkins build is back to normal : jclouds-labs-google » jclouds Google Compute Engine provider #282

See

Re: [jclouds-labs] Use google auto to save the day (#100)

Interesting approach! I'd like to see it more adopted in jclouds later +1 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/100#issuecomment-60492666

Jenkins build is back to normal : jclouds-labs-google #282

See

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

merged into master. 1.8.x is a mess. hopefully we can pull this out of labs for 1.8.2 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/64#issuecomment-60492581

Build failed in Jenkins: jclouds-labs-openstack #517

See -- [...truncated 577 lines...] [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 11 licence. [INFO] [INFO] --- maven-jar-plugin:2.4:test-jar (default)

Build failed in Jenkins: jclouds-labs-openstack » jclouds openstack-neutron api #517

See -- [INFO] [INFO] --

Build failed in Jenkins: jclouds-labs-google » jclouds Google Compute Engine provider #281

See -- [INFO] [INFO] -

Build failed in Jenkins: jclouds-labs-google #281

See -- [...truncated 555 lines...] [INFO] Exclude: **/.settings/** [INFO] Exclude: **/.classpath [INFO] Exclude: **/.dir-locals.el [INFO] Exclude: **/.project [INFO] Exclude: **/.idea/** [INFO]

Build failed in Jenkins: jclouds-1.8.x-branch #47

See Changes: [Adrian Cole] Revert "JCLOUDS-652: Require JDK 7" [Adrian Cole] Revert "Remove Java 6 litter" [Adrian Cole] JCLOUDS-264 Conditionally allow default http driver to support sending >2GB payloads without chunked e

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

[jclouds » jclouds-labs-google #1547](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1547/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Jenkins build is back to normal : jclouds » jclouds-labs-google #1547

See

[jira] [Resolved] (JCLOUDS-652) Transition to Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole resolved JCLOUDS-652. - Resolution: Later Fix Version/s: (was: 2.0.0) 1.8.2 Filesystem prov

[jira] [Resolved] (JCLOUDS-264) Support >2GB payloads in a single request when running default http driver on Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole resolved JCLOUDS-264. - Resolution: Fixed Fixed. now with test. > Support >2GB payloads in a single request when running

[jira] [Commented] (JCLOUDS-652) Transition to Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184195#comment-14184195 ] ASF subversion and git services commented on JCLOUDS-652: - Commit

Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)

Closed #585. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/585#event-183672525

[jira] [Commented] (JCLOUDS-264) Support >2GB payloads in a single request when running default http driver on Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184194#comment-14184194 ] ASF subversion and git services commented on JCLOUDS-264: - Commit

[jira] [Commented] (JCLOUDS-652) Transition to Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184193#comment-14184193 ] ASF subversion and git services commented on JCLOUDS-652: - Commit

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1903

See -- [...truncated 460 lines...] [INFO] Exclude: **/src/test/resources/**/*.cmd [INFO] Exclude: **/src/test/resources/**/*.txt [INFO] Exclude: **/src/test/resources/**/*.gz [IN

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

[jclouds-labs-google-pull-requests #182](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/182/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/64#issuecomment-60491015

Build failed in Jenkins: jclouds » jclouds-labs-google #1546

See -- [...truncated 325 lines...] [INFO] Exclude: **/modernizer_exclusions.txt [INFO] Exclude: .repository/** [INFO] Exclude: gc.log [INFO] 46 resources included (use -debug for mor

Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)

[jclouds » jclouds #1854](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1854/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/585#issuecomme

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

> @@ -14,12 +14,10 @@ > * See the License for the specific language governing permissions and > * limitations under the License. > */ > -package org.jclouds.googlecomputeengine.handlers; > +package org.jclouds.googlecomputeengine.binders; nope. good catch! will fix. --- Reply to this email

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

> > public class DiskCreationBinder extends BindToJsonPayload { > > - @Inject > - public DiskCreationBinder(Json jsonBinder) { > + @Inject public DiskCreationBinder(Json jsonBinder) { less lines, explicitly states that this is an injected constructor. This is a style I've seen common in

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

lgtm, very minor comments --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/64#issuecomment-60490501

Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)

picked into master. working through conflicts on 1.8.x --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/585#issuecomment-60490505

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

> @@ -14,12 +14,10 @@ > * See the License for the specific language governing permissions and > * limitations under the License. > */ > -package org.jclouds.googlecomputeengine.handlers; > +package org.jclouds.googlecomputeengine.binders; does this need to be moved to binders? --- Reply to

Re: [jclouds-site] Initial strawman for the 1.8.1 release notes (#138)

Go to http://b1c90eabded8a2ca754d-abce231dea82c6db563d944416e4fa3b.r79.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/138#issuecomment-60490367

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

> -*/ > - @Override > - public R bindToRequest(R request, Map Object> postParams) { > - FirewallOptions options = (FirewallOptions) > checkNotNull(postParams.get("options"), "firewallOptions"); > - String name = (String) checkNotNull(postParams.get("name"), "name"); > - URI

Re: [jclouds-labs-google] Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null (#64)

> > public class DiskCreationBinder extends BindToJsonPayload { > > - @Inject > - public DiskCreationBinder(Json jsonBinder) { > + @Inject public DiskCreationBinder(Json jsonBinder) { Is this style preferable? why? --- Reply to this email directly or view it on GitHub: https://github.c

Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)

[jclouds-pull-requests #1341](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1341/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/585#issuecomment-60490343

Re: [jclouds-site] Initial strawman for the 1.8.1 release notes (#138)

[jclouds-site-pull-requests #429](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/429/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/138#issuecomment-60490331

Re: [jclouds-labs-google] Remove redundant binder implementations in GCE. (#65)

lgtm :+1: thanks for this cleanup --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/65#issuecomment-60490322

[jira] [Commented] (JCLOUDS-264) Support >2GB payloads in a single request when running default http driver on Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184177#comment-14184177 ] ASF subversion and git services commented on JCLOUDS-264: - Commit

[jira] [Commented] (JCLOUDS-264) Support >2GB payloads in a single request when running default http driver on Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184176#comment-14184176 ] ASF subversion and git services commented on JCLOUDS-264: - Commit

[jira] [Commented] (JCLOUDS-652) Transition to Java 7

[ https://issues.apache.org/jira/browse/JCLOUDS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184178#comment-14184178 ] ASF subversion and git services commented on JCLOUDS-652: - Commit

Jenkins build is back to normal : jclouds » jclouds-labs-google #1545

See

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

[jclouds » jclouds-labs-google #1545](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1545/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

[jclouds-labs-google-pull-requests #181](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/181/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60489933

Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)

[jclouds-pull-requests #1340](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1340/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/585#issuecomment-60489951

  1   2   >