[jclouds-labs-openstack-pull-requests
#476](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/476/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
[jclouds » jclouds-labs-openstack
#1946](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1946/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
changed the MetersApi.listMeters to MetersApi.list but left the QueryOptions as
is cause of a new ComplexQueryOptions for QueryApi .
changed QueryApi so it uses ComplexQueryOptions and used MapBinder to controle
the post params.
waiting for further comments
---
Reply to this email directly or
Nice cleanup. lgtm!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/81#issuecomment-61784029
Unfortunately the filter can't be applied on the API call, as the deprecated
field is a nested object, and according to the documentation for the filter
query parameter: *Only atomic field types are supported (string, number,
boolean). Array and object fields are not currently supported.*
I've
@adriancole @danbroudy Updated the PR to the latest master and making sure the
`listImages` returns a lazy iterable.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61791543
[jclouds-labs-google-pull-requests
#229](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/229/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61791611
[jclouds » jclouds-labs-google
#1636](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1636/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
See
https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1636/changes
Akos Hajnal created JCLOUDS-769:
---
Summary: Upload blob from stream
Key: JCLOUDS-769
URL: https://issues.apache.org/jira/browse/JCLOUDS-769
Project: jclouds
Issue Type: New Feature
[jclouds-labs-google-pull-requests
#230](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/230/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61806542
[jclouds » jclouds-labs-google
#1637](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1637/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Just curious. Did you run live tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61825337
Yes. The failures are the same than already existed, IIRC.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61826021
@@ -116,6 +121,8 @@
operationCompleteCheckInterval, TimeUnit.MILLISECONDS);
this.zones = zones;
this.firewallTagNamingConvention = firewallTagNamingConvention;
+ this.imageProjects = ImmutableList.copyOf(imageProjects);
kill deprecated and punt to goog for adding a filter on object ref = null
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61831552
otherwise LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61831847
@Override
public Image getImage(String id) {
- return Objects.firstNonNull(api.getImageApi(userProject.get()).get(id),
-
Objects.firstNonNull(api.getImageApi(DEBIAN_PROJECT).get(id),
-
couple live test quirks. after I fix that, will merge
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/81#issuecomment-61834396
Ok, addressed comments and removed the property as discussed on the IRC. I'll
merge it once the PR builders show they're happy.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61835650
(I've seen now, I'll amend the commit message and remove the deprecated thing
before merging)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61835778
@@ -154,7 +155,7 @@ GCSObject getObject(@PathParam(bucket) String
bucketName, @PathParam(object)
@ResponseParser(ParseToPayloadEnclosing.class)
@Fallback(NullOnNotFoundOr404.class)
@Nullable
- PayloadEnclosingImpl download(@PathParam(bucket) String bucketName,
[jclouds-labs-google-pull-requests
#231](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/231/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61835949
[jclouds » jclouds-labs-google
#1638](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1638/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-google-pull-requests
#232](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/232/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/81#issuecomment-61843009
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/79#issuecomment-61843095
[jclouds » jclouds-labs-google
#1640](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1640/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Closed #77.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#event-188806724
Merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/77#issuecomment-61845477
tests are back to normalish (still need investigation as some are simple
resource names not conforming to GCE naming constraints)
```
Failed tests:
Closed #81.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/81#event-14845
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/81#issuecomment-61866266
Adrian Cole created JCLOUDS-770:
---
Summary: Stop depending on jclouds internals like
RestAnnotationProcessor
Key: JCLOUDS-770
URL: https://issues.apache.org/jira/browse/JCLOUDS-770
Project: jclouds
Adrian Cole created JCLOUDS-771:
---
Summary: Deprecate and destroy Expect tests; use MockWebServer
instead
Key: JCLOUDS-771
URL: https://issues.apache.org/jira/browse/JCLOUDS-771
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199053#comment-14199053
]
Adrian Cole commented on JCLOUDS-770:
-
As I'm sure questions will arise.. why
[
https://issues.apache.org/jira/browse/JCLOUDS-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199055#comment-14199055
]
Adrian Cole commented on JCLOUDS-771:
-
ps expect tests are already beta, so we can
[
https://issues.apache.org/jira/browse/JCLOUDS-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Cole updated JCLOUDS-771:
Remaining Estimate: 168h
Original Estimate: 168h
Deprecate and destroy Expect tests; use
[
https://issues.apache.org/jira/browse/JCLOUDS-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Cole updated JCLOUDS-770:
Remaining Estimate: 168h
Original Estimate: 168h
Stop depending on jclouds internals like
This change adds ProviderMetadata, which allows us to properly tag locations of
zones. It also uses the built-in location features from jclouds core, which
allows you to do things like set the property jclouds.zones to constrain
locations.
Not quite ready to merge, as I need to adjust one
+ public Builder toBuilder() {
+ return builder().fromProviderMetadata(this);
+ }
+
+ public GoogleComputeEngineProviderMetadata() {
+ super(builder());
+ }
+
+ public GoogleComputeEngineProviderMetadata(Builder builder) {
+ super(builder);
+ }
+
+ private
@@ -117,11 +158,40 @@ public String apply(Credentials in) {
}, creds), seconds, TimeUnit.SECONDS);
}
+ @Provides @Singleton @Memoized SupplierListRegion
regions(@UserProject SupplierString project,
+ final GoogleComputeEngineApi api,
[jclouds-labs-google-pull-requests
#233](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/233/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/82#issuecomment-61935353
[jclouds » jclouds-labs-google
#1643](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1643/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@@ -7,8 +7,8 @@
description: us-central1,
status: UP,
zones: [
this made me question myself.. until I looked at the json from the server!
```
--snip--
status: UP,
zones: [
https://www.googleapis.com/compute/v1/projects/jclouds-dev/zones/asia-east1-a;,
@nacx fyi. I will clean this up more tomorrow morning
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/82#issuecomment-61935656
ping
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/562#issuecomment-61937124
[jclouds-labs-google-pull-requests
#234](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/234/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/82#issuecomment-61938360
[jclouds » jclouds-labs-google
#1644](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1644/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
48 matches
Mail list logo
