Just to make sure I understand: what would happen now if a user (legacy) code
has both `@Transform` and a `@ResponseParser`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/597#issuecomment-62394605
using commit-then-review on this as it is obviously a move forward, but happy
to address nits later.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/597#issuecomment-62394915
This doesn't affect existing use of `@ResponseParser`, `@SelectJson`
etc. This change only makes `@ResponseParser`optional. So, this
affects new code or existing code people want to clean up.
Basically, if someone made a boiler-plate `@ResponseParser` which just
parses json into the input type of
ps I finally found out why we need the project name, not the project id. I
added javadoc and will push soon, as this is a very important issue to document!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62400775
ps I finally found out why we need the project name, not the project id.
Ah, curious!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62402183
@inbarsto I was just about to merge this when I saw @jdaggett's comment that I
just noticed that this class is missing a field.
Do you know which field Jeremy might be talking about? I'm assuming your change
works as-is?
---
Reply to this email directly or view it on GitHub:
Alright. We now stand at 1K less lines, but with more documentation and tests
than we had prior.
PTAL
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62407869
* @param listOptions listing options
* @return a page of the list
*/
@Named(GlobalOperations:list)
@GET
- @Path(/projects/{project}/global/operations)
@demobox @nacx look ma.. no more annotation party!
---
Reply to this email directly or view it on GitHub:
The change works as is. I believe I do. I would rather this to be merged as is
because this or is open for a long time now and I have no use for the second
field. I have no problem adding the other field in a second PR if we agree it
is better with the second field as well
---
Reply to
[jclouds-labs-google-pull-requests
#272](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/272/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62408259
[
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204945#comment-14204945
]
Adrian Cole commented on JCLOUDS-172:
-
One thing I've noticed is that we copy-paste
[jclouds » jclouds-labs-google
#1690](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1690/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
I agree. Fields are easy to add hard to remove. Add what you need!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/562#issuecomment-62410166
Basically, if someone made a boiler-plate `@ResponseParser` which just parses
json into the input
type of the `@Transform` function, they can now remove the `@ResponseParser`
annotation and the
boilerplate class.
Cool. +1, looks good to me in that case!
---
Reply to this email directly
+1 @adriancole I missed where/what the default project name is set. I assume
it is empty but I couldn't find it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62417142
@Override protected void bindErrorHandlers() {
bind(HttpErrorHandler.class).annotatedWith(Redirection.class).to(GoogleComputeEngineErrorHandler.class);
bind(HttpErrorHandler.class).annotatedWith(ClientError.class).to(GoogleComputeEngineErrorHandler.class);
- compose(new FunctionCredentials, String() {
- public String apply(Credentials in) {
-// ID should be of the form
project...@developer.gserviceaccount.com
-// OR (increasingly often)
@ccustine thanks for having a look! merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62419100
I'll address this after reworking oauth annotations.. I think.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62419227
I suppose this big refactoring doesn't fit onto 1.8.x, will it be backported to
1.9.x?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62421648
When we are ready, 1.9.x will be cut from master, so yeah will be in 1.9.0.
1.8.x is dead as was discussed on mailing list.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62424166
Merged (finally!) to
[1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=dedeb63b0fc280e0653e63ab678505d45feea51c).
Please check out the commit.
Does this also need to go to master?
---
Reply to this email directly or view it on GitHub:
@adriancole Feel free to take this on. Any help is much appreciated! l7 load
balancing is something we would be keen to have in an 1.9 branch cut. If this
is a high enough priority for you to make moves on it soon then please do! If
not feel free to send it my way. Please let me know either
[
https://issues.apache.org/jira/browse/JCLOUDS-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Everett Toews closed JCLOUDS-446.
-
Resolution: Fixed
Script doesn't run
---
Key: JCLOUDS-446
[
https://issues.apache.org/jira/browse/JCLOUDS-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Everett Toews reassigned JCLOUDS-446:
-
Assignee: Everett Toews
Script doesn't run
---
Thank you. Yeah it need to go to master. Would u like me to create a new PR for
it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/562#issuecomment-62475042
Converts AttachDiskOptions to AutoValue.
@adriancole does it make sense for AttachDiskOptions to be done with AutoValue?
I'm still trying to get used to it.
Also I'm trying to understand the interplay of NewInstance.Disk,
AttachDiskOptions, and Instance.AttachedDisk. They seem redundant and
@@ -85,7 +87,8 @@ public boolean apply(Image input) {
INSTANCE_NAME, // name
getDefaultMachineTypeUrl(), // machineType
getNetworkUrl(INSTANCE_NETWORK_NAME), // network
-Arrays.asList(Disk.newBootDisk(imageUri),
[jclouds-labs-google-pull-requests
#273](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/273/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/89#issuecomment-62494213
@@ -278,5 +278,21 @@ Operation setTags(@PathParam(instance) String instance,
};
}
}
+
+ /**
+* Sets the auto-delete flag for a disk attached to an instance
+*
+* @param instanceName The name of the instance
+* @param autoDelete Whether to
@@ -278,5 +278,21 @@ Operation setTags(@PathParam(instance) String instance,
};
}
}
+
+ /**
+* Sets the auto-delete flag for a disk attached to an instance
+*
+* @param instanceName The name of the instance
+* @param autoDelete Whether to
[jclouds » jclouds-labs-google
#1692](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1692/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@@ -418,4 +417,45 @@ public void testDetachDiskResponseIs4xx() {
api.detachDisk(test-1, test-disk-1);
}
+ public void testSetDiskAutoDeleteResponseIs2xx() {
do me a favor. just start a new mock class and add this there. It is a lot of
work to convert the existing tests to
[
https://issues.apache.org/jira/browse/JCLOUDS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205869#comment-14205869
]
Adrian Cole commented on JCLOUDS-752:
-
more potential rules.
1. factory method
@@ -85,7 +87,8 @@ public boolean apply(Image input) {
INSTANCE_NAME, // name
getDefaultMachineTypeUrl(), // machineType
getNetworkUrl(INSTANCE_NETWORK_NAME), // network
-Arrays.asList(Disk.newBootDisk(imageUri),
Thanks for asking the question. I've not reviewed the Options classes, yet, and
I think you've identified a nice place to clean things up. Lemme know if my
suggestion is from left field.
---
Reply to this email directly or view it on GitHub:
Actually I think you'll get more miles by us splitting work. There's a lot
left to do in oauth and google storage. If we can get all these working, we
can move out the whole repo in 1.9. In other words... all yours!
---
Reply to this email directly or view it on GitHub:
37 matches
Mail list logo
