Build failed in Jenkins: jclouds » jclouds #1977

See Changes: [will.chu] JCLOUDS-788 Added new method to support the passing of a custom node name when generating the chef bootstrap node script [will.chu] JCLOUDS-788 Left out another new method needed for supporting the c

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

[jclouds » jclouds #1977](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1977/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

[jclouds » jclouds #1976](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1976/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/621#issuecomme

Re: [jclouds-labs-google] Added targetPool:AggregatedList, getHealth. Updated HttpHealthCheck (#105)

I am looking into HttpHealthCheck changes, will reopen when ready --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/105#issuecomment-65340399

Re: [jclouds-labs-google] Added targetPool:AggregatedList, getHealth. Updated HttpHealthCheck (#105)

Closed #105. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/105#event-201682385

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

[jclouds » jclouds #1975](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1975/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/622#issuecomme

Jenkins build is back to normal : jclouds » jclouds-karaf #1466

See

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

Ok, please review at your convenience and let me know if you see anything else --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/622#issuecomment-65331605

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

> @@ -85,12 +85,19 @@ protected static MockWebServer mockWebServer(Dispatcher > dispatcher) throws IOExc > * Creates a test api for the given class and URL. > */ > protected T api(Class apiClass, String url) { > + return api(apiClass, url, createConnectionModule()); > + } > +

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

[jclouds » jclouds #1974](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1974/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/622#issuecomme

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

Thanks for the quick review! Closing until I address all concerns --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/622#issuecomment-65327548

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

Thanks for the patch @will-districtnerds! I've had a quick look and left a couple comments. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/622#issuecomment-65327433

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

> @@ -175,6 +175,10 @@ public Statement createBootstrapScriptForGroup(String > group) { >return groupToBootScript.apply(group); > } > > + public Statement createBootstrapScriptForGroupAndNodeName(String group, > String nodeName) { > + return groupToBootScript.apply(group, nod

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

> @@ -175,6 +175,10 @@ public Statement createBootstrapScriptForGroup(String > group) { >return groupToBootScript.apply(group); Call `createBootstrapScriptForGroupAndNodeName(group, null)` once the `GroupToBootScript` function is changed. --- Reply to this email directly or view it on G

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

> @@ -127,4 +127,45 @@ public Statement apply(String group) { > createFirstBoot, runChef); > } > > +public Statement apply(String group, String nodeName) { Instead of providing a new function with most of the code duplicated, I'd simply add the `nodeName` parameter, annotat

Re: [jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

> @@ -175,6 +175,10 @@ public Statement createBootstrapScriptForGroup(String > group) { >return groupToBootScript.apply(group); > } > > + public Statement createBootstrapScriptForGroupAndNodeName(String group, > String nodeName) { Add `@Override` annotation. --- Reply to this em

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Go to http://a8dc64fb01de45b0bb75-3a0d5a1aa1e2206f027875458ce3c576.r42.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65325026

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Added a commit to test the web hook based trigger, and it seems to work like a charm :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65324781

[jira] [Commented] (JCLOUDS-788) Add support for custom node names

[ https://issues.apache.org/jira/browse/JCLOUDS-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232280#comment-14232280 ] William Chu commented on JCLOUDS-788: - I've got a proposed patch in https://github.co

[jclouds] JCLOUDS-788 Added new method to support the passing of a custom node nam... (#622)

...e when generating the chef bootstrap node script You can merge this Pull Request by running: git pull https://github.com/bertramdev/jclouds master Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/622 -- Commit Summary -- * JCLOUDS-788 Adde

Re: [jclouds-labs-google] Added targetPool:AggregatedList, getHealth. Updated HttpHealthCheck (#105)

[jclouds » jclouds-labs-google #1819](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1819/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

[jclouds-labs-google] Added targetPool:AggregatedList, getHealth. Updated HttpHealthCheck (#105)

This adds coverage of TargetPoolApi:AggregatedList and TargetPoolApi:GetHealth. Also updates HttpHealthChecks. Defaults were not being set in HttpHealthChecks. This was hidden by the fact that we assumed default values when nothing was returned in the request. This PR addresses this and changes

[jira] [Assigned] (JCLOUDS-788) Add support for custom node names

[ https://issues.apache.org/jira/browse/JCLOUDS-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-788: -- Assignee: Ignasi Barrera > Add support for custom node names > ---

Build failed in Jenkins: jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #7

See -- [...truncated 12515 lines...] [INFO] jclouds filesystem core ... SKIPPED [INFO] jclouds apis project .

Build failed in Jenkins: jclouds-labs » Apache jclouds labs #684

See -- [...truncated 1575 lines...] Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/velocity/velocity/1.6.2/velocity-1.6.2.pom Down

Build failed in Jenkins: jclouds-labs #684

See -- [...truncated 1718 lines...] Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/velocity/velocity/1.5/velocity-1.5.jar Downloading: https://repository-jclouds.forge

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

Oh, sorry, I misunderstood. I think it is OK as-is now, in the dependencyManagement section. We don't want to add dependencies for projects that don't need them. I agree that it only is used at runtime, but at some gras it may slow down the builds. I'd rather keep it as-is in the pom.xml files

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

>I previously asked if we should pull the dependency up into >jclouds-project/pom.xml, and I still think its the right thing to do. WDYT? +1. That will also help getting this applied to all providers. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

@nacx @demobox +1 The intent of this specific PR was the Rackspace/OpenStack code and that was my mindset at that particular time. That said, I have most of the other APIs/Providers converted already, so l was planning to update this PR with those changes. Since the `auto-service` dependency i

[jira] [Created] (JCLOUDS-788) Add support for custom node names

William Chu created JCLOUDS-788: --- Summary: Add support for custom node names Key: JCLOUDS-788 URL: https://issues.apache.org/jira/browse/JCLOUDS-788 Project: jclouds Issue Type: Improvement

Re: [jclouds-site] Testing GitHub PR status integration (#147)

> you can see now how it properly reports the build status and shows which > commits worked. Looks > neat! Indeed! I'll try to have a go at setting up that hook later... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65310828

Re: [jclouds-site] Testing GitHub PR status integration (#147)

@demobox you can see now how it properly reports the build status and shows which commits worked. Looks neat! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65309528

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Yes! That is in yellow when the build is in progress and a message says so. In red if the build fails, and in green when it succeeds. In the commit tab of the PR you'll also see which commits work and which don't. In case the build status changed after adding some commits. And if you go to the lo

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Ahh...it's this bit?  --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65308480

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Go to http://74cf268a67e02804af25-819f16709c51e324cc223fc90626dd1a.r10.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65308181

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Not by default, but we can configure it to leave a comment when the build is OK or failed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65308237

Re: [jclouds-site] Testing GitHub PR status integration (#147)

@nacx Does the PR builder leave any comments? Not seeing anything...perhaps I'm missing something obvious..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65308026

Re: [jclouds-site] Testing GitHub PR status integration (#147)

rebuild please --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65307598

Re: [jclouds-site] Testing GitHub PR status integration (#147)

Go to http://d0b0ed33aca0c9639f72-c16d211daadf4589471925d24720cf63.r95.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/147#issuecomment-65307499

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

> We want to make sure that we fix things in jclouds instead of fixing things > only here and there. Excellent point, @nacx...+1 to that. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/621#issuecomment-65301893

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

Thanks @jdaggett! IMO this is only a partial work. If you're doing a change in the jclouds repo, why not addressing the change in all providers, not just the OpenStack ones? Could you please add the rest of the providers to this PR? We want to make sure that *we fix things in jclouds* instead o

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

> Should we make it optional across the board? If that's what the example in the docs say, I'd say go with that..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/621#issuecomment-65291071

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/619#issuecomment-65290826

Build failed in Jenkins: jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #6

See -- [...truncated 34986 lines...] [INFO] Exclude: **/CONTRIBUTING.md [INFO] Exclude: **/*json [INFO] Exclude: **/*readme [INFO] Exclude: **/test [

Build failed in Jenkins: jclouds-labs » Apache jclouds labs #683

See -- [...truncated 2521 lines...] [INFO] artifact net.schmizz:sshj: checking for updates from cloudbees-private-release-repository [INFO] artifact net.schmizz:s

Build failed in Jenkins: jclouds-labs #683

See -- [...truncated 2671 lines...] Downloading: http://repo.cloudbees.com/content/repositories/central/org/apache/commons/commons-parent/20/commons-parent-20.pom Downloaded: http://repo.cloudbees.co

Re: [jclouds] Use AutoService for creation of Service Loader Metadata (#621)

@demobox The simplified OSGi import was pointed out to me in a previous PR, so I have been applying it as I go. @ccustine Can you comment on the `import`? Yes, the `provided` scope is similar to `compile` for the transitive deps. The library is only used for the creation of the metadata at compi

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

Big +1 Thanks @nacx I'll test it asap with Docker! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/619#issuecomment-65272200

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

Squashed and pushed to master as [958d09e](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commitdiff;h=958d09ecbd2956f6cedfadfa2c67040c386bd105). Thanks for the reviews and feedback! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/619#issuec

[jira] [Commented] (JCLOUDS-753) Investigate HttpCommandExecutorService(s) with regards to POODLE

[ https://issues.apache.org/jira/browse/JCLOUDS-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231791#comment-14231791 ] ASF subversion and git services commented on JCLOUDS-753: - Commit

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

[jclouds » jclouds #1972](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1972/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/619#issuecomme

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

That makes sense. I'll change the PR to use the supplier approach and fix the javadocs. If someone want to use this feature for anything else, PRs are welcome :) Thanks for your feedback @adriancole. It is very much appreciated! --- Reply to this email directly or view it on GitHub: https://git

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

Again, my suggestion is to limit this to api config, not general purpose settings such as timeouts, and also to not document this as a "user" feature rather an internal hook for api writing. It gets complicated otherwise, as you've mentioned, and the primary goal is to address tls settings for doc

[jclouds-site] Testing GitHub PR status integration (#147)

Do not merge. You can merge this Pull Request by running: git pull https://github.com/nacx/jclouds-site build-test Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/147 -- Commit Summary -- * testing GitHub PR status integration -- File

Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)

I thought about where to hook the user config and chose to put it at the end, to make sure it won't be changes by jclouds. This will also help changing and improving the driver without worrying about breaking user customizations. I like the supplier approach, but there are properties, such as ti