retest this please
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/625#issuecomment-66586219
rebuild please
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/625#issuecomment-66611674
[
https://issues.apache.org/jira/browse/JCLOUDS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242652#comment-14242652
]
Taylor Jones commented on JCLOUDS-655:
--
Awesome, thank you for the unit test! I went
First time committing to jclouds, let me know if there are any style guidelines
I missed with this change.
You can merge this Pull Request by running:
git pull https://github.com/monitorjbl/jclouds JCLOUDS-655
Or you can view, comment on it, or merge it online at:
Looks like Jenkins had a failure of some sort, the build appears to have passed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-66639477
+
+try {
+ NovaApi novaApi = api(server.getUrl(/).toString(), openstack-nova);
+ ImageApi imageApi = novaApi.getImageApiForZone(RegionOne);
+
+ FluentIterable? extends Image images =
imageApi.listInDetail().concat();
+
+ Image img = images.get(0);
+
It seems that the commit introduced a couple checkstyle violations. Mind fixing
them?
https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1462/org.apache.jclouds.api$openstack-nova/violations/
---
Reply to this email directly or view it on GitHub:
Wow, that's a cool Jenkins plugin! I'll get those fixed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-66658827
Whoops, forgot the newline in `ImageApiMockTest`. I'll wait to see if there are
any other violations and fix it shortly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-0469
+
+ assertEquals(network.getId(), net.getId());
+ assertEquals(network.getName(), jclouds-test);
+ assertTrue(network.getSubnets().isEmpty());
+ assertNotNull(networkApi.update(net.getId(),
Network.updateBuilder().name(jclouds-live-test).build()));
+
+
@nacx @zack-shoylev I completely agree that we should fix things as we find
them. However, IMHO, I think we should step back and address any Neutron test
cleanup first and then the providers in separate PRs. I just updated the logger
files for now. Thoughts?
---
Reply to this email directly or
All set!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-66674319
Initial commit for shipyard provider. My intent was to have the entire provider
coded and in something like good working shape before I submitted a PR but
@nacx strongly suggested I not do this.
This code base is a fork of the work @andreaturli is doing with docker so there
may be more than a
Thanks @cdancy! And thanks for submitting the PR before having the entire
provider :)
I'd like to suggest, though, that you reduce the scope of the PR. If you have a
look at other similar pull requests ([Orion
BlobStore](https://github.com/jclouds/jclouds-labs/pull/45),
@@ -267,7 +267,7 @@ public Resource getServer() {
return this.server;
}
- public MapString, String getMetadata() {
+ public MapString, Object getMetadata() {
So this is the killer part of this problem. This change is backwards
incompatible. If someone has
MapString,
Closed #625.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/625#event-206492315
Built locally and everything went OK. Merged to 1.7.x and will cherry-pick to
1.8.x and master.
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/625#issuecomment-66705566
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-1.7.x-branch/67/
--
[...truncated 2468 lines...]
[ERROR] central (http://repo.cloudbees.com/content/repositories/central,
releases=true, snapshots=false),
[ERROR]
See
https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-1.7.x-branch/org.apache.jclouds.labs$jclouds-labs-google/113/
--
[...truncated 1991 lines...]
[WARNING] The following dependencies could not be resolved at this point of the
build but seem to be
See
https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-1.7.x-branch/org.apache.jclouds.labs$jclouds-labs-aws/67/
--
[...truncated 2122 lines...]
Downloading:
[
https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243705#comment-14243705
]
Bhathiya Supun commented on JCLOUDS-664:
[~adriancole],[~abayer]
I will be
21 matches
Mail list logo
