I've been doing some tests and will continue this week, but here's what I'd do
to focus on the authentication issues and fix the *real* problems:
We should try to make this small code snippet work "out of the box":
```java
ComputeServiceContext ctx = ContextBuilder.newBuilder("google-compute-eng
> + .defaultProperties(ProfitBricksApiMetadata.defaultProperties())
> + .defaultModules(ImmutableSet. Module>>of(ProfitBricksHttpApiModule.class));
> + }
> +
> + @Override
> + public ProfitBricksApiMetadata build() {
> + return new ProfitBricksApiMetada
Absolutely. It makes more sense to extract that metadata in a specific object,
as it shouldn't be an "arbitrary" map of values. @everett-toews are you ok with
this approach?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-67786490
I think that makes a lot of sense, but a formal definition type might be better
if you go that route though. A `BlockDeviceMapping` object would be a lot
cleaner than a simple `Map`.
Either way, I think I'll wait for a decision from you before I update the PR
any further.
---
Reply to this e
@nacx Any chance to give your thoughts on that?
FYI I've been also experimenting with the latest boot2docker available which
runs docker 1.4.1 and docker API v1.16 and the code needs only a minor
adjustment for Info class as that version is returning a richer object. Other
than that, the other
> @@ -68,7 +68,7 @@ private void checkOSImage(OSImage OSImage) {
> "MediaLink should be an http(s) url" + OSImage);
>}
>
> - assertTrue(locations.containsAll(OSImage.locations()), "Locations not
> in " + locations + " :" + OSImage);
> +assertTrue(locations.co
> + //openSUSE 13.1 -> 13.1
> + if (label.toUpperCase().contains("OPENSUSE"))
> + return label.replace("openSUSE ", "");
> + //SUSE Linux Enterprise Server 11 SP3 (Premium Image) ->
> 11 SP3(Premium Image)
> + else if (lab
>
> public class OSImageToImage implements Function {
> + private static final String UNRECOGNIZED = "UNRECOGNIZED";
> + private final JustProvider provider;
> +
> + @Inject
> + public OSImageToImage(JustProvider provider) {
not sure we will need this parameter here, as we'd probably us
> +.status(Image.Status.AVAILABLE)
> +.uri(image.mediaLink())
> +.providerId(image.publisherName())
> +.location(createLocation(image.location()));
> +
> + OperatingSystem.Builder osBuilder = setOperatingSystem(image);
> + return builder.ope
> +.id(image.label())
> +.name(image.name())
> +.description(image.description())
> +.status(Image.Status.AVAILABLE)
> +.uri(image.mediaLink())
> +.providerId(image.publisherName())
> +.location(createLocation(image
> + .description(image.description());
> + }
> + return
> OperatingSystem.builder().family(OsFamily.LINUX).version(version).description(image.description());
> + }
> +
> + private Location createLocation(String input) {
> + return new
> LocationBuilder().id(input)
11 matches
Mail list logo