Re: [jclouds-labs-google] dabbleing with fixes, still broken (#116)

2014-12-21 Thread Ignasi Barrera
I've been doing some tests and will continue this week, but here's what I'd do to focus on the authentication issues and fix the *real* problems: We should try to make this small code snippet work "out of the box": ```java ComputeServiceContext ctx = ContextBuilder.newBuilder("google-compute-eng

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-12-21 Thread Ignasi Barrera
> + .defaultProperties(ProfitBricksApiMetadata.defaultProperties()) > + .defaultModules(ImmutableSet. Module>>of(ProfitBricksHttpApiModule.class)); > + } > + > + @Override > + public ProfitBricksApiMetadata build() { > + return new ProfitBricksApiMetada

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2014-12-21 Thread Ignasi Barrera
Absolutely. It makes more sense to extract that metadata in a specific object, as it shouldn't be an "arbitrary" map of values. @everett-toews are you ok with this approach? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/626#issuecomment-67786490

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2014-12-21 Thread monitorjbl
I think that makes a lot of sense, but a formal definition type might be better if you go that route though. A `BlockDeviceMapping` object would be a lot cleaner than a simple `Map`. Either way, I think I'll wait for a decision from you before I update the PR any further. --- Reply to this e

Re: [jclouds-labs] support for docker 1.3.2 (#113)

2014-12-21 Thread Andrea Turli
@nacx Any chance to give your thoughts on that? FYI I've been also experimenting with the latest boot2docker available which runs docker 1.4.1 and docker API v1.16 and the code needs only a minor adjustment for Info class as that version is returning a richer object. Other than that, the other

Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)

2014-12-21 Thread Andrea Turli
> @@ -68,7 +68,7 @@ private void checkOSImage(OSImage OSImage) { > "MediaLink should be an http(s) url" + OSImage); >} > > - assertTrue(locations.containsAll(OSImage.locations()), "Locations not > in " + locations + " :" + OSImage); > +assertTrue(locations.co

Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)

2014-12-21 Thread Andrea Turli
> + //openSUSE 13.1 -> 13.1 > + if (label.toUpperCase().contains("OPENSUSE")) > + return label.replace("openSUSE ", ""); > + //SUSE Linux Enterprise Server 11 SP3 (Premium Image) -> > 11 SP3(Premium Image) > + else if (lab

Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)

2014-12-21 Thread Andrea Turli
> > public class OSImageToImage implements Function { > + private static final String UNRECOGNIZED = "UNRECOGNIZED"; > + private final JustProvider provider; > + > + @Inject > + public OSImageToImage(JustProvider provider) { not sure we will need this parameter here, as we'd probably us

Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)

2014-12-21 Thread Andrea Turli
> +.status(Image.Status.AVAILABLE) > +.uri(image.mediaLink()) > +.providerId(image.publisherName()) > +.location(createLocation(image.location())); > + > + OperatingSystem.Builder osBuilder = setOperatingSystem(image); > + return builder.ope

Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)

2014-12-21 Thread Andrea Turli
> +.id(image.label()) > +.name(image.name()) > +.description(image.description()) > +.status(Image.Status.AVAILABLE) > +.uri(image.mediaLink()) > +.providerId(image.publisherName()) > +.location(createLocation(image

Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)

2014-12-21 Thread Andrea Turli
> + .description(image.description()); > + } > + return > OperatingSystem.builder().family(OsFamily.LINUX).version(version).description(image.description()); > + } > + > + private Location createLocation(String input) { > + return new > LocationBuilder().id(input)