[jira] [Commented] (JCLOUDS-801) AWS S3 Multipart upload does not work with InputStream payload

[ https://issues.apache.org/jira/browse/JCLOUDS-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278263#comment-14278263 ] Richard Nichols commented on JCLOUDS-801: - Thank you for fixing this - the patch

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> @@ -56,6 +56,8 @@ protected BaseProfitBricksRequestBinder(String paramName) { > protected abstract String createPayload(T payload); > > protected String formatIfNotEmpty(String pattern, Object param) { > + if (param == null ) > + return ""; >return Strings.isNullOrE

[jclouds] Add Rackspace CDN service type (#647)

This PR adds the Early Access Rackspace CDN service `rax:cdn` to the known service types that can be returned in the Cloud Identity Service Catalog. For additional info on the CDN service, please refer to the [docs](http://docs.rackspace.com/cdn/api/v1.0/cdn-devguide/content/Overview.html). You

[jclouds] Update AutoValue to version 1.0 (#646)

AutoValue was [updated](https://github.com/google/auto/commit/c36dbb535c905fb2cdbfa2755f25241d90dbd9c4) to version 1.0 recently! This PR is pretty self-explainatory :smile: **NOTE:** Downstream repositories broke when making this change initially. I submitted [PR 122](https://github.com/jclou

[jclouds-labs] Split Auto dependencies (#122)

Splitting the auto-service and auto-value dependencies allows us to control individual versions of these libraries. You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs split-auto-dependencies Or you can view, comment on it, or merge it online at:

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> +import org.jclouds.rest.annotations.XMLResponseParser; > + > +@RequestFilters({BasicAuthentication.class, > ProfitBricksSoapMessageEnvelope.class}) > +@Consumes(MediaType.TEXT_XML) > +@Produces(MediaType.TEXT_XML) > +public interface ImageApi { > + > + /** > +* @return Outputs a list of a

[jclouds-labs-google] Split Auto dependencies (#123)

Splitting the `auto-service` and `auto-value` dependencies allows us to control individual versions of these libraries. You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-google split-auto-dependencies Or you can view, comment on it, or merge it on

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> + > + public abstract boolean isCpuHotPlug(); > + > + public abstract boolean isCpuHotUnPlug(); > + > + public abstract boolean isRamHotPlug(); > + > + public abstract boolean isRamHotUnPlug(); > + > + public abstract boolean isNicHotPlug(); > + > + public abstract boolean isNicHotUnP

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> +import org.jclouds.rest.annotations.Payload; > +import org.jclouds.rest.annotations.PayloadParam; > +import org.jclouds.rest.annotations.RequestFilters; > +import org.jclouds.rest.annotations.XMLResponseParser; > + > +@RequestFilters( { BasicAuthentication.class, > ProfitBricksSoapMessageEnvelo

Re: [jclouds-labs-openstack] Add support for Rackspace Cloud Networks UK (#174)

@nacx @zack-shoylev Thanks! Pushed to **master** e934350 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/174#issuecomment-70009224

Re: [jclouds-labs-openstack] Add support for Rackspace Cloud Networks UK (#174)

Closed #174. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/174#event-219094749

Re: [jclouds] Update okhttp to version 2.2.0 (#641)

Closed #641. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/641#event-219094157

Re: [jclouds-labs-google] Make deleteObject() return false on 404 response (#122)

> @@ -199,7 +198,7 @@ GoogleCloudStorageObject > simpleUpload(@PathParam("bucket") String bucketName, @H > @Named("Object:delete") > @DELETE > @Path("storage/v1/b/{bucket}/o/{object}") > - @Fallback(TrueOnNotFoundOr404.class) > + @Fallback(FalseOnNotFoundOr404.class) Which test ex

Re: [jclouds] Update okhttp to version 2.2.0 (#641)

@nacx Thanks for the clarification! Pushed to **master** e09b615 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/641#issuecomment-70009026

Re: [jclouds] Update okhttp to version 2.2.0 (#641)

Nope. 1.8.x still uses OkHttp 1.6.0 and we'd better not upgrade libraries in bug fix versions. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/641#issuecomment-70008782

[jclouds-labs-google] Make deleteObject() return false on 404 response (#122)

You can merge this Pull Request by running: git pull https://github.com/snotling/jclouds-labs-google patch-2 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/122 -- Commit Summary -- * Make deleteObject() return false on 404 resp

Re: [jclouds] Update okhttp to version 2.2.0 (#641)

@nacx Yes, the downstream repos will inherit this value. Do we need to update the 1.8.x branch with this commit? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/641#issuecomment-70006489

Build failed in Jenkins: jclouds-labs-google #385

See -- [...truncated 1793 lines...] Downloading: http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.4/doxia-site-renderer-1.4.jar Downloaded: h

Build failed in Jenkins: jclouds-labs-google » Apache jclouds labs google #385

See -- [...truncated 1664 lines...] Downloading: https://repository-jclouds.forge.cloudbees.com/release/commons-chain/commons-chain/1.1/commons-chai

Re: [jclouds-labs-openstack] Add support for Rackspace Cloud Networks UK (#174)

Alright, +1 from me too. Is there a list in jira for all the 1.9.0 items? There was more than one email with TODOs on the mailing list... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/174#issuecomment-69998596

Re: [jclouds-labs-openstack] Add support for Rackspace Cloud Networks UK (#174)

+1. We've commented the data provider approach on IRC and it is definitely a cleaner one and worth implementing, but out of the scope of this PR. I'm ok of addressing that in another PR now that we have a specific issue for that. Let's make it part of the list of things TBD for 1.9.0. --- Reply

Re: [jclouds-labs-openstack] Add support for Rackspace Cloud Networks UK (#174)

My suggestion would be to fix the remaining review comments (except cleanup-related) then merge, then work on refactoring the tests according to jclouds-803 and make a separate PR. I should be able to help with that. --- Reply to this email directly or view it on GitHub: https://github.com/jclou

Re: [jclouds] Fixes the exponential backoff for a value of 0 (#644)

Oh, got it. In that case, the fix should be enforcing a 0 value is never used. I'd change this to validate the value with a `checkArgument`, and fail if it is 0 (and add the corresponding test). There are other mechanisms to disable the `BackoffLimitedRetryHandler`. Apis can just override the

[jira] [Resolved] (JCLOUDS-710) OpenStack Keystone should use Guava MediaType

[ https://issues.apache.org/jira/browse/JCLOUDS-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-710. Resolution: Invalid This Keystone MediaType class is a value object and should not use the

[jira] [Updated] (JCLOUDS-718) Compute TemplateOptions.getGroups() is ambigous

[ https://issues.apache.org/jira/browse/JCLOUDS-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-718: --- Assignee: (was: Jeremy Daggett) > Compute TemplateOptions.getGroups() is ambigous > -

[jira] [Resolved] (JCLOUDS-731) Support Nova Block Device Mapping v2

[ https://issues.apache.org/jira/browse/JCLOUDS-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-731. Resolution: Implemented Fix Version/s: 1.8.2 2.0.0 https://github

[jira] [Updated] (JCLOUDS-640) Add InfoApi to openstack-swift

[ https://issues.apache.org/jira/browse/JCLOUDS-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-640: --- Assignee: (was: Jeremy Daggett) > Add InfoApi to openstack-swift > --

[jira] [Updated] (JCLOUDS-634) Support Swift Account ACLs

[ https://issues.apache.org/jira/browse/JCLOUDS-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-634: --- Assignee: (was: Jeremy Daggett) > Support Swift Account ACLs > --

[jira] [Updated] (JCLOUDS-514) Need to be able to attach block volumes at instance creation in Nova

[ https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-514: --- Assignee: (was: Jeremy Daggett) > Need to be able to attach block volumes at instance cre

[jira] [Updated] (JCLOUDS-280) Missing create Bootable Volume with Cinder

[ https://issues.apache.org/jira/browse/JCLOUDS-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-280: --- Assignee: (was: Jeremy Daggett) > Missing create Bootable Volume with Cinder > --

Re: [jclouds] Add @Nullable attribute to BlobStore methods (#645)

:+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/645#issuecomment-69979089

[jira] [Updated] (JCLOUDS-530) Support OpenStack Swift Container Access Control Lists

[ https://issues.apache.org/jira/browse/JCLOUDS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-530: --- Assignee: (was: Jeremy Daggett) > Support OpenStack Swift Container Access Control Lists

[jira] [Updated] (JCLOUDS-239) Add an Extension to compute for disks/volumes

[ https://issues.apache.org/jira/browse/JCLOUDS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-239: --- Assignee: (was: Jeremy Daggett) > Add an Extension to compute for disks/volumes > ---

Re: [jclouds] Add @Nullable attribute to BlobStore methods (#645)

Theoretically FindBugs consumes these attributes and can prevent NullPointerExceptions although it seems to prefer the `@CheckForNull` annotation. The `putbBlob` methods may benefit from this as well although I am not familiar with any object store returning `null` ETags. @kahing relevant to y

[jclouds] Add @Nullable attribute to BlobStore methods (#645)

blobMetadata and getBlob return null when a blob does not exist and callers should check for this. You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds blobstore-nullable Or you can view, comment on it, or merge it online at: https://github.com/jclouds/j

Re: [jclouds-labs-openstack] Add support for Rackspace Cloud Networks UK (#174)

@nacx @zack-shoylev Refactoring these tests is going to take a lot more work than anticipated. I just submitted [JCLOUDS-803](https://issues.apache.org/jira/browse/JCLOUDS-803) to track the issue. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-ope

[jira] [Created] (JCLOUDS-803) Refactor OpenStack Live Tests

Jeremy Daggett created JCLOUDS-803: -- Summary: Refactor OpenStack Live Tests Key: JCLOUDS-803 URL: https://issues.apache.org/jira/browse/JCLOUDS-803 Project: jclouds Issue Type: Improvement

Re: [jclouds] Fixes the exponential backoff for a value of 0 (#644)

Well I really wanted to make sure there are no issues with the idea behind this PR first - I think it makes sense, but also setting this value to 0 eliminates the retry wait for this backoff. If we are ok with allowing 0, then I can just finish this PR. The alternative would be to disallow it, b

Jenkins build is back to stable : jclouds-labs #713

See

Jenkins build is back to stable : jclouds-labs » jclouds docker API #713

See

Jenkins build is back to normal : jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #35

See

Jenkins build became unstable: jclouds-labs » jclouds docker API #712

See

Jenkins build became unstable: jclouds-labs #712

See

[jclouds-labs] fix docker unit tests (#121)

You can merge this Pull Request by running: git pull https://github.com/andreaturli/jclouds-labs docker-fix-test Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/121 -- Commit Summary -- * fix docker unit tests -- File Changes --

Re: [jclouds-labs] support docker 1.4.1 (API v1.16) (#120)

+1 Once the build is green. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/120#issuecomment-69941404

[jclouds-labs] support docker 1.4.1 (API v1.16) (#120)

You can merge this Pull Request by running: git pull https://github.com/andreaturli/jclouds-labs docker-1.4.1 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/120 -- Commit Summary -- * support docker 1.4.1 (API v1.16) -- File Changes

Re: [jclouds-labs] support for docker 1.3.2 (#113)

Closed #113. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/113#event-218832236

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

Thanks! Most comments are minors. Given [this comment](https://github.com/jclouds/jclouds-labs/pull/119#discussion_r22944097), though, I realized that the mock tests are not verifying that the requests we generate have the expected body. This passed unnoticed in the previous review, but we shou

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> + try { > + Image image = api.getImage(id); > + assertRequestHasCommonProperties(server.takeRequest()); > + assertNotNull(image); > + assertEquals(image.id(), id); > + } finally { > + pbApi.close(); > + server.shutdown(); > + } > + >

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> +import org.jclouds.rest.annotations.XMLResponseParser; > + > +@RequestFilters({BasicAuthentication.class, > ProfitBricksSoapMessageEnvelope.class}) > +@Consumes(MediaType.TEXT_XML) > +@Produces(MediaType.TEXT_XML) > +public interface ImageApi { > + > + /** > +* @return Outputs a list of a

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> +import org.jclouds.rest.annotations.Payload; > +import org.jclouds.rest.annotations.PayloadParam; > +import org.jclouds.rest.annotations.RequestFilters; > +import org.jclouds.rest.annotations.XMLResponseParser; > + > +@RequestFilters( { BasicAuthentication.class, > ProfitBricksSoapMessageEnvelo

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> +return valueOf( v ); > + } catch ( IllegalArgumentException ex ) { > +return UNRECOGNIZED; > + } > + } > + } > + > + @Nullable > + public abstract String id(); > + > + @Nullable > + @Override > + public abstract String name(); > + > + @N

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> + @Nullable > + public abstract AvailabilityZone availabilityZone(); > + > + @Nullable > + public abstract Date creationTime(); > + > + @Nullable > + public abstract Date lastModificationTime(); > + > +// public abstract List storages(); > +// public abstract List storages(); > +

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> + > + public abstract boolean isCpuHotPlug(); > + > + public abstract boolean isCpuHotUnPlug(); > + > + public abstract boolean isRamHotPlug(); > + > + public abstract boolean isRamHotUnPlug(); > + > + public abstract boolean isNicHotPlug(); > + > + public abstract boolean isNicHotUnP

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> + HDD, CDROM, UNRECOGNIZED; > + > + public static Type fromValue(String v) { > + try { > +return valueOf(v); > + } catch (IllegalArgumentException ex) { > +return UNRECOGNIZED; > + } > + } > + } > + > + public abstract String id()

Re: [jclouds-labs] JCLOUDS-702: JCloud ProfitBricks provider - Server & Image API (#119)

> @@ -56,6 +56,8 @@ protected BaseProfitBricksRequestBinder(String paramName) { > protected abstract String createPayload(T payload); > > protected String formatIfNotEmpty(String pattern, Object param) { > + if (param == null ) > + return ""; >return Strings.isNullOrE

Re: [jclouds-labs] support for docker 1.3.2 (#113)

argh! @nacx Fixing them now --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/113#issuecomment-69925743

Jenkins build is back to normal : jclouds-guava-17-18 » 17.0,OpenJDK 7 (latest) #34

See

Build failed in Jenkins: jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #34

See -- [...truncated 13602 lines...] Starting test testFileGetParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) [TestNG] T

Re: [jclouds-labs] support for docker 1.3.2 (#113)

The build fails due to checkstyle violations. Address them while squashing and +1! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/113#issuecomment-69918918

Re: [jclouds-labs] support for docker 1.3.2 (#113)

@nacx I think you are right, better to remove the password as we don't suggest to use encrypted PEM file --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/113#issuecomment-69907182

Build failed in Jenkins: jclouds-guava-17-18 » 17.0,OpenJDK 7 (latest) #33

See Changes: [Ignasi Barrera] Custom Chef version in the Omnibus installer -- [...truncated 5071 lines...] Starting test testResolveImages

Re: [jclouds-labs] support for docker 1.3.2 (#113)

@nacx I think I need to rebase and squash so that you can merge it, yes? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/113#issuecomment-69901231

Re: [jclouds] Custom Chef version in the Omnibus installer (#638)

Pushed to master as [8f9acd1](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=8f9acd1cadf4a4e54af96441510813be2e48c16a). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/638#issuecomment-69899397

Re: [jclouds] Custom Chef version in the Omnibus installer (#638)

Closed #638. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/638#event-218668986

Re: [jclouds-labs-google] Configure GCS consistency model as "STRICT" (#121)

Indeed, I wasn't aware of the "peculiarity" regarding list operations in GCS. And your consistency test report is very interesting as well. But I'm afraid I won't be of any help on this topic, I'm simply a jclouds user which happened to browse through the source code :) So I think my kind of PR ca

Re: [jclouds-labs] support for docker 1.3.2 (#113)

There just a couple remaining minors. lgtm once they're fixed. Thanks @andreaturli ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/113#issuecomment-69892625

Re: [jclouds-labs] support for docker 1.3.2 (#113)

> throw propagate(e); >} > } > + > + private static X509Certificate getCertificate(String certificate) { > + try { > + return (X509Certificate) > CertificateFactory.getInstance("X.509").generateCertificate( > + new > ByteArrayInputStream(certif

Re: [jclouds-labs] support for docker 1.3.2 (#113)

> +import org.jclouds.http.okhttp.OkHttpClientSupplier; > + > +import com.google.common.collect.ImmutableList; > +import com.squareup.okhttp.ConnectionSpec; > +import com.squareup.okhttp.OkHttpClient; > +import com.squareup.okhttp.TlsVersion; > +import javax.inject.Inject; > +import javax.inject.Si

Re: [jclouds] Fix for JCLOUDS-655 (#626)

@monitorjbl @everett-toews I'll have a look at it this week. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/626#issuecomment-69891714

Re: [jclouds] Fixes the exponential backoff for a value of 0 (#644)

There is one checkstyle violation to fix and... Where are the tests that shows that this change works as expected? :) Add the corresponding ones to the [BackoffLimitedRetryHandlerTest](https://github.com/jclouds/jclouds/blob/master/core/src/test/java/org/jclouds/http/handlers/BackoffLimitedRetryH

Jenkins build is back to normal : jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #32

See

Re: [jclouds] JCLOUDS-529: fix aws-ec2 cleanupIncidentalResources (#629)

> + assertPosted(DEFAULT_REGION, > "Action=DescribePlacementGroups&GroupName.1=jclouds%23sg-3c6ef654%23us-east-1"); > + assertPosted(DEFAULT_REGION, > "Action=DeletePlacementGroup&GroupName=jclouds%23sg-3c6ef654%23us-east-1"); > + assertPosted(DEFAULT_REGION, > "Action=DescribePla

Re: [jclouds-site] Update users.md to include ClouDesire.com in users page (#150)

Pushed to master as [fdf4cdd](https://git-wip-us.apache.org/repos/asf?p=jclouds-site.git;a=commit;h=fdf4cdd85be9bb71a44e829a0c068d80f3aef341) and published the site. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/150#issuecomment-69889

Re: [jclouds-site] Update users.md to include ClouDesire.com in users page (#150)

Closed #150. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/150#event-218628924