[jira] [Updated] (JCLOUDS-816) SSL error thrown while accessing services through JCloud

2015-01-28 Thread Krishna Chaitanya (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Chaitanya updated JCLOUDS-816: -- Attachment: JCloudsNova_PublicCloud.java JCloudsNova_PubicCloud.out

[jira] [Created] (JCLOUDS-816) SSL error thrown while accessing services through JCloud

2015-01-28 Thread Krishna Chaitanya (JIRA)
Krishna Chaitanya created JCLOUDS-816: - Summary: SSL error thrown while accessing services through JCloud Key: JCLOUDS-816 URL: https://issues.apache.org/jira/browse/JCLOUDS-816 Project: jclouds

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Reijhanniel Jearl Campos
Here are the Storage API [live tests](https://gist.github.com/devcsrj/d0f3cb9d7c0f2e6a5988). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/128#issuecomment-71960552

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Reijhanniel Jearl Campos
> @@ -119,4 +129,9 @@ private static boolean hasPayload(final HttpResponse > response) { >return response.getPayload() != null && > response.getPayload().getRawContent() != null; > } > > + private static boolean isSoapPayload( final InputStream is ) throws > IOException { > +

Jenkins build is back to normal : jclouds-labs-google #426

2015-01-28 Thread jenkins-no-reply
See

Build failed in Jenkins: jclouds-labs-google #425

2015-01-28 Thread jenkins-no-reply
See -- [...truncated 157 lines...] Downloading: https://repository-jclouds.forge.cloudbees.com/release/classworlds/classworlds/1.1/classworlds-1.1.pom Downloading: http://repo.cloudbees.com/co

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread danbroudy
Im now looking into integrating with GCS. Not ready to merge yet --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/124#issuecomment-71950645

Re: [jclouds-labs-openstack] Add Rackspace CDN UK/US Providers (#177)

2015-01-28 Thread Zack Shoylev
Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/177#issuecomment-71950194

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread danbroudy
> + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache License, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + *

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread danbroudy
> + > + private GoogleComputeEngineCredentialSupplierFromJson(String jsonString){ > + creds = parseJsonKeyString(jsonString); > + } > + > + /** > +* Function for parsing JSON Key file downloaded from GCP developers > console. > +* > +* @param pathToJsonFile. > +* @return

[jclouds] Windows fixes, mostly separator related. (#656)

2015-01-28 Thread Zack Shoylev
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/656 -- Commit Summary -- * Windows fixes, mostly separator related. -- File Changes -- M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStr

Re: [jclouds-labs-google] Updated BackendServiceOptions to AutoValue + Builder (#125)

2015-01-28 Thread Ignasi Barrera
Auto has many benefits for the regular pojos (and that's why we want to use it), so I'd say go ahead! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/125#issuecomment-71923161

Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)

2015-01-28 Thread Ignasi Barrera
> + * limitations under the License. > + */ > +package org.jclouds.azurecompute.xml; > + > +import com.google.common.collect.ImmutableList; > +import com.google.common.collect.ImmutableList.Builder; > +import org.jclouds.azurecompute.domain.DataVirtualHardDisk; > +import org.jclouds.http.functions.

Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)

2015-01-28 Thread Ignasi Barrera
> +import com.google.auto.value.AutoValue; > +import org.jclouds.javax.annotation.Nullable; > + > +import java.net.URI; > + > +/** > + * @see href="https://msdn.microsoft.com/en-us/library/azure/jj157193.aspx#DataVirtualHardDisks"; > >api > + */ > + > +@AutoValue > +public abstract class DataVirt

Re: [jclouds] JCLOUDS-813: fix list private images (#655)

2015-01-28 Thread Ignasi Barrera
> @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class) > Set getPublicImages(); > > + /** > +* @return public images > +* @see href="http://sldn.softlayer.com/reference/services/SoftLayer_Virtual_Guest_Block_Device_Template_Group/getObject"; > /> > +*/ > + @Named("VirtualG

Re: [jclouds] JCLOUDS-813: fix list private images (#655)

2015-01-28 Thread Ignasi Barrera
> @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class) > Set getPublicImages(); > > + /** > +* @return public images This returns a single image. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/655/files#r23726400

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
BTW, can you share the live test results? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/128#issuecomment-71921895

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
Thanks @devcsrj! Just one last minor (style) comment: prefer `if (foo) {` (wihtout spaces) instead of `if ( foo ) {`. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/128#issuecomment-71921739

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> + > + try { > + api.createServer( Server.Request.CreatePayload.create( > "some-datacenter-id", "node1", 99, 12800) ); > + fail( "Request should have failed."); > + } catch (Exception ex){ > + assertTrue(ex instanceof InsufficientResourcesException, "Except

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> + ProfitBricksApi pbApi = api( server.getUrl( rootUrl ) ); > + StorageApi api = pbApi.storageApi(); > + > + String storageId = "qswdefrg-qaws-qaws-defe-rgrgdsvcxbrh"; > + > + String content = "" + storageId + > ""; > + > + try { > + boolean result = api.deleteSto

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> + this.waitUntilAvailable = Predicates2.retry( > + new ProvisioningStatusPollingPredicate( api, > ProvisioningStatusAware.STORAGE, ProvisioningState.AVAILABLE ), > + 6l * 60l, 2l, TimeUnit.SECONDS ); > + } > + > + @Test( expectedExceptions = InsufficientResourc

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> @@ -119,4 +129,9 @@ private static boolean hasPayload(final HttpResponse > response) { >return response.getPayload() != null && > response.getPayload().getRawContent() != null; > } > > + private static boolean isSoapPayload( final InputStream is ) throws > IOException { > +

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> @@ -59,7 +59,11 @@ public void handleError(final HttpCommand command, final > HttpResponse response) > break; > case 413: > case 503: > -exception = new > InsufficientResourcesException(response.getMessage(), exception); > + // if nothi

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> // @Nullable public abstract List loadBalancers(); > - public static DataCenter create(String id, String name, int version, > ProvisioningState state, Location location) { > - return new AutoValue_DataCenter(id, name, version, state, location); > + public static DataCenter create(Str

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

2015-01-28 Thread Ignasi Barrera
> @@ -50,6 +50,8 @@ public boolean apply(String input) { > return expect == api.dataCenterApi().getDataCenterState(input); > case SERVER: > return expect == api.serverApi().getServer( input ).state(); > + case STORAGE: > +return expect == api.

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
>I left it that you pass in a file when running the tests but pass in a JSON >string when instantiating a GoogleComputeEngineCredentialSupplierFromJson >normally That looks good to me. This is the same we do in other apis like Chef. Thanks! --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache License, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + *

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> + > + private GoogleComputeEngineCredentialSupplierFromJson(String jsonString){ > + creds = parseJsonKeyString(jsonString); > + } > + > + /** > +* Function for parsing JSON Key file downloaded from GCP developers > console. > +* > +* @param pathToJsonFile. > +* @return

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> + * Provides an easy way to pass in credentials using the json-key format. > + * Just provide the path to the .json file and this extracts and sets > identity > + * and credentials from the json. > + */ > +public class GoogleComputeEngineCredentialSupplierFromJson implements > Supplier{ > + >

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> + */ > +public class GoogleComputeEngineCredentialSupplierFromJson implements > Supplier{ > + > + private Credentials creds; > + > + private GoogleComputeEngineCredentialSupplierFromJson(String jsonString){ > + creds = parseJsonKeyString(jsonString); > + } > + > + /** > +* Funct

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> + > +import com.google.common.base.Supplier; > +import com.google.gson.JsonObject; > +import com.google.gson.JsonParser; > + > +/* > + * Provides an easy way to pass in credentials using the json-key format. > + * Just provide the path to the .json file and this extracts and sets > identity > +

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> +import org.jclouds.domain.Credentials; > + > +import com.google.common.base.Supplier; > +import com.google.gson.JsonObject; > +import com.google.gson.JsonParser; > + > +/* > + * Provides an easy way to pass in credentials using the json-key format. > + * Just provide the path to the .json file a

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
> + */ > +package org.jclouds.googlecomputeengine; > + > +import org.apache.commons.lang.StringEscapeUtils; > +import org.jclouds.domain.Credentials; > + > +import com.google.common.base.Supplier; > +import com.google.gson.JsonObject; > +import com.google.gson.JsonParser; > + > +/* > + * Provides a

Re: [jclouds] JCLOUDS-529: fix aws-ec2 cleanupIncidentalResources (#629)

2015-01-28 Thread Ignasi Barrera
Changes lgtm. Thanks @aledsage! Mind squashing and rebasing so I can cleanly merge it? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/629#issuecomment-71911666

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread danbroudy
I think `GoogleComputeEngineCredentialSupplierFromJson` is too long of a name and I am open to suggestions. Also passing in a JSON string into the eclipse maven build was causing problems so I left it that you pass in a file when running the tests but pass in a JSON string when instantiating a

[jira] [Commented] (JCLOUDS-813) Softlayer list private images

2015-01-28 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295396#comment-14295396 ] Andrea Turli commented on JCLOUDS-813: -- I've closed #653 and opened https://github.c

Re: [jclouds] JCLOUDS-813: fix list private images (#655)

2015-01-28 Thread Andrea Turli
@nacx can you have another look at it? thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/655#issuecomment-71872105

[jclouds] JCLOUDS-813: fix list private images (#655)

2015-01-28 Thread Andrea Turli
To fix the bug reported at JCLOUDS-813 this PR revisit the strategy to listImages: - modify the listImages and getImage strategies in SoftLayerComputeServiceAdapter: by default, it only consider `stock` images - add support for VirtualGuestBlockDeviceTemplateGroupApi getObject: this is need in `

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Ignasi Barrera
That's right. When in doubt, you can check the builds at: https://jclouds.ci.cloudbees.com/ Those run after every commit and publish the snapshots to the snapshots repo. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71871560

[jira] [Updated] (JCLOUDS-815) The SoftLayer provider should honor the authorizePublicKey option

2015-01-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-815: --- Issue Type: Improvement (was: Bug) > The SoftLayer provider should honor the authorizePublic

[jira] [Commented] (JCLOUDS-815) The SoftLayer provider should honor the authorizePublicKey option

2015-01-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295368#comment-14295368 ] Ignasi Barrera commented on JCLOUDS-815: Changed from bug to improvement, as jclo

Re: [jclouds] JCLOUDS-813: fix list private images (#653)

2015-01-28 Thread Andrea Turli
Closed #653. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/653#event-226188226

[jira] [Created] (JCLOUDS-815) The SoftLayer provider should honor the authorizePublicKey option

2015-01-28 Thread Ignasi Barrera (JIRA)
Ignasi Barrera created JCLOUDS-815: -- Summary: The SoftLayer provider should honor the authorizePublicKey option Key: JCLOUDS-815 URL: https://issues.apache.org/jira/browse/JCLOUDS-815 Project: jcloud

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
correct! it should be already available in 2.0.0-SNAPSHOT available in maven central, I think. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71862219

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrew Donald Kennedy
@andreaturli will this become part of jclouds 1.9.0 as well as 2.0.0 then? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71861410

Re: [jclouds] JCLOUDS-813: fix list private images (#653)

2015-01-28 Thread Andrea Turli
@nacx Some users get a NPE when `listImages` is called. This is happening [here](https://github.com/andreaturli/jclouds/blob/fix/softlayer-list-private-images/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/OperatingSystem.java#L107). Debugging a little bit, I found out the reason:

Jenkins build is back to normal : jclouds-guava-17-18 ยป 18.0,OpenJDK 7 (latest) #67

2015-01-28 Thread jenkins-no-reply
See

Re: [jclouds-labs-google] JCLOUDS-808: Enables working with .json key files, adding GoogleComputeEngineCredenti... (#124)

2015-01-28 Thread Ignasi Barrera
Cool @danbroudy! I like the supplier approach, as the json file contains both the identity and credential. I'd only change the name of the supplier so it reflects it is for the json file format, and assume a json string as an input (as we do with the PEM string in the default auth) and delegate

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
Closed #654. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#event-225930035

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
Merged as https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9e1d1cbfa9e2d77fe8b7e8feeae0bb4222654692 @grkvlt thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71800808

Re: [jclouds] Fix Softlayer template options (#654)

2015-01-28 Thread Andrea Turli
thanks @grkvlt! lgtm +1 merging now --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/654#issuecomment-71797889