@devcsrj @nacx Hey guys, is there any assistance we can provide on this PR or
is it ready to go? Thanks.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/145#issuecomment-78288352
Pushed to master as
[b54c788e](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=b54c788e).
I've fixed a few more test files in the `compute` project that failed the
build locally and amended the commit. I don't know why the pull request builder
has not detected that, though.
[
https://issues.apache.org/jira/browse/JCLOUDS-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357477#comment-14357477
]
Zack Shoylev commented on JCLOUDS-791:
--
I have removed the dependency on auto 1.1 and will refactor back to builders
once released.
At this point I want mostly to make sure this makes it into 1.9.0
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78324705
There seems to be a failure in ParseInterfaceAttachmentListTest?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697#issuecomment-78329975
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78357174
[
https://issues.apache.org/jira/browse/JCLOUDS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357425#comment-14357425
]
Andrew Gaul commented on JCLOUDS-848:
-
[~broudy] Would you like to add this support?
Andrew Gaul created JCLOUDS-848:
---
Summary: Support Google Cloud Storage nearline
Key: JCLOUDS-848
URL: https://issues.apache.org/jira/browse/JCLOUDS-848
Project: jclouds
Issue Type: New
Rebased changes to the original commit
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78354886
Closed #179.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#event-250395569
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/180#issuecomment-78323545
Last round of sanity checks, then squash and merge.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78341462
:+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78336509
Will merge when tests pass
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78354993
Hi @nacx and @everett-toews
I think I fix everything... can you please take a look?
Thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697#issuecomment-78311905
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+@RequestFilters({ ServiceKeyAuthentication.class })
+@Path(/api/servicekeys)
+public interface ServiceKeysApi {
+
+ @Named(servicekeys:list)
+ @GET
+ ListServiceKey listServiceKeys();
+
+
Investigating!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/703#issuecomment-78393765
Just curious... Why are there three merge commits at the end and not just one?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/703#issuecomment-78393727
@@ -64,6 +66,7 @@
void restartContainer(@PathParam(id) String id);
@Named(containers:deploy)
+ @Fallback(NullOnContainerResourceUnavailableAnd500.class)
This is a funny one and an open bug for Shipyard. The deployContainer call only
deploys a single container but returns a
@@ -64,6 +66,7 @@
void restartContainer(@PathParam(id) String id);
@Named(containers:deploy)
+ @Fallback(NullOnContainerResourceUnavailableAnd500.class)
I would remove this fallback, for several reasons: First, we shouldn't return
`null` lists; we should fallback to an empty
See
https://jclouds.ci.cloudbees.com/job/jclouds-guava-17-18/GUAVA_VERSION=18.0,jdk=OpenJDK%207%20(latest)/149/
https://issues.apache.org/jira/browse/JCLOUDS-791
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/703
-- Commit Summary --
* JCLOUDS-423 - Adds support for Rackspace Cloud Files API - Added support
for CloudFilesApi/CDNApi - Added
Hi @baldwinSPC !
I'm still working on passing the live tests for the compute service adapter.
Right now, the issue is that the default images from ProfitBricks are built
with password change a requirement upon first login, and so the ssh commands
executed by tests are actually left hanging.
Sorry @nacx, my bad. Thanks @ilgrosso for your fix.
Please, consider that traffic manager operations are ready for a new PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/148#issuecomment-78217667
Added -s option.
Now the /etc/hosts line is ipAddress hostname -f hostname -s
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78239596
Francesco Chicchiriccò created JCLOUDS-846:
--
Summary: Complete missing mock tests
Key: JCLOUDS-846
URL: https://issues.apache.org/jira/browse/JCLOUDS-846
Project: jclouds
Issue
Yes, yes, the option are on both sides
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78245094
Perhaps the `-s` parameter should also be used in the grep part? To make sure
we look for the smaller hostname?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78242257
Yes, yes, the option are on both sides
Oh, I didn't refresh the page and didn't see the last commit :) Cool! If you
don't mind squashing the commits into a single one I'll merge the PR.
---
Reply to this email directly or view it on GitHub:
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws/433/
See
https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws/org.apache.jclouds.labs$jclouds-labs-aws/433/
Thanks! WDYT about my comment of explicitly using the `-s` parameter too? In
some operating systems the `-f` might be the default behavior.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78237431
Fixed all tests
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78236684
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-google/513/
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws/433/
Oh, I see. There is an easier approach then: rempve the custom binders and
binding annotations and just annotate the parameter with `@WrapWith(key)`.
That will generate the expected json.
---
Reply to this email directly or view it on GitHub:
Regarding the fallback, they're used to recover upon failure and return a
value. This means that the fallback should return an object compatible with the
method's signature. In this case the method returns void but the fallback
returns an Optional object. I'd create a custom fallback that
Ok, now it is squashed
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/701#issuecomment-78261044
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+@RequestFilters({ ServiceKeyAuthentication.class })
+@Path(/api/servicekeys)
+public interface ServiceKeysApi {
+
+ @Named(servicekeys:list)
+ @GET
+ ListServiceKey listServiceKeys();
+
+
See
https://jclouds.ci.cloudbees.com/job/jclouds-guava-17-18/GUAVA_VERSION=18.0,jdk=OpenJDK%207%20(latest)/148/changes
Changes:
[Ignasi Barrera] Update setupPublicCurl.sh
--
[...truncated 28611 lines...]
Starting test
[
https://issues.apache.org/jira/browse/JCLOUDS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356454#comment-14356454
]
Francesco Chicchiriccò commented on JCLOUDS-841:
I have this [feature
@nacx all looks well. I believe all your comments have been addressed and for
the better. Specifically the fallbacks should now address the 500's returned
both from the ServiceKeysApi and The ContainersApi
---
Reply to this email directly or view it on GitHub:
Hi @nacx, @everett-toews and @zack-shoylev
I think I fix everything... can you please take a look?
Thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697#issuecomment-78418664
43 matches
Mail list logo
