[
https://issues.apache.org/jira/browse/JCLOUDS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509847#comment-14509847
]
Ignasi Barrera commented on JCLOUDS-890:
Patch: https://github.com/jclouds/jcloud
https://issues.apache.org/jira/browse/JCLOUDS-890
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/734
-- Commit Summary --
* JCLOUDS-890: Prevent NPE when generating the Chef attributes file
-- File Changes --
M apis/chef/src/main
> +.template(template)
> +.templateUrl(templateUrl)
> +.parameters(parameters)
> +.disableRollback(disableRollback)
> +.files(files)
> +.environment(environment).build();
> + }
> +
> + public static final class Builder {
>
> +.template(template)
> +.templateUrl(templateUrl)
> +.parameters(parameters)
> +.disableRollback(disableRollback)
> +.files(files)
> +.environment(environment).build();
> + }
> +
> + public static final class Builder {
>
It should be easy to refactor.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/733#issuecomment-95685477
> - try {
> - permissions = getPosixFilePermissions(path);
> - if (access == ContainerAccess.PRIVATE) {
> -permissions.remove(PosixFilePermission.OTHERS_READ);
> - } else if (access == ContainerAccess.PUBLIC_READ) {
> -permissions.add(PosixFilePe
> +.template(template)
> +.templateUrl(templateUrl)
> +.parameters(parameters)
> +.disableRollback(disableRollback)
> +.files(files)
> +.environment(environment).build();
> + }
> +
> + public static final class Builder {
>
Thanks @nacx - pretty sure there was another `test.aws.` it
complained about - `vpc` or `subnet` or `keyPair` i forget - but i was running
individual classes from the IDE. i'll do the maven run and post this overnight.
---
Reply to this email directly or view it on GitHub:
https://github.com/jc
Running them as follows (from the jclouds repo root) should be enough:
```bash
mvn integration-test -pl :aws-ec2 -Plive -Dtest.aws.identity=
-Dtest.aws.credential=
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/732#issuecomment-95602324
> +
> +-->
> +http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> + 4.0.0
> + org.apache.jclouds.examples
> + google-lb
> + 1.9.0
> +
I've run some of the live tests (template builder and compute in aws-ec2). I
stopped when I hit some required settings I didn't understand.
"Can this be automated?" :)
If not point me at a crib sheet for AWS and i'll run those live tests overnight
tonight.
---
Reply to this email directly or
Thanks @ahgittin! I'll have a look at it later today. Meanwhile, do you have
live test results for this PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/732#issuecomment-95600267
There is several repeated logic in this PR. Could you extract it to a
WindowsUtils (or whatever) class, to encapsulate it there?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/733#issuecomment-95598170
> + }
> + aclFileAttributes.setAcl(aclList);
> +} else {
> + List list = aclFileAttributes.getAcl();
> +
> list.add(AclEntry.newBuilder().setPrincipal(everyone).setPermissions(
> + AclEntryPermission.READ_DATA,
> - try {
> - permissions = getPosixFilePermissions(path);
> - if (access == ContainerAccess.PRIVATE) {
> -permissions.remove(PosixFilePermission.OTHERS_READ);
> - } else if (access == ContainerAccess.PUBLIC_READ) {
> -permissions.add(PosixFilePe
> - Set permissions;
> - try {
> - permissions = getPosixFilePermissions(path);
> - if (access == ContainerAccess.PRIVATE) {
> -permissions.remove(PosixFilePermission.OTHERS_READ);
> - } else if (access == ContainerAccess.PUBLIC_READ) {
> -p
>Path path = new File(buildPathStartingFromBaseDir(container)).toPath();
> - Set permissions;
> - try {
> - permissions = getPosixFilePermissions(path);
> - } catch (IOException ioe) {
> - throw Throwables.propagate(ioe);
> +
> + if ( System.getProperty("
>Path path = new File(buildPathStartingFromBaseDir(container)).toPath();
> - Set permissions;
> - try {
> - permissions = getPosixFilePermissions(path);
> - } catch (IOException ioe) {
> - throw Throwables.propagate(ioe);
> +
> + if ( System.getProperty("
>Path path = new File(buildPathStartingFromBaseDir(container)).toPath();
> - Set permissions;
> - try {
> - permissions = getPosixFilePermissions(path);
> - } catch (IOException ioe) {
> - throw Throwables.propagate(ioe);
> +
> + if ( System.getProperty("
Thanks @hsbhathiya! lgtm. Mind squashing the commits?
Also, while squashing, mind adding a comment in the VirtualMachineApi mock and
live test classes indicating that the capture tests are in the VMImage test
classes? One would expect those to be in the VirtualMachineApi test classes, so
let's m
@hsbhathiya Any plan to have this PR rebased soon?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-95594145
@nacx very awesome and thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/166#issuecomment-95581166
Just noted a last comment about the use of maps in the builders.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/188#issuecomment-95544168
> +.template(template)
> +.templateUrl(templateUrl)
> +.parameters(parameters)
> +.disableRollback(disableRollback)
> +.files(files)
> +.environment(environment).build();
> + }
> +
> + public static final class Builder {
>
[
https://issues.apache.org/jira/browse/JCLOUDS-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-892:
---
Affects Version/s: 1.9.0
> GCE: Compute abstraction should use one network for all groups
> -
[
https://issues.apache.org/jira/browse/JCLOUDS-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-892:
---
Labels: google-compute-engine (was: )
> GCE: Compute abstraction should use one network for
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/32478ef6)
and
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/e7fb5098).
Thanks @cdancy!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/166#issu
[
https://issues.apache.org/jira/browse/JCLOUDS-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-886.
Resolution: Fixed
Fix Version/s: 1.9.1
2.0.0
> Implement Roles AP
It seems those are real
[violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1718/org.apache.jclouds.provider$aws-ec2/violations/).
Can you fix them?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/732#issuecomment-95530401
29 matches
Mail list logo
