[
https://issues.apache.org/jira/browse/JCLOUDS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695000#comment-14695000
]
Andrea Turli commented on JCLOUDS-982:
--
there is a PR to fix this issue at
[
https://issues.apache.org/jira/browse/JCLOUDS-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695017#comment-14695017
]
Andrea Turli commented on JCLOUDS-981:
--
the PR at
[
https://issues.apache.org/jira/browse/JCLOUDS-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli reassigned JCLOUDS-981:
Assignee: Andrea Turli
Azure: remove mandatory virtual network creation
- fix reuse of existing storage service during deployment
- use AutoValue.Builder in DeployParams
- make network creation optional
- remove AzureComuteAdapterLiveTest b/c not meaningful
You can view, comment on, or merge this pull request online at:
[
https://issues.apache.org/jira/browse/JCLOUDS-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli reassigned JCLOUDS-982:
Assignee: Andrea Turli
Improve AzureTemplateOptions
See https://jclouds.ci.cloudbees.com/job/jclouds-karaf/1457/
@ilgrosso could you please have a look? thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-130598543
I've seen the changes and they seem ok.
I had to fix
```
src/test/java/org/jclouds/azurecompute/binders/DeploymentParamsToXMLTest.java
```
by changing
```
import autovalue.shaded.com.google.common.common.collect.ImmutableSet;
```
to
```
import com.google.common.collect.ImmutableSet;
```
I have these 3 tests failing:
```
[TestNG] Test
testAddIpPermission(org.jclouds.azurecompute.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest)
failed.
[TestNG] Test testList(org.jclouds.azurecompute.features.DiskApiLiveTest)
failed.
[TestNG] Test
+ }
+
+ /**
+ * @see #subnetName
+ */
+ public static AzureComputeTemplateOptions subnetName(final String
subnetName) {
+ final AzureComputeTemplateOptions options = new
AzureComputeTemplateOptions();
+ return options.subnetName(subnetName);
@@ -105,10 +105,10 @@
final String location = template.getLocation().getId();
final int[] inboundPorts = template.getOptions().getInboundPorts();
- final String storageAccountName =
templateOptions.getStorageAccountName().get();
- final String virtualNetworkName =
Use case 1 looks OK. The other two use cases seem to conflict with what is
proposed in JCLOUDS-981, which aims to avoid the complexity of creating
networks and let Azure assign an IP tot he VM, like other providers do?
---
Reply to this email directly or view it on GitHub:
@@ -126,140 +122,43 @@ public static ExternalEndpoint
inboundUdpToLocalPort(final int port, final int l
@Nullable
public abstract String reservedIPName();
- public abstract ListString subnetNames();
-
- public Builder toBuilder() {
- return
@ilgrosso @nacx thanks for your reviews!
@nacx: re design concern: I changed the implementation to support the following
3 use-cases:
1. user-specified network name: jclouds checks its existence, otherwise
IllegalArgumentException
2. user doesn't provide a networkName: jclouds looks for a
One design comment: the `tempalteOptions.networks` options is intended to be
used to provide a set of *existing* network IDs where the virtual machine
should be attached. Looking at the code, if the provided *thing* (as it can't
be an ID if the network still does not exist) does not exists, it
Arvind Nadendla created JCLOUDS-989:
---
Summary: HostAdministration API in openstack-nova needs to allow
query parameters
Key: JCLOUDS-989
URL: https://issues.apache.org/jira/browse/JCLOUDS-989
@@ -44,7 +45,7 @@ public AzureComputeProviderMetadataLive() {
public static Properties defaultProperties() {
final Properties properties =
AzureManagementApiMetadata.defaultProperties();
- properties.setProperty(TEMPLATE,
Ok, let's support properly use-case 1. In order to use a specific virtual
network, the end user needs to specify the `virtualNetworkName` and 1-more
`subnetNames`, so let's keep those specific `AzureComputeTemplateOptions`.
---
Reply to this email directly or view it on GitHub:
+
+ @Override
+ public AzureComputeTemplateOptions clone() {
+ final AzureComputeTemplateOptions options = new
AzureComputeTemplateOptions();
+ copyTo(options);
+ return options;
+ }
+
+ @Override
+ public void copyTo(final TemplateOptions to) {
+
@@ -105,10 +105,10 @@
final String location = template.getLocation().getId();
final int[] inboundPorts = template.getOptions().getInboundPorts();
- final String storageAccountName =
templateOptions.getStorageAccountName().get();
- final String virtualNetworkName =
@@ -106,7 +102,7 @@ public static ExternalEndpoint
inboundUdpToLocalPort(final int port, final int l
*/
public abstract OSImage.Type os();
- public abstract ListExternalEndpoint externalEndpoints();
+ @Nullable public abstract SetExternalEndpoint externalEndpoints();
@@ -44,7 +45,7 @@ public AzureComputeProviderMetadataLive() {
public static Properties defaultProperties() {
final Properties properties =
AzureManagementApiMetadata.defaultProperties();
- properties.setProperty(TEMPLATE,
22 matches
Mail list logo
