BTW, I aborted the build as it was stuck. Let's trigger a new build: rebuild
please
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-157877628
Agree to merge the PR once we have the tests fixed. I agree this was not the
initial purpose of the PR, but I think we should work towards promotion, and
fixing the tests when we notice they fail is the better and fastest way to get
that done.
This said, I'll make some room this week and try to
Closed #222.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#event-468500423
[
https://issues.apache.org/jira/browse/JCLOUDS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-947.
Resolution: Fixed
Fix Version/s: 2.0.0
> Properly configure live tests in ProfitBric
[
https://issues.apache.org/jira/browse/JCLOUDS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012063#comment-15012063
]
ASF subversion and git services commented on JCLOUDS-947:
-
Commit
Pushed to master as
[42afafd0](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/42afafd0).
Many thanks @devcsrj!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#issuecomment-157875043
> @@ -97,7 +97,7 @@ private ServerRequest(String name, String password) {
>if (password != null)
> user.password = password;
>if (tenant != null)
> - user.tenant = tenant;
> + user.tenantId = tenant;
I would rather not change the other one, as then it woul
> @@ -97,7 +97,7 @@ private ServerRequest(String name, String password) {
>if (password != null)
> user.password = password;
>if (tenant != null)
> - user.tenant = tenant;
> + user.tenantId = tenant;
Would it make sense to also rename the other variable to
@zack-shoylev: you beat me to it ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880#issuecomment-157751720
Also should be backported.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880#issuecomment-157740457
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/880
-- Commit Summary --
* Fixes tenantId when using the keystone admin extension
-- File Changes --
M
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/opt
> @@ -100,12 +103,37 @@ public static void delete(File file) throws IOException
> {
> }
>
> /**
> +* @return Localized name for the "Everyone" Windows principal.
> +*/
> + public static String getWindowsEveryonePrincipalName() {
I think it looks cleaner this way...?
---
Reply
> @@ -127,6 +128,20 @@ public void testCreateContainer() {
>TestUtils.directoryExists(TARGET_CONTAINER_NAME, true);
> }
>
> + public void testCreateContainerAccess() {
> + boolean result;
> +
> + TestUtils.directoryExists(TARGET_CONTAINER_NAME, false);
> + result = st
@andreaturli last time I have run the whole test suite (from the master
branch), few months ago, all tests were succeeding - starting with an almost
clean environment.
I haven't checked this lately, but IMO this PR should not be merged until at
least the same results are achieved.
---
Reply to
@ilgrosso yes indeed. The idea of this PR was not to fix all of the failing
live tests but to simplify the usage of the templateOptions and to make
virtualNetwork optional when provisioning a VM, I think.
I think we need to make sure that we can run those tests even in a
non-completely clean en
> To me,
> `AzureComputeSecurityGroupExtensionLiveTest>BaseSecurityGroupExtensionLiveTest.testAddIpPermission`
> is the real problem as that code can't work IMHO (maybe that test always
> failed?)
This test requires a clean environment; your error in fact is
`Duplicate input endpoint name(s) t
16 matches
Mail list logo
