Jenkins build is back to normal : jclouds-labs-openstack » jclouds openstack-neutron api #1020

2016-02-16 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-openstack #1020

2016-02-16 Thread jenkins-no-reply
See

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-553060104

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
merged --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#issuecomment-185022439

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-553039295

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-553039303

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,4.0,OpenJDK 7 (latest) #105

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 14805 lines...] Starting test testPutTwiceIsOkAndDoesntOverwrite(org.jclouds.blobstore.integration.T

Build failed in Jenkins: jclouds-guava-guice-compat » 17.0,3.0,OpenJDK 7 (latest) #105

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 15168 lines...] Starting test testPutTwiceIsOkAndDoesntOverwrite(org.jclouds.blobstore.integration.T

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,4.0,OpenJDK 7 (latest) #105

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 15427 lines...] Starting test testPutTwiceIsOkAndDoesntOverwrite(org.jclouds.blobstore.integrati

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,3.0,OpenJDK 7 (latest) #105

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 14603 lines...] Starting test testPutTwiceIsOkAndDoesntOverwrite(org.jclouds.blobstore.integration.T

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,3.0,OpenJDK 7 (latest) #105

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 15177 lines...] Starting test testPutTwiceIsOkAndDoesntOverwrite(org.jclouds.blobstore.integrati

Build failed in Jenkins: jclouds-labs-openstack #1019

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 3315 lines...] [INFO] Exclude: **/.metadata/** [INFO] Exclude: **/atlassian-ide-plugin.xml [INFO] Exclude: **/.DS_Store [INFO] Exclude: .mailmap [INFO] Exclude: .git/**

Build failed in Jenkins: jclouds-guava-guice-compat » 17.0,4.0,OpenJDK 7 (latest) #105

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 5985 lines...] at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)

Build failed in Jenkins: jclouds-labs-openstack » jclouds openstack-neutron api #1019

2016-02-16 Thread jenkins-no-reply
See -- Started calculate disk usage of build Finished Calculation of disk usage of build in 0 seconds Started calculate disk usage of workspace Fin

Build failed in Jenkins: jclouds-labs-google » jclouds Google Cloud Storage provider #850

2016-02-16 Thread jenkins-no-reply
See -- Started calculate disk usage of build Finished Calculation of disk usage of build in 0 seconds Started calculate disk usage of workspace Fini

Build failed in Jenkins: jclouds-labs-google #850

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 2813 lines...] Downloading: http://repo.cloudbees.com/content/repositories/central/com/google/errorprone/error_prone_core/2.0.1/error_prone_core-2.0.1.pom Downloaded: http

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552946212

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552946202

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552923924

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552923922

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,3.0,OpenJDK 7 (latest) #104

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. [Andrew Gaul] Convert CopyOptions

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,4.0,OpenJDK 7 (latest) #104

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. [Andrew Gaul] Convert CopyOptions into

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,4.0,OpenJDK 7 (latest) #104

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. [Andrew Gaul] Convert CopyOptions

Build failed in Jenkins: jclouds-guava-guice-compat » 17.0,4.0,OpenJDK 7 (latest) #104

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. [Andrew Gaul] Convert CopyOptions into

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,3.0,OpenJDK 7 (latest) #104

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. [Andrew Gaul] Convert CopyOptions into

Build failed in Jenkins: jclouds-guava-guice-compat » 17.0,3.0,OpenJDK 7 (latest) #104

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. [Andrew Gaul] Convert CopyOptions into

Build failed in Jenkins: jclouds-labs-openstack » jclouds openstack-neutron api #1018

2016-02-16 Thread jenkins-no-reply
See -- Started calculate disk usage of build Finished Calculation of disk usage of build in 0 seconds Started calculate disk usage of workspace Fin

Build failed in Jenkins: jclouds-labs-openstack #1018

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 3315 lines...] [INFO] Exclude: **/.metadata/** [INFO] Exclude: **/atlassian-ide-plugin.xml [INFO] Exclude: **/.DS_Store [INFO] Exclude: .mailmap [INFO] Exclude: .git/**

Build failed in Jenkins: jclouds-labs-google #849

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 2813 lines...] Downloading: http://repo.cloudbees.com/content/repositories/central/com/google/errorprone/error_prone_core/2.0.1/error_prone_core-2.0.1.pom Downloaded: http

Build failed in Jenkins: jclouds-labs-google » jclouds Google Cloud Storage provider #849

2016-02-16 Thread jenkins-no-reply
See -- Started calculate disk usage of build Finished Calculation of disk usage of build in 0 seconds Started calculate disk usage of workspace Fini

Jenkins build is back to normal : jclouds #3364

2016-02-16 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds » jclouds Google Cloud Core #3364

2016-02-16 Thread jenkins-no-reply
See

Re: [jclouds] JCLOUDS-651: Conditional copy blob (#919)

2016-02-16 Thread Zack Shoylev
> + @Nullable > + public abstract Map userMetadata(); > + > + @Nullable > + public abstract Date ifModifiedSince(); > + @Nullable > + public abstract Date ifUnmodifiedSince(); > + @Nullable > + public abstract String ifMatch(); > + @Nullable > + public abstract String ifNoneMatc

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552894084

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552894060

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552870704

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552870696

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2016-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149582#comment-15149582 ] ASF subversion and git services commented on JCLOUDS-651: - Commit

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2016-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149581#comment-15149581 ] ASF subversion and git services commented on JCLOUDS-651: - Commit

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2016-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149578#comment-15149578 ] ASF subversion and git services commented on JCLOUDS-651: - Commit

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2016-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149580#comment-15149580 ] ASF subversion and git services commented on JCLOUDS-651: - Commit

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2016-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149579#comment-15149579 ] ASF subversion and git services commented on JCLOUDS-651: - Commit

[jira] [Commented] (JCLOUDS-651) server-side copy in portable abstraction

2016-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149583#comment-15149583 ] ASF subversion and git services commented on JCLOUDS-651: - Commit

Re: [jclouds] JCLOUDS-651: Conditional copy blob (#919)

2016-02-16 Thread Andrew Gaul
> + @Nullable > + public abstract Map userMetadata(); > + > + @Nullable > + public abstract Date ifModifiedSince(); > + @Nullable > + public abstract Date ifUnmodifiedSince(); > + @Nullable > + public abstract String ifMatch(); > + @Nullable > + public abstract String ifNoneMatc

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552818199

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552818210

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552763661

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552763672

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552696471

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552696458

Build failed in Jenkins: jclouds #3363

2016-02-16 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Enhance the way openstack extensions are resolved. Needed for new openstack versions. -- [...truncated 7725 lines...] [INFO] jclouds enterprise Module

Build failed in Jenkins: jclouds » jclouds Google Cloud Core #3363

2016-02-16 Thread jenkins-no-reply
See -- [...truncated 14 lines...] [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ googlecloud --- [INFO] [INFO] --- maven-resources-plugin:2

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Reopened #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552688062

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
Closed #203. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#event-552688046

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Zack Shoylev
This depends on the referenced PR, so checks will fail until the dependency is updated --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#issuecomment-184879641

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
merged --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#issuecomment-184878990

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
Closed #918. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#event-552663369

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
Reopened #918. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#event-552611490

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
Closed #918. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#event-552611483

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
Seems like unrelated. Hm. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#issuecomment-184865214

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
Reopened #918. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#event-552550952

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Zack Shoylev
Closed #918. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#event-552550896

Re: [jclouds] JCLOUDS-651: Conditional copy blob (#919)

2016-02-16 Thread Zack Shoylev
> + @Nullable > + public abstract Map userMetadata(); > + > + @Nullable > + public abstract Date ifModifiedSince(); > + @Nullable > + public abstract Date ifUnmodifiedSince(); > + @Nullable > + public abstract String ifMatch(); > + @Nullable > + public abstract String ifNoneMatc

Re: [jclouds-labs] Profitbricks REST - Volume API (#233)

2016-02-16 Thread Ignasi Barrera
You can start from an object for the expected payload and serialize it to get the expected payload string. This way you should be able to avoid ordering issues caused by different JVM defaults. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/23

Re: [jclouds-labs] Profitbricks REST - Volume API (#233)

2016-02-16 Thread mirza-spc
Seems like the tests are failing because of the different ordering of keys in jsonBinder.toJson method. Any thoughts on this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/233#issuecomment-184743960

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Christopher Dancy
@nacx latest comments should all be addressed. On a side/separate note: any suggestions on how to force a specific live test-class to run AFTER all other live tests are completed? In this case the MembersApiLiveTest needs to run last or risk fudging up the other tests while they are attempting

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + */ > +@Test(groups = "unit", testName = "KeysApiMockTest") > +public class KeysApiMockTest extends BaseEtcdMockTest { > + > + public void testCreateKey() throws Exception { > + MockWebServer server = mockEtcdJavaWebServer(); > + > + server.enqueue(new > MockResponse().setBody(paylo

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> +import org.jclouds.etcd.domain.keys.Key; > +import org.testng.annotations.BeforeClass; > +import org.testng.annotations.Test; > + > +import com.google.common.base.Throwables; > + > +@Test(groups = "live", testName = "KeysApiLiveTest") > +public class KeysApiLiveTest extends BaseEtcdApiLiveTest {

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + > + public abstract int modifiedIndex(); > + > + public abstract int ttl(); > + > + @Nullable > + public abstract String value(); > + > + Node() { > + } > + > + @SerializedNames({ "createdIndex", "dir", "nodes", "expiration", "key", > "modifiedIndex", "ttl", "value" }) > + publ

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Christopher Dancy
@nacx for this initial PR lets keep things simple and leave those other methods out. I want to get a good foundation built and going to make the subsequent PR's easier on not only myself but others reviewing. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclou

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Christopher Dancy
> + */ > +@Test(groups = "unit", testName = "KeysApiMockTest") > +public class KeysApiMockTest extends BaseEtcdMockTest { > + > + public void testCreateKey() throws Exception { > + MockWebServer server = mockEtcdJavaWebServer(); > + > + server.enqueue(new > MockResponse().setBody(paylo

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Christopher Dancy
> + String localValue = UUID.randomUUID().toString().replaceAll("-", ""); > + Key createdKey = api().createKey(localKey, localValue, 1); > + assertNotNull(createdKey); > + assertNotNull(createdKey.node().expiration()); > + > + try { > + Thread.sleep(3000); > +

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Christopher Dancy
> + * limitations under the License. > + */ > +package org.jclouds.etcd.features; > + > +import static org.testng.Assert.assertNotNull; > +import static org.testng.Assert.assertNull; > +import static org.testng.Assert.assertTrue; > + > +import java.util.UUID; > + > +import org.jclouds.etcd.BaseEtcd

Re: [jclouds-labs] Profitbricks REST - Volume API (#233)

2016-02-16 Thread Reijhanniel Jearl Campos
Thanks for the `injector`-approach @nacx ! @mirza-spc I noticed that there are missing test in the [`-Binder`](https://github.com/StackPointCloud/jclouds-labs/tree/profitbricks-volume-api/profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder) classes. Could you add tests fo

Re: [jclouds-labs] Profitbricks REST - Volume API (#233)

2016-02-16 Thread Ignasi Barrera
Thanks for the fixes @mirza-spc! @devcsrj Wanna review the fixes before squashing the commits? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/233#issuecomment-184607715

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> A lot of this is boiler plate code so I hope it's easy enough to digest. If > not let me know and I can break it up further. This PR was not that big, so feel free to add the other key methods back. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + MockWebServer server = mockEtcdJavaWebServer(); > + > + server.enqueue(new > MockResponse().setBody(payloadFromResource("/keys-create.json")).setResponseCode(201)); > + EtcdApi etcdApi = api(server.getUrl("/")); > + KeysApi api = etcdApi.keysApi(); > + try { > +

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + */ > +@Test(groups = "unit", testName = "KeysApiMockTest") > +public class KeysApiMockTest extends BaseEtcdMockTest { > + > + public void testCreateKey() throws Exception { > + MockWebServer server = mockEtcdJavaWebServer(); > + > + server.enqueue(new > MockResponse().setBody(paylo

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + > + @Test(dependsOnMethods = "testGetKey") > + public void testDeleteKey() { > + Key deletedKey = api().deleteKey(key); > + assertNotNull(deletedKey); > + assertTrue(deletedKey.action().equals("delete")); > + assertTrue(deletedKey.prevNode().value().equals(value)); > +

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + public void testCreateKey() { > + Key createdKey = api().createKey(key, value); > + assertNotNull(createdKey); > + assertTrue(createdKey.action().equals("set")); > + assertTrue(createdKey.node().value().equals(value)); > + } > + > + @Test(dependsOnMethods = "testCreate

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + public void testGetKey() { > + Key getKey = api().getKey(key); > + assertNotNull(getKey); > + assertTrue(getKey.action().equals("get")); > + assertTrue(getKey.node().value().equals(value)); > + } > + > + @Test(dependsOnMethods = "testGetKey") > + public void testDele

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + > + @Test(dependsOnMethods = "testCreateKey") > + public void testGetKey() { > + Key getKey = api().getKey(key); > + assertNotNull(getKey); > + assertTrue(getKey.action().equals("get")); > + assertTrue(getKey.node().value().equals(value)); > + } > + > + @Test(depends

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + String localValue = UUID.randomUUID().toString().replaceAll("-", ""); > + Key createdKey = api().createKey(localKey, localValue, 1); > + assertNotNull(createdKey); > + assertNotNull(createdKey.node().expiration()); > + > + try { > + Thread.sleep(3000); > +

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + * limitations under the License. > + */ > +package org.jclouds.etcd.features; > + > +import static org.testng.Assert.assertNotNull; > +import static org.testng.Assert.assertNull; > +import static org.testng.Assert.assertTrue; > + > +import java.util.UUID; > + > +import org.jclouds.etcd.BaseEtcd

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + key = UUID.randomUUID().toString().replaceAll("-", ""); > + value = UUID.randomUUID().toString().replaceAll("-", ""); > + } > + > + @Test > + public void testCreateKeyWithTTL() { > + String localKey = UUID.randomUUID().toString().replaceAll("-", ""); > + String localVa

Re: [jclouds-labs] JCLOUDS-1076: Initial implementation of Keys API (#234)

2016-02-16 Thread Ignasi Barrera
> + > + public abstract int modifiedIndex(); > + > + public abstract int ttl(); > + > + @Nullable > + public abstract String value(); > + > + Node() { > + } > + > + @SerializedNames({ "createdIndex", "dir", "nodes", "expiration", "key", > "modifiedIndex", "ttl", "value" }) > + publ

Re: [jclouds-labs-openstack] Renames extension resolver (#203)

2016-02-16 Thread Ignasi Barrera
+1! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/203#issuecomment-184599609

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Ignasi Barrera
Update the `toString` method in the renamed class too. Just these two minors. lgtm! Thanks @zack-shoylev! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/918#issuecomment-184582489

Re: [jclouds] Enhance the way openstack extensions are resolved. (#918)

2016-02-16 Thread Ignasi Barrera
> @@ -42,19 +43,48 @@ > /** > * We use the annotation {@link Extension} to bind a class that implements > an extension > * API to an {@link Extension}. > + * > + * Match in the following order: > + * > + * 1. Match by namespace > + * 2. Match by namespace aliases > + * 3. Match by alias > + *