Sorry about that, these are basically still the PRs that were completed in
december last year and sometimes things get overlooked while applying all of
the changes because it's all a bit of mechanical repetition.
> On Apr 11, 2016, at 11:43 PM, Ignasi Barrera wrote:
>
> Thanks @mirza-spc!
> Mo
@nacx @andreaturli
This PR is part of the foundations needed for interacting with Azure Resource
Manager (ARM) Rest APIs. The Location API is the second API.
FYI
@jmspring @jtjk @isalento
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/p
[
https://issues.apache.org/jira/browse/JCLOUDS-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236138#comment-15236138
]
Ignasi Barrera commented on JCLOUDS-1077:
-
Fix: https://github.com/jclouds/jclou
https://issues.apache.org/jira/browse/JCLOUDS-1077
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/944
-- Commit Summary --
* JCLOUDS-1077: Fix ProjectApiLiveTest in Google Compute Engine
-- File Changes --
M
providers/google-com
Thanks @mirza-spc!
Most of the comments are exactly the same that were made in the previous LAN
api pull request. Please, take your time to review and understand them in order
to avoid repeating those patterns in upcoming pull requests.
---
You are receiving this because you are subscribed to th
> + @Test
> + public void testGetFirewallRule() throws InterruptedException {
> + MockResponse response = new MockResponse();
> + response.setBody(stringFromResource("/firewall/get.json"));
> + response.setHeader("Content-Type",
> "application/vnd.profitbricks.resource+json");
>
> + }
> +
> + private void assertFirewallRuleRemoved(FirewallRule firewallRule) {
> + assertPredicate(new Predicate() {
> + @Override
> + public boolean apply(FirewallRule testRule) {
> +return firewallApi().getFirewallRule(testRule.dataCenterId(),
> testRul
> +import org.jclouds.rest.annotations.PATCH;
> +import org.jclouds.rest.annotations.PayloadParam;
> +import org.jclouds.rest.annotations.RequestFilters;
> +import org.jclouds.rest.annotations.ResponseParser;
> +import org.jclouds.rest.annotations.SelectJson;
> +import org.jclouds.util.Strings2;
>
> + FirewallRule firewallRule =
> firewallApi().getFirewallRule(dataCenter.id(), testServer.id(), testNic.id(),
> testFirewallRule.id());
> +
> + assertNotNull(firewallRule);
> + assertEquals(firewallRule.id(), testFirewallRule.id());
> + }
> +
> + @Test(dependsOnMethods = "tes
> +
> + @Test(dependsOnMethods = "testCreateFirewallRule")
> + public void testGetFirewallRule() {
> + FirewallRule firewallRule =
> firewallApi().getFirewallRule(dataCenter.id(), testServer.id(), testNic.id(),
> testFirewallRule.id());
> +
> + assertNotNull(firewallRule);
> +
> +import org.apache.jclouds.profitbricks.rest.ids.ServerRef;
> +import
> org.apache.jclouds.profitbricks.rest.internal.BaseProfitBricksLiveTest;
> +import org.testng.annotations.AfterClass;
> +import org.testng.annotations.BeforeClass;
> +import org.testng.annotations.Test;
> +import static org.t
> +requestBuilder.put("sourceIp", payload.sourceIp());
> +
> + if (payload.targetIp() != null)
> +requestBuilder.put("targetIp", payload.targetIp());
> +
> + if (payload.icmpCode() != null)
> +requestBuilder.put("icmpCode", payload.icmpCode());
> +
> + if (pay
>
> -public abstract int portRangeEnd();
> +public abstract Integer portRangeEnd();
Any reason to convert to Integer if it is not marked as `@Nullable`?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https
hey @nacx let me know if you need anything from our end to merge these PRs on
into the project. We'd like to wrap them up soon :)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull
14 matches
Mail list logo
