Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Gaul
> +// Guava 18 and earlier method > +isSuperTypeOfType = > TypeToken.class.getDeclaredMethod("isAssignableFrom", Type.class); > +isSuperTypeOfTypeToken = > TypeToken.class.getDeclaredMethod("isAssignableFrom", TypeToken.class); > + } catch (NoSuchMethod

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Gaul
> @@ -45,7 +46,7 @@ protected BaseView(@Provider Context backend, @Provider > TypeToken @SuppressWarnings("unchecked") > @Override > public C unwrap(TypeToken type) { > - checkArgument(checkNotNull(type, > "type").isAssignableFrom(backendType), "backend type: %s not assignable t

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Gaul
>} > + Set actualTags = actualTagsBuilder.build(); > + assertThat(actualTags).containsAll(tags); Guava 20 adds a `CheckReturnValue` annotation to several methods which we must consume when compiling with the newer library. -- You are receiving this because you are subscribed t

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Gaul
> + isSuperTypeOfTypeToken = > TypeToken.class.getDeclaredMethod("isSupertypeOf", TypeToken.class); > + } catch (NoSuchMethodException nsme) { > + try { > +// Guava 18 and earlier method > +isSuperTypeOfType = > TypeToken.class.getDeclaredMethod("isAss

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Gaul
> @@ -104,7 +104,7 @@ public void testPeanutButterDidntTurnIntoWine() { > wine.unwrap(typeToken(PeanutButter.class)); > fail(); >} catch (IllegalArgumentException e) { > - assertEquals(e.getMessage(), "backend type: > org.jclouds.internal.BaseViewTest$Water not

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
Thanks for putting this together, @nacx! Just minors and nits from me - can be taken care of during the merge, I think. Independently of this PR: now that we have the framework for including shaded bundles relatively easily, perhaps worth considering making one that applies ymnk/jsch-agent-prox

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
> + > +Unless required by applicable law or agreed to in writing, software > +distributed under the License is distributed on an "AS IS" BASIS, > +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +See the License for the specific language governing permissions and > +limit

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
> +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +See the License for the specific language governing permissions and > +limitations under the License. > +--> > + > +http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:sch

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
> +${import.packages} > + > + > + > + > +org.apache.maven.plugins > +maven-shade-plugin > +2.4.3 > + > + > +package > + > + shade > + > + > +

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
> + > + org.apache.jclouds.karaf.bundles > + jsch-agentproxy-jsch > + jclouds :: Karaf :: JSCH Agentproxy Shaded Bundle > + bundle > + > + > + > + org.apache.servicemix.bundles > + > org.apache.servicemix.bundles.jsch-agentproxy-jsch > + ${jsch.agentproxy.bundle.version} >

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
> +See the License for the specific language governing permissions and > +limitations under the License. > +--> > + > +http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xs

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Andrew Phillips
> +(the "License"); you may not use this file except in compliance with > +the License. You may obtain a copy of the License at > + > +http://www.apache.org/licenses/LICENSE-2.0 > + > +Unless required by applicable law or agreed to in writing, software > +distributed under the License is distr

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,4.0,OpenJDK 7 (latest) #194

2016-09-02 Thread jenkins-no-reply
See Changes: [Zack Shoylev] Allows users to download large files efficiently and directly to disk. -- [...trunca

Re: [jclouds/jclouds] Allows users to download large files efficiently and directly to disk. (#983)

2016-09-02 Thread Zack Shoylev
Closed #983. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/983#event-777009355

Re: [jclouds/jclouds] Allows users to download large files efficiently and directly to disk. (#983)

2016-09-02 Thread Zack Shoylev
merged Will work on getting something very similar for the rest of the providers, might refactor it more then. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/983#issuecomment-2444683

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Phillips
> +// Guava 18 and earlier method > +isSuperTypeOfType = > TypeToken.class.getDeclaredMethod("isAssignableFrom", Type.class); > +isSuperTypeOfTypeToken = > TypeToken.class.getDeclaredMethod("isAssignableFrom", TypeToken.class); > + } catch (NoSuchMethod

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Phillips
>} > + Set actualTags = actualTagsBuilder.build(); > + assertThat(actualTags).containsAll(tags); Just curious: related to this PR, or just cleanup? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://gi

[jira] [Commented] (JCLOUDS-1170) Azure compute provider doesn't remove data blobs for disks

2016-09-02 Thread Josef Cacek (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458809#comment-15458809 ] Josef Cacek commented on JCLOUDS-1170: -- The fix works in my usecases - verified wit

[jira] [Commented] (JCLOUDS-1170) Azure compute provider doesn't remove data blobs for disks

2016-09-02 Thread Josef Cacek (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458805#comment-15458805 ] Josef Cacek commented on JCLOUDS-1170: -- PR sent: https://github.com/jclouds/jclouds

[jclouds/jclouds-labs] JCLOUDS-1170 The azurecompute provider should remove disk blobs (#316)

2016-09-02 Thread Josef Cacek
JIRA: https://issues.apache.org/jira/browse/JCLOUDS-1170 This fixes removing VM disks on Azure. There was missing query parameter in the API call, which caused increasing storage consumption because the data blobs were not deleted for the removed disks. You can view, comment on, or merge this pu

[jira] [Commented] (JCLOUDS-1170) Azure compute provider doesn't remove data blobs for disks

2016-09-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458795#comment-15458795 ] Ignasi Barrera commented on JCLOUDS-1170: - Oh, apologies, I thought this was ref

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Phillips
> @@ -104,7 +104,7 @@ public void testPeanutButterDidntTurnIntoWine() { > wine.unwrap(typeToken(PeanutButter.class)); > fail(); >} catch (IllegalArgumentException e) { > - assertEquals(e.getMessage(), "backend type: > org.jclouds.internal.BaseViewTest$Water not

[jira] [Commented] (JCLOUDS-1170) Azure compute provider doesn't remove data blobs for disks

2016-09-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458792#comment-15458792 ] Ignasi Barrera commented on JCLOUDS-1170: - Could use this to track the issue tha

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Phillips
> + isSuperTypeOfTypeToken = > TypeToken.class.getDeclaredMethod("isSupertypeOf", TypeToken.class); > + } catch (NoSuchMethodException nsme) { > + try { > +// Guava 18 and earlier method > +isSuperTypeOfType = > TypeToken.class.getDeclaredMethod("isAss

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Andrew Phillips
> @@ -45,7 +46,7 @@ protected BaseView(@Provider Context backend, @Provider > TypeToken @SuppressWarnings("unchecked") > @Override > public C unwrap(TypeToken type) { > - checkArgument(checkNotNull(type, > "type").isAssignableFrom(backendType), "backend type: %s not assignable t

[jira] [Updated] (JCLOUDS-1170) Azure compute provider doesn't remove data blobs for disks

2016-09-02 Thread Josef Cacek (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josef Cacek updated JCLOUDS-1170: - Description: The Azure provider leaves data blobs for VM disks in the storage account after the

[jira] [Created] (JCLOUDS-1170) Azure compute provider doesn't remove data blobs for disks

2016-09-02 Thread Josef Cacek (JIRA)
Josef Cacek created JCLOUDS-1170: Summary: Azure compute provider doesn't remove data blobs for disks Key: JCLOUDS-1170 URL: https://issues.apache.org/jira/browse/JCLOUDS-1170 Project: jclouds

[jira] [Comment Edited] (JCLOUDS-1160) Consider gson 2.7 upgrade

2016-09-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458189#comment-15458189 ] Ignasi Barrera edited comment on JCLOUDS-1160 at 9/2/16 10:41 AM:

[jira] [Commented] (JCLOUDS-1160) Consider gson 2.7 upgrade

2016-09-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458189#comment-15458189 ] Ignasi Barrera commented on JCLOUDS-1160: - [~ptimson] I know; the last commit do

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Ignasi Barrera
@nacx pushed 1 commit. ee48960 Add relative paths to maven parent in all modules -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/77/files/3f9003886b501991e34bd3d84373a85ae7e93d32..ee4896065371024725828b023367

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/77#issuecomment-244338358

[jira] [Commented] (JCLOUDS-1156) jclouds-cli fails to run compute service commands

2016-09-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458080#comment-15458080 ] Ignasi Barrera commented on JCLOUDS-1156: - PR to fix the exports by shading and

[jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

2016-09-02 Thread Ignasi Barrera
https://issues.apache.org/jira/browse/JCLOUDS-1156 I've shaded the offending bundle and shaded it to remove the invalid export. I did this by adding a `bundles` project where we can put our own bundles if we get into similar situations in the future. With this fix, I've been able to properly re

[jira] [Comment Edited] (JCLOUDS-1160) Consider gson 2.7 upgrade

2016-09-02 Thread Peter Timson (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458068#comment-15458068 ] Peter Timson edited comment on JCLOUDS-1160 at 9/2/16 9:40 AM: ---

[jira] [Commented] (JCLOUDS-1160) Consider gson 2.7 upgrade

2016-09-02 Thread Peter Timson (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458068#comment-15458068 ] Peter Timson commented on JCLOUDS-1160: --- [~nacx] I'm not sure but Spring Boot uses

Jenkins build is back to normal : jclouds-karaf-1.9.x-branch #160

2016-09-02 Thread jenkins-no-reply
See

[jira] [Commented] (JCLOUDS-1169) Code crashes at ContextBuilder for Apis. I have been using jclouds daily build(2.0.0-SNAPSHOT). But since 30th of august , APIs have stopped working. Basically the co

2016-09-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457913#comment-15457913 ] Ignasi Barrera commented on JCLOUDS-1169: - The versions with the fix have alread

Jenkins build is back to stable : jclouds-karaf #1917

2016-09-02 Thread jenkins-no-reply
See

Jenkins build is back to stable : jclouds-karaf » jclouds :: Karaf :: Integration Tests #1917

2016-09-02 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-guava-guice-compat » 19.0-rc1,4.0,OpenJDK 7 (latest) #193

2016-09-02 Thread jenkins-no-reply
See

Jenkins build is still unstable: jclouds-karaf #1916

2016-09-02 Thread jenkins-no-reply
See

Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1916

2016-09-02 Thread jenkins-no-reply
See

Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1915

2016-09-02 Thread jenkins-no-reply
See

Jenkins build is still unstable: jclouds-karaf #1915

2016-09-02 Thread jenkins-no-reply
See

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Ignasi Barrera
Thanks @andrewgaul! Just one comment in a test. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/982#issuecomment-244299902

Re: [jclouds/jclouds] JCLOUDS-1074: Guava 20 compatibility (#982)

2016-09-02 Thread Ignasi Barrera
> @@ -104,7 +104,7 @@ public void testPeanutButterDidntTurnIntoWine() { > wine.unwrap(typeToken(PeanutButter.class)); > fail(); >} catch (IllegalArgumentException e) { > - assertEquals(e.getMessage(), "backend type: > org.jclouds.internal.BaseViewTest$Water not

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

2016-09-02 Thread Ignasi Barrera
Merged to master as [4c927636](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4c927636). And included the reasoning behind this change in the commit message as per @zack-shoylev's suggestion. -- You are receiving this because you are subscribed to this thread. Reply to this email direct

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

2016-09-02 Thread Ignasi Barrera
Closed #1004. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1004#event-776181425

[jira] [Commented] (JCLOUDS-1160) Consider gson 2.7 upgrade

2016-09-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457737#comment-15457737 ] ASF subversion and git services commented on JCLOUDS-1160: -- Com

[jira] [Commented] (JCLOUDS-1169) Code crashes at ContextBuilder for Apis. I have been using jclouds daily build(2.0.0-SNAPSHOT). But since 30th of august , APIs have stopped working. Basically the co

2016-09-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457738#comment-15457738 ] ASF subversion and git services commented on JCLOUDS-1169: -- Com

[jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package

2016-09-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457735#comment-15457735 ] ASF subversion and git services commented on JCLOUDS-1166: -- Com

[jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package

2016-09-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457729#comment-15457729 ] ASF subversion and git services commented on JCLOUDS-1166: -- Com

[jira] [Commented] (JCLOUDS-1169) Code crashes at ContextBuilder for Apis. I have been using jclouds daily build(2.0.0-SNAPSHOT). But since 30th of august , APIs have stopped working. Basically the co

2016-09-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457731#comment-15457731 ] ASF subversion and git services commented on JCLOUDS-1169: -- Com

[jira] [Commented] (JCLOUDS-1160) Consider gson 2.7 upgrade

2016-09-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457730#comment-15457730 ] ASF subversion and git services commented on JCLOUDS-1160: -- Com