Makes sense. I copied how our jclouds oauth lib is configured, as they are the
same kind of dependency, and I have not found any differences...
Wait! Perhaps oauth works because our google-common is declared in the root
pom.xml and it brings oauth as a transitive dependency?
I'll try adding the
devcsrj requested changes on this pull request.
Also, could you post a copy of your the build results of this module in a gist,
or a pastie?
P.S.: Take care, and make sure **not** to include your credentials!
> + TemplateOptions options = template.getOptions();
+ final String loginUse
> Will try again...
Same failure again for me locally - probably something to do with my setup :-(
From the PR build, I notice that the driver bundle doesn't seem to be installed
in the features repo, which probably explains the error:
 That's why I did not write the live tests (yet). I was going to
do another PR with that, but if you can help me with setti
nelsonjr commented on this pull request.
>@SerializedNames({ "network", "accessConfigs" })
static NetworkInterface create(URI network, List
accessConfigs) {
- return new AutoValue_NewInstance_NetworkInterface(network,
accessConfigs);
+ return new AutoValue_NewIns
nelsonjr commented on this pull request.
>
/**
* This must be within the range specified by IPv4Range, and is typically
the first usable address in that range.
* If not specified, the default value is the first usable address in
IPv4Range.
*/
@Nullable public abstract
nelsonjr commented on this pull request.
> @@ -32,6 +35,7 @@
private List serviceAccounts;
private String bootDiskType;
private boolean preemptible = false;
+ private Set subnetworks;
[explained in previous comment] TL;DR: subnetworks = networks, multiple.
--
You are receiving t
nelsonjr commented on this pull request.
> +@Singleton
+public class SubnetworkLoader extends CacheLoader {
+ @Resource
+ protected Logger logger = Logger.NULL;
+
+ private final Resources resources;
+
+ @Inject
+ SubnetworkLoader(Resources resources) {
+ this.resources = resource
nelsonjr commented on this pull request.
> @@ -136,11 +136,17 @@
URI network = URI.create(networks.next());
assert !networks.hasNext() : "Error: Options should specify only one
network";
+ Iterator subnetworks = options.getSubnetworks().iterator();
+
+ URI subnetwork =
@andreaturli pushed 1 commit.
7b35424 fix Deployment
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320/files/817350313452bc7227c25deb0db60f0602821b68..7b354241feeb74af24199b75527b4ccb731a1a6d
- refactor logback-test.xml
- change jsonBall to Value
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/320
-- Commit Summary --
* separate the DeploymentToVMDeployment to a function
-- File Changes --
M
azurecompute-arm/src/
merged at
(master)[http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/89cb6f0f]
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-248317509
Closed #308.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308#event-795734646
@andreaturli pushed 1 commit.
07007d9 refactor logback-test.xml
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308/files/8f403aa5cc1c711496a670c3fbf3e03eadca969e..07007d994a33b1cc3c62a6294e8760141014758e
@andreaturli pushed 2 commits.
12f49f2 add parser module
8f403aa separate the DeploymentToVMDeployment to a function
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/308/files/aaae68457526b198a2b30d7f648b4ef0b
> Could you try the build locally with all tests
Hrm, am getting a different failure (first time around) locally:
```
Failed tests: testB2Feature:org.jclouds.karaf.itests.MiscFeaturesInstallationT
est.testB2Feature:KarafTestContainer{mvn:org.apache.karaf\/apache-karaf\/2.3.11\
/tar.gz}(org.jclo
nacx commented on this pull request.
> @@ -46,9 +44,9 @@ protected void bindErrorHandlers() {
@Override
protected void installLocations() {
super.installLocations();
- bind(ImplicitLocationSupplier.class).
- to(OnlyLocationOrFirstRegionOptionallyMatchingRegionId.
I don't really know. It is not the build itself, but the karaf feature resolver
the one that pulls the dependency. I've created a brand new build copied from
jclouds-karaf called `jclouds-karaf-with-azure`, but it presents the same
failure.
Also tried changing the build to not use the local Mave
19 matches
Mail list logo
