Thanks for taking care of this, Ignasi!
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/33#issuecomment-248757354
> Yay! It worked just adding the feature
Yayayay!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248728348
@olivierlemasle
Yes, the code will still be quite useful for a few situations! I mostly wanted
to add a comment to the code to ensure the limitations are documented. As for
the tests, I think at least unit tests would be nice. For live tests, you can
use devstack to test locally, but let's get
looks so clean, thx @nacx ! Merge it right away!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/321#issuecomment-248651612
```
Failed tests:
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891
ยป Provision
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->BaseComputeServiceLiveTest.createAndRunAServiceInGroup
@andreaturli Can you give this a try?
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/321
-- Commit Summary --
* Use the existing region suppliers to filter
-- File Changes --
M
azurecompute-arm/src/main/java/org/jclouds/azu
alibazlamit commented on this pull request.
> + public List call() throws Exception {
+logger.trace("<< fetching snapshots");
+List remoteSnapshots = api.snapshotApi().list(new
DepthOptions().depth(1));
+logger.trace(">> snapshots feched.");
+
+
Hi @zack-shoylev
Thanks for your comments.
Yes, I'm aware that the retry mechanisms will not work if the authentication is
performed with a token. However, in some cases, this authentication type can
still be useful, and if the token is invalid, an error should be raised.
Regarding the tests,
thx @nacx, merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/28c56e06)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248632037
Closed #320.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#event-797411872
nacx approved this pull request.
> private final ProviderMetadata providerMetadata;
+ private final DeploymentToVMDeployment deploymentToVMDeployment;
Better declare and inject it as `Function` to make it
easier to re-bind.
> @@ -288,7 +279,7 @@ public VMImage getImage(final String id)
Just minors. let's merge it, since I plan to open a PR with the minor fixes in
a while.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248627353
[
https://issues.apache.org/jira/browse/JCLOUDS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abdysamat Mamutov updated JCLOUDS-1182:
---
Affects Version/s: 2.0.0
> Missing region in `listAssignableLocations` for AWS EC2
>
[
https://issues.apache.org/jira/browse/JCLOUDS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abdysamat Mamutov updated JCLOUDS-1182:
---
Component/s: jclouds-compute
> Missing region in `listAssignableLocations` for AWS E
This changes the signature of the compute methods to have better predicates for
nodes. Without this, most methods could only use a `Predicate`
or a `Predicate`, which was pretty inconvenient, because generic
predicates such as `NodePredicates.all()` or concrete ones like
`NodePredicates.inGroup
[
https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509550#comment-15509550
]
ASF subversion and git services commented on JCLOUDS-664:
-
Commit
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-cli/pull/33
-- Commit Summary --
* JCLOUDS-664: Added Azure ARM to jclouds-cli
-- File Changes --
M assembly/pom.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-cli/pull/3
Yay! It worked just adding the feature :) I've squashed the commits and merged
to master as
[b1152f3d](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/b1152f3d).
Thanks for all the help @demobox!
BTW, the ServiceMix bundles will be released by the end of this month, so
perhaps we are
Closed #84.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#event-796949828
[
https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509241#comment-15509241
]
ASF subversion and git services commented on JCLOUDS-664:
-
Commit
@nacx pushed 1 commit.
3371b37 Added missing Azure ARM feature
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84/files/91f25d4305c928801fe980d98aee48fedd6406f6..3371b37b8403a3a61087e35b6477c75c37e3ebc4
@nacx: Aha! I think we might be missing an entry [in this
section](https://github.com/jclouds/jclouds-karaf/blob/master/feature/pom.xml#L107-L161)...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds
Sure :) I'll add it there and update the PR, and if it still fails I'll add the
dependency to the root pom (I don't really know the details of how it works but
I bet we'd need both)... And I'll try to cleanup my local env and see if I can
make it fail the same way our CI builds fail!
--
You a
23 matches
Mail list logo
