@andreaturli pushed 1 commit.
7bbd5fc addressing more comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90/files/31184ff15c5d8aa6f2b2c7af0f10f17e811c33b0..7bbd5fc5d7f14d7ed12b76cadf37bf9757ff936e
andreaturli commented on this pull request.
>// note that you can check if a provider is present ahead of time
checkArgument(contains(allKeys, provider), "provider %s not in supported
list: %s", provider, allKeys);
-
- String identity = args[1];
- String credential =
andreaturli commented on this pull request.
> // Create Container
- BlobStore blobStore = context.getBlobStore();
Location location = null;
not sure I follow, looking at the git history I can see this commit
andreaturli commented on this pull request.
> @@ -51,6 +51,11 @@
google-compute-engine
${jclouds.version}
+
+ io.cloudsoft.jclouds.api
+ openstack-mitaka-nova
+ 1.9.3-cloudsoft.20160831
+
oh, don't know why it's there, I'll remove it right away
andrewgaul requested changes on this pull request.
> @@ -51,6 +51,11 @@
google-compute-engine
${jclouds.version}
+
+ io.cloudsoft.jclouds.api
+ openstack-mitaka-nova
+ 1.9.3-cloudsoft.20160831
+
What is this for?
> // Create Container
-
andreaturli commented on this pull request.
> @@ -138,6 +154,10 @@ public static void main(String[] args) throws
> IOException {
}
} finally {
+ // delete cointainer
+ if (blobStore.containerExists(containerName)) {
ok
--
You are receiving this
@andreaturli pushed 1 commit.
df0e785 address comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90/files/70f574af20bc8f30d5835d907411fe85ab259945..df0e785adec6ca32582aef2d942190cfb4370fa4
andreaturli commented on this pull request.
> @@ -69,35 +73,47 @@
public static void main(String[] args) throws IOException {
- if (args.length < PARAMETERS)
+ String provider;
+ String identity;
+ String credential;
+ String containerName;
+ String
andreaturli commented on this pull request.
>
// Init
- BlobStoreContext context = ContextBuilder.newBuilder(provider)
- .credentials(identity,
credential)
-
andreaturli commented on this pull request.
> Location location = null;
if (apiMetadata instanceof SwiftApiMetadata) {
location = Iterables.getFirst(blobStore.listAssignableLocations(),
null);
}
- blobStore.createContainerInLocation(location,
andreaturli commented on this pull request.
> @@ -69,35 +73,47 @@
public static void main(String[] args) throws IOException {
- if (args.length < PARAMETERS)
+ String provider;
+ String identity;
+ String credential;
+ String containerName;
+ String
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/91
-- Commit Summary --
* Upgrade compute examples to 2.0.0
-- File Changes --
M chef-basics/pom.xml (9)
M
andrewgaul requested changes on this pull request.
> @@ -138,6 +154,10 @@ public static void main(String[] args) throws
> IOException {
}
} finally {
+ // delete cointainer
+ if (blobStore.containerExists(containerName)) {
Should be OK to remove
Merged #190.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#event-871361747
thanks @demobox and @nacx, merging now!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#issuecomment-262821539
> All looks good to me; current build is still running
Ah, I see you just killed it ;-) Will kick off another one...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> I've just edited the build and changed the labs providers to those that make
> sense
Just looked at that config diff ;-) All looks good to me; current build is
still running. Thanks, @nacx!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Uops :) I've just edited the build and changed the labs providers to those that
make sense. All yours from the current point.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> http://jclouds-javadocs.elasticbeanstalk.com/ still shows 2.0.0-SNAPSHOT docs
> - is that broken? I guess it should be 2.0.1-SNAPSHOT now?
It looks like that one is actually [on
me](https://github.com/demobox/jclouds-aggregate-javadocs/commit/a11b49340c68ea093b021c785fe4e0a6c9031678)
-
>http://jclouds-javadocs.elasticbeanstalk.com/ still shows 2.0.0-SNAPSHOT docs
>- is that broken? I guess it should be 2.0.1-SNAPSHOT now?
I'll have a look at this
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#pullrequestreview-10075676
Changes look good - thanks @andreaturli! Just two related points:
* Javadoc still needs to be published?
http://jclouds.apache.org/reference/javadoc/1.9.x/ points at 1.9.2
* http://jclouds-javadocs.elasticbeanstalk.com/ still shows 2.0.0-SNAPSHOT docs
- is that broken? I guess it should be
demobox requested changes on this pull request.
>// note that you can check if a provider is present ahead of time
checkArgument(contains(allKeys, provider), "provider %s not in supported
list: %s", provider, allKeys);
-
- String identity = args[1];
- String credential
Go to
http://1d547f9a57b7cf99a2cc-3d89fc21b654ea514b9e52407d648ba8.r20.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 1 commit.
7b48221 fix typos in releasenotes for 1.9.3
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
thanks @nacx, good spot!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#issuecomment-262815836
nacx commented on this pull request.
> @@ -7,6 +7,7 @@ permalink: /releasenotes/
The Release Notes and Javadocs for every major release of Apache jclouds are
listed chronologically below.
* [2.0.0](/releasenotes/2.0.0) | [Javadoc](/reference/javadoc/2.0.x/)
+* [1.9.2](/releasenotes/1.9.3)
@demobox can you have another shot at it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#issuecomment-262810954
andreaturli commented on this pull request.
> +## Introduction
+
+You can read the official announcement at [Apache jclouds 1.9.3
released](http://markmail.org/thread/qlapnppmfbilje7p). To get started with
jclouds, please see the [jclouds installation guide](/start/install/).
+
+This is a
Go to
http://47ea4e8a996157d05ad1-c393c86521b0d7767f466e64c39494f3.r51.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 1 commit.
56cbcbd fix typos in releasenetes for 1.9.3
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@nacx how are we going to proceed with this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-262791295
demobox commented on this pull request.
> @@ -238,4 +240,12 @@ private static String
> getValueOrPropertyOrEnvironmentVariable(
}
return value;
}
+
+ private static String getCredentialValue(String provider, String
credential) {
+ return credential != null &&
update README.md
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/90
-- Commit Summary --
* update blobstore-basics to use 2.0.0
-- File Changes --
M blobstore-basics/README.md (11)
M blobstore-basics/pom.xml (4)
nacx commented on this pull request.
> @@ -238,4 +240,12 @@ private static String
> getValueOrPropertyOrEnvironmentVariable(
}
return value;
}
+
+ private static String getCredentialValue(String provider, String
credential) {
+ return credential != null &&
> Also: do we need to make any updates to other projects for this?
No, changes are transparent to other jclouds-karaf projects and the CLI.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
36 matches
Mail list logo
