demobox commented on this pull request.
> @@ -20,7 +20,7 @@
- - %msg%n
+ %msg%n
How does this compare with the logging for other examples?
> docker
-
- 2.0.0-SNAPSHOT
+ ${jclouds.version}
Have we been able to verify that this change works as e
> are you happy with the status of this PR?
@andreaturli Looks good to me - thanks for the updates, Andrea
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-2630
demobox approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#pullrequestreview-10220721
@felfert pushed 1 commit.
730cecd Simplified code according to code review
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1042/files/487f5e8be846745fd3ad182b3fe592f381643d1e..730cecd174f6a769518ebf2d12125f78bc9506
Later: Just realized, that the tags are a Set and associated with a
node so: Of course that makes sense :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#issuecomment-263073020
@nacx I looked into the tag api documentation and I think, it does **not** fit
the jclouds semantic. In jclouds, those are `Map`, but in
DigitalOcean they have Map where Object is currently always a
droplet. (Most likely, it's an Integer-Id, just like with their key API).
I'm going to change ma
nacx commented on this pull request.
Thanks for the fix @felfert!
Since we don't support yet tags (we should implement the [tag
api](https://developers.digitalocean.com/documentation/v2/#tags) and open a
JIRA to track this), I think there is no need to keep using the
`metadataAndTagsAsCommaDel
[
https://issues.apache.org/jira/browse/JCLOUDS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1206:
Component/s: (was: jclouds-drivers)
> Handling of user_data in digitalocean2 provider
[
https://issues.apache.org/jira/browse/JCLOUDS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1206:
Labels: digitalocean (was: )
> Handling of user_data in digitalocean2 provider is broken
@demobox are you happy with the status of this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-263066699
[
https://issues.apache.org/jira/browse/JCLOUDS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697770#comment-15697770
]
Fritz Elfert commented on JCLOUDS-1206:
---
This pull request on github fixes the iss
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1042
-- Commit Summary --
* Fixes JCLOUDS-1206
-- File Changes --
M
providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceAdapter.java
Fritz Elfert created JCLOUDS-1206:
-
Summary: Handling of user_data in digitalocean2 provider is broken
Key: JCLOUDS-1206
URL: https://issues.apache.org/jira/browse/JCLOUDS-1206
Project: jclouds
13 matches
Mail list logo
