[jclouds/jclouds] Change BaseSwiftApiLiveTest to inherit from BaseBlobStoreIntegrationT… (#1044)

2016-12-19 Thread Zack Shoylev
…est and use its methods Based on an old suggestion from https://github.com/jclouds/jclouds/pull/935 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1044 -- Commit Summary -- * Change BaseSwiftApiLiveTest to inherit from

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread vpanghal
@vpanghal pushed 1 commit. 4682963 Fix formatting -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1043/files/bc01fd5a2f0e4e866d2e0c0a5add2a995f57d2b0..46829639b0acf9df24b58a50fcded28d63d64fca

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread vpanghal
vpanghal commented on this pull request. > @Inject ApacheHCHttpCommandExecutorService(HttpUtils utils, ContentMetadataCodec contentMetadataCodec, DelegatingRetryHandler retryHandler, IOExceptionRetryHandler ioRetryHandler, DelegatingErrorHandler errorHandler,

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread vpanghal
vpanghal commented on this pull request. > @Inject OkHttpCommandExecutorService(HttpUtils utils, ContentMetadataCodec contentMetadataCodec, DelegatingRetryHandler retryHandler, IOExceptionRetryHandler ioRetryHandler, DelegatingErrorHandler errorHandler, HttpWire

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread vpanghal
vpanghal commented on this pull request. > @Inject public JavaUrlHttpCommandExecutorService(HttpUtils utils, ContentMetadataCodec contentMetadataCodec, DelegatingRetryHandler retryHandler, IOExceptionRetryHandler ioRetryHandler, DelegatingErrorHandler

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread Zack Shoylev
> In our use case, we would like to override the complete user agent string. Good to know! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1043#issuecomment-268059499

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread Zack Shoylev
zack-shoylev commented on this pull request. > @Inject public JavaUrlHttpCommandExecutorService(HttpUtils utils, ContentMetadataCodec contentMetadataCodec, DelegatingRetryHandler retryHandler, IOExceptionRetryHandler ioRetryHandler, DelegatingErrorHandler

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread Zack Shoylev
zack-shoylev commented on this pull request. > @Inject OkHttpCommandExecutorService(HttpUtils utils, ContentMetadataCodec contentMetadataCodec, DelegatingRetryHandler retryHandler, IOExceptionRetryHandler ioRetryHandler, DelegatingErrorHandler errorHandler,

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread Zack Shoylev
zack-shoylev commented on this pull request. > @Inject ApacheHCHttpCommandExecutorService(HttpUtils utils, ContentMetadataCodec contentMetadataCodec, DelegatingRetryHandler retryHandler, IOExceptionRetryHandler ioRetryHandler, DelegatingErrorHandler errorHandler,

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread vpanghal
Checkstyle did not complain about whitespaces. Can you please point to the code where whitespace is off? In our use case, we would like to override the complete user agent string. I think overriding gives complete control to the caller. Caller is free to send what jclouds is sending and append

Re: [jclouds/jclouds] Make user agent header configurable (#1043)

2016-12-19 Thread Zack Shoylev
Whitespace seems a bit off. I also would have preferred concatenating additional information on the default user agent string instead of replacing it, I think. Thoughts? Is a completely custom user agent required for an application? -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-labs] JCLOUDS-1216 - oneandone-user-api (#336)

2016-12-19 Thread alibazlamit
alibazlamit commented on this pull request. > +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import org.apache.jclouds.oneandone.rest.domain.User; +import org.apache.jclouds.oneandone.rest.domain.options.GenericQueryOptions; +import

Re: [jclouds/jclouds-labs] JCLOUDS-1216 - oneandone-user-api (#336)

2016-12-19 Thread alibazlamit
alibazlamit commented on this pull request. > + public void testGet() { + User result = userApi().get(currentUser.id()); + + assertEquals(result.id(), currentUser.id()); + } + + @Test(dependsOnMethods = "testGet") + public void testUpdate() throws InterruptedException { +