Thanks! Mind squashing the commits into a single one to make the merge cleaner?
I'll have a final look then and merge the PR. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pu
nacx requested changes on this pull request.
I've added some more comments. Regarding the live test failure, could you share
the complete stacktrace?
> @@ -67,7 +78,8 @@ protected Builder() {
.apiMetadata(new OneAndOneApiMetadata())
.homepage(URI.create("https
nacx requested changes on this pull request.
> +import org.jclouds.http.HttpRequest;
+import org.jclouds.http.HttpRequestFilter;
+import org.jclouds.rest.annotations.ApiVersion;
+
+import com.google.common.net.HttpHeaders;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+
+@S
@nacx updated with the reviewed items, still having the same issue with live
tests, any idea?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/338#issuecomment-272119712
Reopened #338.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/338#event-920436686
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/343
-- Commit Summary --
* add AddApiVersionToRequest filter
-- File Changes --
M packet/src/main/java/org/jclouds/packet/PacketApiMetadata.java (1)
M packet/src/main/java/
