Cool @andreaturli! There is a thing I don't get. How are initial credentials
configured? I mean, there are no "default credentials" for the images (the
image transformation function does not set them), and there are no properties
to globally configure the default credentials. In that scenario, j
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1056#pullrequestreview-19186556
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1056
-- Commit Summary --
* change hostname command to get the short form
-- File Changes --
M
compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java
(
latest push has still, unit and live tests fine
```
Results :
Tests run: 53, Failures: 0, Errors: 0, Skipped: 0
```
thanks @nacx for the suggestion about not passing creds and for removing waitOn
device, easier impl
--
You are receiving this because you are subscribed to this thread.
Reply to t
andreaturli commented on this pull request.
> + }
+ }
+
+ @Override
+ public void testOptionToNotBlock() throws Exception {
+ // Packet ComputeService implementation has to block until the node
+ // is provisioned, to be able to return it.
+ }
+
+ @Override
+ protected
@andreaturli pushed 1 commit.
50ff3c8 address review comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/354/files/0de7a600118cd3b9970a98efd6c62658f85e6970..50ff3c871b43ced16f848fc0dacc9cf8a64ab06c
nacx commented on this pull request.
> + }
+ }
+
+ @Override
+ public void testOptionToNotBlock() throws Exception {
+ // Packet ComputeService implementation has to block until the node
+ // is provisioned, to be able to return it.
+ }
+
+ @Override
+ protected void c
https://jclouds.ci.cloudbees.com/job/jclouds-cli-2.0.x-branch/19/
https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-2.0.x-branch/20/
https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-2.0.x-branch/org.apache.jclouds.labs$jclouds-labs-aws/20/
andreaturli commented on this pull request.
> + }
+ }
+
+ @Override
+ public void testOptionToNotBlock() throws Exception {
+ // Packet ComputeService implementation has to block until the node
+ // is provisioned, to be able to return it.
+ }
+
+ @Override
+ protected
Closed #353.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/353#event-941416244
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/64bdc801)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/84f31cb8).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
http
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6b35f6fd)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a5a4f30b).
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on Git
Closed #351.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/351#event-941414548
@andreaturli pushed 3 commits.
8477274 add feature-labs.xml file
609e664 wip
0a37d2e wip
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/44bec200d1c6241c3b042217df78e09529ef61a2..0a37d2e7740cf242a6
nacx commented on this pull request.
> +import com.google.common.base.Supplier;
+import com.google.common.collect.Collections2;
+import com.google.inject.Inject;
+
+public class ImageSupplier implements Supplier>,
Function {
+ private final Function, Collection> outdatedBoxesFilter;
+ priva
neykov commented on this pull request.
> +import com.google.common.base.Supplier;
+import com.google.common.collect.Collections2;
+import com.google.inject.Inject;
+
+public class ImageSupplier implements Supplier>,
Function {
+ private final Function, Collection> outdatedBoxesFilter;
+ pri
https://jclouds.ci.cloudbees.com/job/jclouds-karaf-2.0.x-branch/21/
https://jclouds.ci.cloudbees.com/job/jclouds-cli-2.0.x-branch/18/--
Started by upstream project "jclouds-karaf-2.0.x-branch" build number 21
originally caused by:
Started by an SCM change
Building remotely on 789d8cdc (standard m1.large lxc-fedora17 large) i
https://jclouds.ci.cloudbees.com/job/jclouds-cli/1285/
https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds$jclouds-karaf/2072/
https://jclouds.ci.cloudbees.com/job/jclouds-karaf/2072/
nacx requested changes on this pull request.
> +import com.google.common.base.Supplier;
+import com.google.common.collect.Collections2;
+import com.google.inject.Inject;
+
+public class ImageSupplier implements Supplier>,
Function {
+ private final Function, Collection> outdatedBoxesFilter;
+
https://jclouds.ci.cloudbees.com/job/jclouds-cli/1284/Changes:
[Ignasi Barrera] Add Vagrant provider
--
[...truncated 573.70 KB...]
Downloading:
https://repository-jclouds.forge.cloudbees.com/release/org/sonatype/sisu/inject/guava-parent/0.9.9/guava-parent
nacx requested changes on this pull request.
Looks pretty good! Mostly comments about server authentication.
> + * defines the connection between the {@link org.jclouds.packet.PacketApi}
> implementation and
+ * the jclouds {@link org.jclouds.compute.ComputeService}
+ */
+@Singleton
+public clas
Thanks @neykov! Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-cli/commit/be5a874e)
and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-cli/commit/36f73c1f)
after fixing the [missing
bits](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/fa6e706e) in
jcloud
Closed #36.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/36#event-941036824
28 matches
Mail list logo