Re: [jclouds/jclouds] JIRA_1250 (#1104)

2017-05-19 Thread Andrew Gaul
Prefix commit with JCLOUDS-1250 so that JIRA tags it correctly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1104#issuecomment-302836897

Re: [jclouds/jclouds] JIRA_1250 (#1104)

2017-05-19 Thread Andrew Gaul
This does not include an integration test which fails before this commit and succeeds after merging it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1104#issuecomment-302836861

Re: [jclouds/jclouds-labs] Update endpoint to v3 (#390)

2017-05-19 Thread alibazlamit
@alibazlamit pushed 1 commit. a8ddb48 Add nat option to NIC in accordance with v3 -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Update endpoint to v3 (#390)

2017-05-19 Thread alibazlamit
@alibazlamit pushed 1 commit. 54acd7f Add cpuFamily to CreateServerRequestBinder.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jclouds/jclouds-labs] Update endpoint to v3 (#390)

2017-05-19 Thread alibazlamit
@nacx Could you please merge this PR, i have updated the endpoint in the ProfitBricksProviderMetadata to the latest API endpoint v3, it was left at v2 which is the older version. Thanks You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-19 Thread Andrew Gaul
andrewgaul commented on this pull request. > + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS

[jira] [Commented] (JCLOUDS-1303) Cannot create VM on Azure ARM mode

2017-05-19 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017472#comment-16017472 ] Andrea Turli commented on JCLOUDS-1303: --- thanks [~conor.daly] for reporting the issue Looks like

[jira] [Assigned] (JCLOUDS-1303) Cannot create VM on Azure ARM mode

2017-05-19 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Turli reassigned JCLOUDS-1303: - Assignee: Andrea Turli > Cannot create VM on Azure ARM mode >

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-19 Thread Andrea Turli
andreaturli commented on this pull request. > + @AutoValue.Builder + public abstract static class Builder { + public abstract Builder destinationCidrBlock(String destinationCidrBlock); + + public abstract Builder gatewayId(String gatewayId); + + public abstract Builder

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-19 Thread Geoff Macartney
hi @andreaturli, I've added a commit addressing the comments you made. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1100#issuecomment-302707715

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-19 Thread Geoff Macartney
@geomacy pushed 1 commit. 0248431 Add code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1100/files/49c5c47adaf80efff8b722c3a3efd278ae2d4781..024843132066d56a2b9a3221edf03a964a275b5a

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-19 Thread Geoff Macartney
geomacy commented on this pull request. > + @AutoValue.Builder + public abstract static class Builder { + public abstract Builder destinationCidrBlock(String destinationCidrBlock); + + public abstract Builder gatewayId(String gatewayId); + + public abstract Builder

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-19 Thread Geoff Macartney
geomacy commented on this pull request. > + return new AutoValue_RouteTableAssociation.Builder(); + } + + @AutoValue.Builder + public abstract static class Builder { + public abstract Builder id(String id); + public abstract Builder routeTableId(String routeTableId); +

Re: [jclouds/jclouds] Add ModifySubnetAttribute (#1102)

2017-05-19 Thread Geoff Macartney
@geomacy pushed 1 commit. 70860c7 Add comment explaining the @SinceApiVersion override. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-19 Thread archupsg03
@archupsg03 pushed 1 commit. 2fe1ef3 Build failure issue addressed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1090/files/e4eff0dc0c167f6a3d4bdc654d4d9a12d85bbdd8..2fe1ef35fd4c65f6602b0f0b80466f6550e61331

Re: [jclouds/jclouds] Add ModifySubnetAttribute (#1102)

2017-05-19 Thread Geoff Macartney
hi @nacx thanks for the explanation of the wiring. I've tried to run live tests, but may not be set up for it - the tests have `@SinceApiVersion` are ``` find . -name '*Api.java' | xargs grep -l SinceApiVersion | sed 's#.*/##' | while read file ; do find . -name ${file%.java}LiveTest.java;

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-19 Thread archupsg03
@archupsg03 pushed 1 commit. e4eff0d Build failure issue addressed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1090/files/297610fe9120f6e37b33810c2f673c3c5a256a99..e4eff0dc0c167f6a3d4bdc654d4d9a12d85bbdd8

[jclouds/jclouds] JIRA_1250 (#1104)

2017-05-19 Thread archupsg03
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1104 -- Commit Summary -- * JIRA Defect 1250, containerExist check -- File Changes -- M

[jira] [Created] (JCLOUDS-1303) Cannot create VM on Azure ARM mode

2017-05-19 Thread Conor Daly (JIRA)
Conor Daly created JCLOUDS-1303: --- Summary: Cannot create VM on Azure ARM mode Key: JCLOUDS-1303 URL: https://issues.apache.org/jira/browse/JCLOUDS-1303 Project: jclouds Issue Type: Bug

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-19 Thread archupsg03
@archupsg03 pushed 1 commit. c6f17c1 Comments Address - Except separation of higher and lower level abstraction -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jira] [Commented] (JCLOUDS-1302) wish to support the OSS of the Aliyun

2017-05-19 Thread Steven Meng (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017079#comment-16017079 ] Steven Meng commented on JCLOUDS-1302: -- [~andreaturli] can you provide some information about the

[jira] [Commented] (JCLOUDS-1302) wish to support the OSS of the Aliyun

2017-05-19 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017015#comment-16017015 ] Andrea Turli commented on JCLOUDS-1302: --- @zreal let us know if we can help, that provider will

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-19 Thread archupsg03
archupsg03 commented on this pull request. > + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS

[jclouds/jclouds] Promote Packet (#1103)

2017-05-19 Thread Ignasi Barrera
The Packet provider implements all the features from the portable compute abstraction it supports and has been stable for the last releases. There have not been live tests failures in the weekly test builds, so I think it is ready to be promoted. /cc @andrewgaul @zack-shoylev You can view,