Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-05-23 Thread Andrew Gaul
andrewgaul commented on this pull request. > + @BinderParam(SetPayload.class) Payload blob, + @BinderParam(BindObjectMetadataToHeaders.class) Map metadata, + @BinderParam(BindToHeaders.class) Map headers); + + /** +* Delete objects.

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-05-23 Thread archupsg03
archupsg03 commented on this pull request. > + @BinderParam(SetPayload.class) Payload blob, + @BinderParam(BindObjectMetadataToHeaders.class) Map metadata, + @BinderParam(BindToHeaders.class) Map headers); + + /** +* Delete objects.

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-05-23 Thread archupsg03
archupsg03 commented on this pull request. > +* @param metadata +* corresponds to {@link SwiftObject#getMetadata()}. +* @param headers +* Binds the map to headers, without prefixing/escaping the header +* name/key. +* +* @return {@link

Re: [jclouds/jclouds] JIRA-1250 (#1104)

2017-05-23 Thread Andrew Gaul
andrewgaul commented on this pull request. > } + @Test(expectedExceptions = { IllegalStateException.class }) + public void getBlobTestFailure() { + blobStore.containerExists(CONTAINER_TEMP); Sorry I don't understand. You should be able to demonstrate the utility of this pull

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-05-23 Thread Andrew Gaul
andrewgaul requested changes on this pull request. @archupsg03 I have more comments but let's address the first set. As you make changes, please reply "Done" to each individual comment. @timuralp please review `DynamicLargeObjectApi`. > + @BinderParam(SetPayload.class) Payload blob, +

[jira] [Reopened] (JCLOUDS-1270) AWS us-east-1 region is not in the list of returned regions

2017-05-23 Thread Paya Ashkan (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paya Ashkan reopened JCLOUDS-1270: -- This is actually not a duplicate of JCLOUDS-1265 since that ticket is about us-standard and this

Re: [jclouds/jclouds-labs] Adding support for provisioning of Windows VMs with enabled WinRM (#393)

2017-05-23 Thread Andrea Turli
andreaturli commented on this pull request. thanks @ygy -- looks really useful some comments from my quick review, haven't executed the live tests though > +* Windows configuration parameters +* +* @see

[jira] [Resolved] (JCLOUDS-1270) AWS us-east-1 region is not in the list of returned regions

2017-05-23 Thread Paya Ashkan (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paya Ashkan resolved JCLOUDS-1270. -- Resolution: Duplicate > AWS us-east-1 region is not in the list of returned regions >

[jclouds/jclouds-labs] Adding support for provisioning of Windows VMs with enabled WinRM (#393)

2017-05-23 Thread ygy
- Provisioning using pre-existing KeyVault - Enabling WinRM with pre-existing certificate You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/393 -- Commit Summary -- * Adding support for provisioning of Windows VMs with enabled WinRM

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-23 Thread Geoff Macartney
Note the new test util [enqueueXml(Response.Status, String, String)](https://github.com/jclouds/jclouds/pull/1100/files#diff-8c2525316d73049be95880788b72ccd1R161) in BaseAWSEC2ApiMockTest which may be of use elsewhere. -- You are receiving this because you are subscribed to this thread. Reply

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-23 Thread Geoff Macartney
hi @nacx, @andreaturli, I have pushed changes for the review comments made. For convenience of review I have left these as separate commits. I can squash them before merge. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-23 Thread Geoff Macartney
@geomacy pushed 13 commits. 8a84ac6 Remove autoBuild where not needed. b6a3772 Remove unusable logger. ac03910 Add 'origin' to Route and remove unused hidden accessors. f02436d Remove another unused logger, and unused imports. b002ed6 Have a separate RouteTableOptions and RouteOptions.

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-05-23 Thread archupsg03
@archupsg03 pushed 1 commit. 0dff0ae DLO - Comments Added -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1105/files/28ec26db280a6efdf17a9085bbc6d2efb47e00a7..0dff0ae919f6c11550300940aba5f3b7e96f7a77

[jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-05-23 Thread archupsg03
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1105 -- Commit Summary -- * DLO - Lower Level Provider API changes -- File Changes -- M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/SwiftApi.java (6) A

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-23 Thread Geoff Macartney
Thanks for the comments @andreaturli, @nacx, will address them as soon as I can -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1100#issuecomment-303331717

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-23 Thread Geoff Macartney
geomacy commented on this pull request. > + @AutoValue.Builder + public abstract static class Builder { + public abstract Builder destinationCidrBlock(String destinationCidrBlock); + + public abstract Builder gatewayId(String gatewayId); + + public abstract Builder

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-23 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks @geomacy! > +import org.jclouds.json.SerializedNames; +import org.jclouds.logging.Logger; + +import com.google.auto.value.AutoValue; + +/** + * A route in an Amazon EC2 Route Table. + * + * @see

Jenkins build is back to normal : jclouds-karaf-2.0.x-branch #84

2017-05-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-aws-2.0.x-branch » jcloud elb api #80

2017-05-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-aws-2.0.x-branch #80

2017-05-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs » Apache jclouds labs #1551

2017-05-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs » jclouds Azure Compute ARM API #1551

2017-05-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-2.0.x-branch #98

2017-05-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-labs-2.0.x-branch » Apache jclouds labs #98

2017-05-23 Thread jenkins-no-reply
See

Re: [jclouds/jclouds-labs] Update endpoint to v3 (#390)

2017-05-23 Thread Ignasi Barrera
Looks good. That's the right dependency to be added... http://search.maven.org/#artifactdetails%7Corg.apache.jclouds.labs%7Cprofitbricks-rest%7C2.0.1%7Cbundle -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Fixes India regions to their actual name (#392)

2017-05-23 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/3bd117ec) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d8887b74). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds-labs] Fixes India regions to their actual name (#392)

2017-05-23 Thread Ignasi Barrera
Closed #392. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/392#event-1093021811