Re: [jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

2017-05-26 Thread Вальо
The problem which I was hitting without if I update disks section of a vm with : ```java DataDisk newDataDisk = DataDisk.builder().name("managed-disk") // .caching(DataDisk.CachingTypes.READ_WRITE) //. .build(); ``` and in request for updating

Re: [jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

2017-05-26 Thread Вальо
Examples if someone wants to add tests for managed disks operations https://docs.microsoft.com/en-us/rest/api/manageddisks/disks/disks-create-or-update -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

2017-05-26 Thread Вальо
- Fix DataDisk.CachingTypes.fromValue to recognize values properly - Fix tests which had blob disks and managed disks at the same time - At this point managed disks are used by default and should be tested. You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] Add ModifySubnetAttribute (#1102)

2017-05-26 Thread Geoff Macartney
hi @nacx, per our conversation on IRC I have reverted to using a custom annotation, but put a [comment](https://github.com/jclouds/jclouds/pull/1102/files#diff-d646d0465e56af59039c3489721bf61aR29) on it explaining that it is meant only as a temporary measure to decouple the new function in

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-26 Thread Geoff Macartney
Thanks @nacx, changes squashed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1100#issuecomment-304282154

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-26 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1100#pullrequestreview-40514504

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-26 Thread Ignasi Barrera
Looks good, thanks! Mind squashing the commits? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1100#issuecomment-304276407

Re: [jclouds/jclouds] Add first draft of a RouteTable API. (#1100)

2017-05-26 Thread Geoff Macartney
hi @nacx, @andreaturli, I hope this is good to go now, do you think it can be merged? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1100#issuecomment-304269821

[jclouds/jclouds] JCLOUDS-1295: Support deprecated date formats in the Expires header (#1107)

2017-05-26 Thread Ignasi Barrera
https://issues.apache.org/jira/browse/JCLOUDS-1295 @neykov Mind trying Azure ARM with this fix? You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1107 -- Commit Summary -- * JCLOUDS-1295: Support deprecated date formats in the Expires

[jira] [Assigned] (JCLOUDS-1295) Azure ARM Improve "Expires" header handling

2017-05-26 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-1295: --- Assignee: Ignasi Barrera > Azure ARM Improve "Expires" header handling >

[jira] [Commented] (JCLOUDS-1293) AWS ERROR - Unexpected end of file from server

2017-05-26 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025901#comment-16025901 ] Ignasi Barrera commented on JCLOUDS-1293: - Thanks for sharing your tests in the issue. Your code