nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#pullrequestreview-50258245
thanks @nacx let's wait for the builder as extra-check.
Meanwhile I'm rebasing and squashing
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315695894
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315703226
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315703315
merging to master only
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315707761
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089559#comment-16089559
]
ASF subversion and git services commented on JCLOUDS-1318:
--
Com
Closed #1117.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#event-1166125075
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/aa11765b)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315709952
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli updated JCLOUDS-1318:
--
Flags: Important
Affects Version/s: 2.0.0
2.0.2
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli resolved JCLOUDS-1318.
---
Resolution: Fixed
> Security group created for the server is not deleted
> -
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1318:
Labels: openstack-nova (was: )
> Security group created for the server is not deleted
> -
Without request body, there's no point in asking for 100-continue.
With
[JavaUrlHttpCommandExecutor](https://github.com/jclouds/jclouds/blob/f3c3f3b30620ad62dc502cf79bf121ec1773396e/core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java),
HttpUrlConnection is throwin
nacx requested changes on this pull request.
Thanks @ChaithanyaGK!
@andrewgaul Mind having a look?
> @@ -357,6 +357,22 @@ public GeneratedHttpRequest apply(Invocation invocation)
> {
if (request.getPayload() != null) {
contentMetadataCodec.fromHeaders(request.getPayload().getCo
Merged to
[master](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=3641cdb44c192be381f82d8886f966c248474f4d)
and
[2.0.x](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=f27b5f944887bdefba78d7bbd339ea68db76725c)
--
You are receiving this because y
Closed #402.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/402#event-1166369934
* clojure support removed from core
* reference to non-existent `ApacheAntComputeGuide`
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/199
-- Commit Summary --
* Remove Clojure references, support removed from core
* Remove refe
Go to
http://52e5085fc260ceb67e22-fa0c3b2f9d9bfd5ea649b5c10dacaba5.r41.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment
Can you remove the "Usage in Google AppEngine" too?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment-315756600
Go to
http://ee3f1ff390343e30f39b-d136f4782a6445a9196f897e7072ec57.r95.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment
Done @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment-315760120
Depends on https://github.com/jclouds/jclouds/pull/1119 being released.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/200
-- Commit Summary --
* Workaround to revert to shared credential store
-- File Changes --
M start/com
Go to
http://84e8de0da1a2915bcbe5-02f621e7bc2c992c40c304cd38334419.r49.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment
Go to
http://7980e4076c61b89e82eb-ee8aa8198f8d15624472c3c54569b0e1.r61.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#issuecomment
Svetoslav Neykov created JCLOUDS-1321:
-
Summary: Per-compute-service credential store
Key: JCLOUDS-1321
URL: https://issues.apache.org/jira/browse/JCLOUDS-1321
Project: jclouds
Issue Type
* Jira (to be included in release notes):
https://issues.apache.org/jira/browse/JCLOUDS-1321
* Heads up to the mailing lists:
*
[user@j.a.o](https://lists.apache.org/thread.html/c65711e3ca3b3ffe068fc6562f0db98336772984924f24857ee0bdcd@%3Cuser.jclouds.apache.org%3E)
*
[dev@j.a.o](https://list
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#pullrequestreview-50330756
nacx approved this pull request.
Thansk @neykov!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#pullrequestreview-50331119
Go to
http://f87fb730277b7ff7bcc2-6998e5196134be870bcb4bdbdaf08877.r71.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#issuecomment
Merged #199.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#event-1166533045
Go to
http://71d71ba2b69c1873f826-64134700c51c773ca3459cdb14bd1042.r2.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment-
Thanks @nacx for taking a look, appreciate that you took time out to review our
pull request during the 2.0.2 release.
I will review the comments you have raised on this pull request and update.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
[Merged](https://git1-us-west.apache.org/repos/asf?p=jclouds-site.git;a=commit;h=94b98475f77b0ed6b9d9e3db2e05209b19c523f4)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issue
ChaithanyaGK commented on this pull request.
> @@ -357,6 +357,22 @@ public GeneratedHttpRequest apply(Invocation invocation)
> {
if (request.getPayload() != null) {
contentMetadataCodec.fromHeaders(request.getPayload().getContentMetadata(),
headers);
}
+
+ boolean
demobox commented on this pull request.
> + * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
I recall a lot of discussion and trial and error in the past trying to get this
to work across providers and versions - from what I recall, there were API bugs
to work around etc. etc.
As such, unless we can verify that those conditions no longer exist, I'd be
very hesitant to changing more tha
> I'll also go looking a bit through the archives...
Here's a few:
* https://groups.google.com/forum/#!topic/jclouds-dev/H6Q5mhpCq0c
*
https://github.com/rackspace/jclouds/commit/d897c5e44717e3d66062cd1275033e414f6a2de2
* https://issues.apache.org/jira/browse/JCLOUDS-181
--
You are receiving t
@demobox pushed 1 commit.
d34f70d Minor suggested text edit to the "pre-2.1.0" note
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200/files/c87b4acdbd9c7d679ddd9165f8f20533c9ed49be..d34f70de2c03c9013d67916d3
Go to
http://f65b776042714e5b0791-9883cc9304202abd55a5101f881b1528.r52.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#issuecomment
demobox commented on this pull request.
> @@ -548,3 +548,20 @@ The jclouds API allows many `Statements` to be built
> entirely from high-level co
without having to resort to OS-specific scripts. This enables developers to
express what they mean without having
to deal with the gory details o
Nice catch - thanks, @neykov!
@nacx Do you think it would make sense to add "check for references in the
docs" as a TODO item for contributors and/or reviewers?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github
For what it is worth, jclouds has a GAE driver although it may have bit-rotted:
https://issues.apache.org/jira/browse/JCLOUDS-836
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/1
andrewgaul requested changes on this pull request.
Which existing integration test exercises this code path? If none exists,
please add one. Also post the results from some real providers.
> @@ -73,7 +73,7 @@ public void testZeroLengthPutHasContentLengthHeader()
> throws IOException, Interr
@neykov mind publishing the changes to the website? You can use the
`deploy-site` script.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/199#issuecomment-315969271
nacx commented on this pull request.
> @@ -548,3 +548,20 @@ The jclouds API allows many `Statements` to be built
> entirely from high-level co
without having to resort to OS-specific scripts. This enables developers to
express what they mean without having
to deal with the gory details of v
nacx commented on this pull request.
> + * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either exp
45 matches
Mail list logo
