andrewgaul commented on this pull request.
> @@ -0,0 +1,3 @@
+
Remove message from queue review. Repeated a few times.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
andrewgaul commented on this pull request.
> +package org.jclouds.azure.storage.internal;
+
+import org.jclouds.apis.ApiMetadata;
+import org.jclouds.apis.BaseApiLiveTest;
+import org.jclouds.azure.storage.AzureStorageQueueApi;
+import org.jclouds.azure.storage.AzureStorageQueueApiMetadata;
+
andrewgaul commented on this pull request.
> +import org.jclouds.util.Strings2;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.Properties;
+import java.util.Set;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+final class AzureQueueTestUtils {
+ static
```
$ mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout
-Dcheckstyle.output.format=plain
Starting audit...
/home/gaul/work/jclouds-labs/azure-queue-storage/src/main/java/org/jclouds/azure/storage/domain/internals/Queue.java:0:
warning: File does not end with a newline.
For the style check I run `mvn checkstyle:checkstyle
-Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain` locally
but can not reproduce the failures.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
q225zhan commented on this pull request.
> +import org.jclouds.util.Strings2;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.Properties;
+import java.util.Set;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+final class AzureQueueTestUtils {
+ static
CloudBees should show the Checkstyle violations after you fix the unit test
failures. You can configure your IDE to use our Checkstyle configuration or
run the following command:
```
mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout
-Dcheckstyle.output.format=plain
```
--
You
andrewgaul commented on this pull request.
> +import org.jclouds.util.Strings2;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.Properties;
+import java.util.Set;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+final class AzureQueueTestUtils {
+ static
Patch updated. PTAL.
There are another 2 failures which may need your help:
1. Missing system variables, See here:
https://github.com/jclouds/jclouds-labs/pull/405/files#diff-57c740ed0979ce85c8d059a120e1b5bbR46.
We need to set that 2 var for test run. I can send you via PM.
2. Style check:
@nacx -- at some point the endpoint URL for Azure ARM calls broke. This PR
fixes that. I'm not sure when/how the exact breakage (change to JClouds
maybe?) occurred. Tested using jclouds-examples/compute-basics.
--
You are receiving this because you are subscribed to this thread.
Reply to
[
https://issues.apache.org/jira/browse/JCLOUDS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul resolved JCLOUDS-1325.
--
Resolution: Fixed
Fix Version/s: 2.1.0
> JAXBParser does not ignore Unicode byte order
[
https://issues.apache.org/jira/browse/JCLOUDS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103572#comment-16103572
]
ASF subversion and git services commented on JCLOUDS-1325:
--
Commit
Andrew Gaul created JCLOUDS-1325:
Summary: JAXBParser does not ignore Unicode byte order mark
Key: JCLOUDS-1325
URL: https://issues.apache.org/jira/browse/JCLOUDS-1325
Project: jclouds
Issue
[
https://issues.apache.org/jira/browse/JCLOUDS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Svetoslav Neykov resolved JCLOUDS-1321.
---
Resolution: Fixed
Fix Version/s: 2.1.0
Merged to
[master](https://git1-us-west.apache.org/repos/asf/jclouds/?p=jclouds.git;a=commit;h=2487b0c5132191de5e68413e33dfa551b5679ebb).
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
neykov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1124#pullrequestreview-52592661
The change was surprising to me, I expected Java to handle the BOM. After
digging deeper I found
[[1]](https://stackoverflow.com/questions/4897876/reading-utf-8-bom-marker)
which points to two JDK bugs
[[2]](http://bugs.java.com/view_bug.do?bug_id=4508058) and
nacx approved this pull request.
Thanks! Worth registering a JIRA issue for this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1124#pullrequestreview-52586145
Added test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1124#issuecomment-318290320
andrewgaul commented on this pull request.
> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.jclouds.labs
+jclouds-labs
+2.1.0-SNAPSHOT
+
+
+azure-queue-storage
+
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/405#issuecomment-318283569
LGTM so far. Is there any existing test that verifies the behavior of this
class? If not, could we add some of them to make sure we don't introduce
regressions?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
22 matches
Mail list logo
