Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + } + + @Override + public Boolean apply(final String serverId) { + final ServerApi serverApi = api.getServerApi(); + Server server = serverApi.getServer(serverId); + + if (server == null) { + return true; + } + +

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + String networkDomainId = server.networkInfo().networkDomainId(); + final String internalIp = server.networkInfo().primaryNic().privateIpv4(); + + // delete nat rules associated to the server, if any + final Netwo

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. f04c95d Implementing BaseImageToHardware and CleanupServer functions. PR updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/422/files/08d902d63383da37b3fdc6b2024d0a623ac

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 9d78555 Implementing BaseImageToHardware and CleanupServer functions. PR updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/422/files/f04c95db74621e32aea2e6ad9f6996f7d10

Re: [jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

2017-12-02 Thread Andrew Gaul
gaul commented on this pull request. >String invalidPathBlobKey = "Ahttps://github.com/jclouds/jclouds/pull/1162#pullrequestreview-80685315