nacx commented on this pull request.
> + }
+ }
+
+ private void attemptDeleteNatRule(final String serverId, final NetworkApi
networkApi, final NatRule natRule) {
+ try {
+ if (natRule.state().isNormal()) {
+networkApi.deleteNatRule(natRule.id());
+ }
@trevorflanagan pushed 1 commit.
4b3a037 Implementing BaseImageToHardware and CleanupServer functions. PR
updates.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
trevorflanagan commented on this pull request.
> + String networkDomainId = server.networkInfo().networkDomainId();
+ final String internalIp =
server.networkInfo().primaryNic().privateIpv4();
+
+ // delete nat rules associated to the server, if any
+ final
nacx commented on this pull request.
> + String networkDomainId = server.networkInfo().networkDomainId();
+ final String internalIp =
server.networkInfo().primaryNic().privateIpv4();
+
+ // delete nat rules associated to the server, if any
+ final NetworkApi
[
https://issues.apache.org/jira/browse/JCLOUDS-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deyan updated JCLOUDS-1364:
---
Description:
When I try to retrieve an object from default region (s3.amazonaws.com) and the
object is
Deyan created JCLOUDS-1364:
--
Summary: Get object fails when Permanent Redirect is in place from
aws
Key: JCLOUDS-1364
URL: https://issues.apache.org/jira/browse/JCLOUDS-1364
Project: jclouds
Issue
Thanks for the review @jmspring! According to your comments I've slightly
changed the PR to:
* Support both formats of the OAuth endpoint (tests added).
* Extracted the service principal call into a GraphRBACApi class, so we can add
additional methods there as needed.
* Modified the structure
@nacx pushed 1 commit.
67c5466 Configure the Graph RBAC API and allow mocking service endpoints
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
