Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @trevorflanagan! > +import java.util.List; + +@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class }) +@Consumes(MediaType.APPLICATION_JSON) +@Path("/{jclouds.api-version}/tag") +public interface TagApi { + + @Named("tag:createTagKe

Re: [jclouds/jclouds-labs-openstack] Feature/neutron security group (#209)

2017-12-06 Thread Ignasi Barrera
So with this change, we're not looking up the extension in the service catalog and we assume the endpoint is always the preconfigured one. Fine by me, but that could introduce backward-compatibility issues we need to write down in the release notes. Could you file a JIRA issue so we don't miss t

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-06 Thread Jim Spring
@jmspring pushed 1 commit. b3b1164 fix lint issues -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/416/files/5fdc2519bda0002ab366890c49be869e70e9663f..b3b1164b284996fbe50914f5bfe4b8dd2e9edc10

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-06 Thread Jim Spring
@jmspring pushed 1 commit. 5fdc251 don't use wildcard import -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/416/files/fb858b5491b912f696c7ab61216f3fb73eb6919d..5fdc2519bda0002ab366890c49be869e70e9663f

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -143,7 +143,7 @@ public void testDeleteTagKey() throws Exception { @Test public void testTagKeyById() throws Exception { - server.enqueue(jsonResponse("/tagKey.json")); + server.enqueue(jsonResponse("/tagkey.json")); caught

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. aab0692 Adding the Dimension Data Tag API interface. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425/files/b5021dae177ec8f76f1ec76bab53498cacc1e466..aab069263f3475b4f19d74a

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-06 Thread Jim Spring
@jmspring pushed 1 commit. fb858b5 integrate updated graphrbac api -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/416/files/be61d50fe8b6561a2dc638b753cffc2fe3a95102..fb858b5491b912f696c7ab61216f3fb73eb6919d

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. b5021da Adding the Dimension Data Tag API interface. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425/files/e67b0018f713086d9e901b7c8b8bf6d11578a5a5..b5021dae177ec8f76f1ec76

[jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
This will be useful for supporting Groups and also for the functions that create the subclasses of `org.jclouds.compute.domain.internal.ComputeMetadataImpl#tags` You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/425 -- Commit Summary

Re: [jclouds/jclouds-labs-openstack] remove Neutron direct hard-link from openstack services (#208)

2017-12-06 Thread Andrea Turli
Closed #208. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/208#event-1374899036

Re: [jclouds/jclouds-labs-openstack] remove Neutron direct hard-link from openstack services (#208)

2017-12-06 Thread Andrea Turli
closing as no longer required for now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/208#issuecomment-349657798