Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-15 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. aef83ec Refactor DimensionDataCloudControlResponseUtils waitFor* methods so that they are injectable. PR Updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/427/files/b88

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-15 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + private final NetworkApi networkApi; + + private NetworkDomainState(final NetworkApi networkApi, final State state) { + this.networkApi = networkApi; + this.state = state; + } + + @Override + public bool

[jira] [Commented] (JCLOUDS-1302) Aliyun OSS blobstore

2017-12-15 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292664#comment-16292664 ] Andrew Gaul commented on JCLOUDS-1302: -- [~zreal] Please submit a pull request again

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-15 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @trevorflanagan! Just one small comment. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions()