Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-18 Thread Jim Spring
@jmspring pushed 1 commit. fd2c2e1 use predicates for wait -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/416/files/3dcf25eb34f2965e1301de0ef5dbb54574f2ffd4..fd2c2e191d00d35ef3f7222497e8bf8807fd40f5

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-18 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions() .as(DimensionDataCloudControlTempla

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-18 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions() .as(DimensionDataCloudControlTemplateOptions.

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Ignasi Barrera
Closed #427. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/427#event-1392092950

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Ignasi Barrera
Squashed and pushed tp [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/889b34b9) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/bf34887e). Thanks @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this ema

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > } @Provides @Named(SERVER_STOPPED_PREDICATE) @VisibleForTesting public Predicate provideServerStoppedPredicate(final DimensionDataCloudControlApi api, final ComputeServiceConstants.Timeouts timeouts, final Compute

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 349211f Refactor DimensionDataCloudControlResponseUtils waitFor* methods so that they are injectable. PR Updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/427/files/aef

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-18 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions() .as(DimensionDataCloudControlTempla

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Ignasi Barrera
nacx commented on this pull request. Just one minor left. Thanks! > } @Provides @Named(SERVER_STOPPED_PREDICATE) @VisibleForTesting public Predicate provideServerStoppedPredicate(final DimensionDataCloudControlApi api, final ComputeServiceConstants.Timeouts timeou