@nacx I think I've addressed most of your comments and now the duplication of
`Find/Create` SecurityGroup is gone.
I still have some expected tests to fix but please let me know if the code is
more readable now. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply
@andreaturli pushed 1 commit.
0bdbdbf addressing Nacx comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1175/files/7846a2ddf32ed07e6fc394a43d954fc6fe039d28..0bdbdbf29214504f4e676e0afd6fb43f83275e4e
@nacx thanks for the review
Main reason I have 2 couples of `Create/FindSecurityGroup` now (I want to
remove them before merging this PR) is because of `NovaSecurityGroupExtension`
and `NeutronSecurityGroupExtension`
`NovaSecurityGroupExtension` needs to use `NovaApi` to create security groups,
nacx requested changes on this pull request.
Thanks @andreaturli! Looks like a great starting point.
Apart from the comments I've made I found it difficult to understand the
duplicated "Create/FindSecurityGroup" classes. For a proper review, could you
please:
* Explain what is each new class,
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1377:
Component/s: jclouds-compute
> Support Neutron-based Openstack installation from Nova
> --
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1377:
Affects Version/s: 2.0.3
> Support Neutron-based Openstack installation from Nova
> --
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1377:
Labels: openstack-neutron openstack-nova (was: )
> Support Neutron-based Openstack instal
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332225#comment-16332225
]
Andrea Turli commented on JCLOUDS-1377:
---
see https://github.com/jclouds/jclouds/pu
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli reassigned JCLOUDS-1377:
-
Assignee: Andrea Turli
> Support Neutron-based Openstack installation from Nova
> -
cc @nacx
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1175
-- Commit Summary --
* [JCLOUDS-1377] add support for injectable Neutron Context into Nova
-- File Changes --
M apis/openstack-nova/pom.xml (5)
M
apis/openstack-n
Andrea Turli created JCLOUDS-1377:
-
Summary: Support Neutron-based Openstack installation from Nova
Key: JCLOUDS-1377
URL: https://issues.apache.org/jira/browse/JCLOUDS-1377
Project: jclouds
11 matches
Mail list logo
