Re: [jclouds/jclouds-examples] 2.1.0 (#92)

2018-03-21 Thread Andrew Phillips
> fix README.md > clean up pom.xml Thanks for adding those changes, Andrea. Looks good to me! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/92#issuecomment-375121157

Re: [jclouds/jclouds-examples] 2.1.0 (#92)

2018-03-21 Thread Andrew Phillips
demobox approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/92#pullrequestreview-105936085

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-03-21 Thread Andrea Turli
andreaturli requested changes on this pull request. great start @alibazlamit! I've only some comments, feel free to ask for clarification! As I don't have access to oneandone it would be nice if you could attach the results of live tests before merging this. Thanks > @@ -65,6 +66,7 @@ priv

Re: [jclouds/jclouds-examples] 2.1.0 (#92)

2018-03-21 Thread Ignasi Barrera
nacx approved this pull request. Thanks for taking care of this! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/92#pullrequestreview-105769149