[jira] [Created] (JCLOUDS-1408) Consider relying on jaxb-api

2018-04-13 Thread Andrew Gaul (JIRA)
Andrew Gaul created JCLOUDS-1408: Summary: Consider relying on jaxb-api Key: JCLOUDS-1408 URL: https://issues.apache.org/jira/browse/JCLOUDS-1408 Project: jclouds Issue Type: Improvement

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Trevor Flanagan
> Change looks good. Would it make sense, though, to create a couple filter > objects ListServerOptions and ListDatacenterOptions that extend > PaginationOptions and introduce the datacenter query parameters? if the > datacenter filter parameter is optional, then it would be better and cleaner

[jclouds/jclouds-labs] JCLOUDS-1407 - Dimensiondata Server API 2.6 support (#434)

2018-04-13 Thread Boris Trishkin
Server API 2.6 support implementation You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/434 -- Commit Summary -- * Server API 2.6 support -- File Changes -- A dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol

[jira] [Updated] (JCLOUDS-1407) Add dimensiondata server API v2.6 support

2018-04-13 Thread Boris Trishkin (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Trishkin updated JCLOUDS-1407: Labels: dimensiondata (was: ) > Add dimensiondata server API v2.6 support >

[jira] [Updated] (JCLOUDS-1407) Add dimensiondata server API v2.6 support

2018-04-13 Thread Boris Trishkin (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Trishkin updated JCLOUDS-1407: Component/s: jclouds-labs > Add dimensiondata server API v2.6 support > -

[jira] [Updated] (JCLOUDS-1407) Add dimensiondata server API v2.6 support

2018-04-13 Thread Boris Trishkin (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Trishkin updated JCLOUDS-1407: Fix Version/s: 2.1.1 2.2.0 > Add dimensiondata server API v2.6 support

[jira] [Updated] (JCLOUDS-1407) Add dimensiondata server API v2.6 support

2018-04-13 Thread Boris Trishkin (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Trishkin updated JCLOUDS-1407: Affects Version/s: 2.1.0 > Add dimensiondata server API v2.6 support > --

[jira] [Created] (JCLOUDS-1407) Add dimensiondata server API v2.6 support

2018-04-13 Thread Boris Trishkin (JIRA)
Boris Trishkin created JCLOUDS-1407: --- Summary: Add dimensiondata server API v2.6 support Key: JCLOUDS-1407 URL: https://issues.apache.org/jira/browse/JCLOUDS-1407 Project: jclouds Issue Ty

Re: [jclouds/jclouds-labs] Implement ServerWithNatRuleToNodeMetadata Function (#428)

2018-04-13 Thread Boris Trishkin
@nacx small issue fixed and commits squashed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/428#issuecomment-381082477

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Trevor Flanagan
trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -40,6 +51,16 @@ @ConfiguresHttpApi public class DimensionDataCloudControlHttpApiModule extends HttpApiModule { + @Override + protected void installLocations() { + super.installLocations(); + bind(RegionIdToURISupplier.class)

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Ignasi Barrera
FTR, there was a small bug in the `LocationsSupplier` that did not properly filter the zones by the values configured in the `jclouds.zones` property. It is fixed in https://github.com/jclouds/jclouds/pull/1195. -- You are receiving this because you are subscribed to this thread. Reply to this

[jclouds/jclouds] Consider the zone id filter in the location supplier (#1195)

2018-04-13 Thread Ignasi Barrera
When configuring locations from properties, the `ZoneIdsSupplier` is [already filtered](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/location/config/LocationModule.java#L129) by the value of the `jclouds.regions` property. However, the [default implementation](ht

Re: [jclouds/jclouds-labs] Implement ServerWithNatRuleToNodeMetadata Function (#428)

2018-04-13 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @btrishkin! Just one minor comment left. Apart from that, LGTM! > + */ +package org.jclouds.dimensiondata.cloudcontrol.compute.functions; + +import com.google.common.base.Function; +import com.google.inject.Singleton; +import org.jclouds.compute.domain.