FileIOUtility commented on this pull request.
> } else if (message.contains("NAME_NOT_UNIQUE")) {
exception = new ResourceAlreadyExistsException(message,
exception);
+} else if (message.contains("UNEXPECTED_ERROR")
+ || message.contains(
FileIOUtility commented on this pull request.
revisited error propagation as suggested
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#pullrequestreview-135072543
@FileIOUtility pushed 1 commit.
5d1305b JCLOUD-51 - review - revisit error propagation,
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439/files/77e3a337dcb5b53c1d60f2cf9ebf3dea9a451653..5d1305b5ce3af48226b70
- add securitygroup-api
- add keypair-api
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/441
-- Commit Summary --
* [JCLOUDS-1430] - add more features
-- File Changes --
M aliyun-ecs/src/main/java/org/jclouds/aliyun/ecs/ECSC
andreaturli commented on this pull request.
> +import org.apache.jclouds.oneandone.rest.internal.BaseOneAndOneApiMockTest;
+import org.testng.annotations.Test;
+
+import java.util.List;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
+
+@Test(grou
andreaturli commented on this pull request.
> +@Test(groups = "live", testName = "SshKeyApiLiveTest")
+public class SshKeyApiLiveTest extends BaseOneAndOneLiveTest {
+
+ private SshKey currentSshKey;
+ private List sshKeys;
+
+ private SshKeyApi sshKeyApi() {
+ return api.sshKeyApi();
andreaturli commented on this pull request.
> +import org.apache.jclouds.oneandone.rest.internal.BaseOneAndOneApiMockTest;
+import org.testng.annotations.Test;
+
+import java.util.List;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
+
+@Test(grou
[
https://issues.apache.org/jira/browse/JCLOUDS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534727#comment-16534727
]
ASF subversion and git services commented on JCLOUDS-1430:
--
Co
thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-403009918
merged at
[mater](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f38f8045)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-403009890
Closed #440.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#event-1720091784
andreaturli requested changes on this pull request.
some minor changes, but good overall. Thanks @alibazlamit
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeabl
squashed and merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-403008358
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#pullrequestreview-134980120
@andreaturli pushed 1 commit.
753df7f more improvements
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440/files/c3e6c8ce7bcac795620cfebaf93898eef52692dd..753df7f3e6853d008aa290ce6f185c193f728d5f
Yes, LGTM, although I'd keep the "action" parameter separate and use the map
just for the additional ones. The assertions would look more consistent with
the methods that don't have extra params.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly o
any better @nacx ? thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-402994493
@andreaturli pushed 1 commit.
c3e6c8c better assertSent
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440/files/5dc166e56659bae37f57601c55d4073c13e25fc9..c3e6c8ce7bcac795620cfebaf93898eef52692dd
andreaturli commented on this pull request.
>RecordedRequest request = server.takeRequest();
assertEquals(request.getMethod(), method);
Map queryParameters =
Splitter.on('&').trimResults().withKeyValueSeparator("=").split(request.getPath());
assertEquals(queryParame
nacx requested changes on this pull request.
>RecordedRequest request = server.takeRequest();
assertEquals(request.getMethod(), method);
Map queryParameters =
Splitter.on('&').trimResults().withKeyValueSeparator("=").split(request.getPath());
assertEquals(queryParam
@andreaturli pushed 1 commit.
5dc166e address comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440/files/f2e15c37bbc7ff71f7ebdc992d9387b7ba41b816..5dc166e56659bae37f57601c55d4073c13e25fc9
andreaturli commented on this pull request.
> + assertSent(server, "GET", "DescribeRegions");
+ }
+
+ public void testListRegionsReturns404() {
+ server.enqueue(response404());
+ List regions = api.regionAndZoneApi().describeRegions();
+ assertTrue(isEmpty(regions));
+
nacx commented on this pull request.
> + assertSent(server, "GET", "DescribeRegions");
+ }
+
+ public void testListRegionsReturns404() {
+ server.enqueue(response404());
+ List regions = api.regionAndZoneApi().describeRegions();
+ assertTrue(isEmpty(regions));
+ asse
andreaturli commented on this pull request.
> + assertEquals(server.getRequestCount(), 1);
+ }
+
+ public void testListZones() throws InterruptedException {
+ server.enqueue(jsonResponse("/zones.json"));
+ List zones =
api.regionAndZoneApi().describeZones(Regions.EU_CENTRAL_1
andreaturli commented on this pull request.
> + *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the
andreaturli commented on this pull request.
> + assertSent(server, "GET", "DescribeRegions");
+ }
+
+ public void testListRegionsReturns404() {
+ server.enqueue(response404());
+ List regions = api.regionAndZoneApi().describeRegions();
+ assertTrue(isEmpty(regions));
+
andreaturli commented on this pull request.
> +package org.jclouds.aliyun.ecs.compute.features;
+
+import com.google.common.base.Predicate;
+import com.google.common.collect.Iterables;
+import
org.jclouds.aliyun.ecs.compute.internal.BaseECSComputeServiceApiLiveTest;
+import org.jclouds.aliyun.e
andreaturli commented on this pull request.
> + Map> networkTypes)
> {
+ return new AutoValue_ResourceInfo(ioOptimized, systemDiskCategories ==
null ?
+ImmutableMap.>of() :
+ImmutableMap.copyOf(systemDiskCategories),
+
nacx commented on this pull request.
> + Map> networkTypes)
> {
+ return new AutoValue_ResourceInfo(ioOptimized, systemDiskCategories ==
null ?
+ImmutableMap.>of() :
+ImmutableMap.copyOf(systemDiskCategories),
+instan
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/975aca53) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/00b6697d).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.
Closed #1222.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1222#event-1719716852
31 matches
Mail list logo
