nacx commented on this pull request.
Just one minor comment, otherwise LGTM. Does this PR depend on any other open
PR?
> @@ -260,4 +260,14 @@ public static OSImageType fromValue(String v) {
}
}
+
+ public enum FirewallRuleAction {
+ allow,
+ deny,
+ UNRECOGNIZED;
nacx commented on this pull request.
> ICMP, GRE, TCP, UDP, ALL;
+ public static IpProtocol fromValue(String value) {
+ Optional ipProtocol = Enums.getIfPresent(IpProtocol.class,
value.toUpperCase());
+ checkArgument(ipProtocol.isPresent(), "Expected one of %s but was %s",
